From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD96C48BE5 for ; Wed, 16 Jun 2021 09:16:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2036561055 for ; Wed, 16 Jun 2021 09:16:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2036561055 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wby3wsec1KRLBFIewDaY8vVLNKj7UnTIhyJI7V7BW8Y=; b=cFP2hrmbl47k1p JAhW9Pj1qY3CrboY2p+PyiRZBzvNJAvMsddC8+y0mjAmWc+u+PmyhSO9N7tnuNAhRBmdf0UnoGle3 65EJBWCpnYS/SbcVJ/ZPOTOnYMBrxPkYfSgJuL1UNxSTgibepccyxlW5ozgzsW2+rOIhgBH0yCgWa 5uQNPIBWc7SvDAuFLX377VoyMcLy+V24hQLxDiuyYmsaN0x2/ozObIRICxIEcf2Okk/kQjg/m6vvC 7InuXwkIhB8ty8c2j0Q04Y/vsqEPo2QdYiz/T9qYeD6Bu2shkLj+7PSSO7OLRRwuyOf3mUXm1Rn9h FCB/IdVwcQImak5JFKQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltRdR-005XcO-N3; Wed, 16 Jun 2021 09:14:57 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltRdI-005XaL-Hq for linux-arm-kernel@lists.infradead.org; Wed, 16 Jun 2021 09:14:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AE5B331B; Wed, 16 Jun 2021 02:14:46 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C97593F70D; Wed, 16 Jun 2021 02:14:43 -0700 (PDT) Date: Wed, 16 Jun 2021 10:14:36 +0100 From: Cristian Marussi To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com Subject: Re: [PATCH v4 12/16] firmware: arm_scmi: Add message passing abstractions for transports Message-ID: <20210616091436.GF35368@e120937-lin> References: <20210611165937.701-1-cristian.marussi@arm.com> <20210611165937.701-13-cristian.marussi@arm.com> <20210614151036.00000409@Huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210614151036.00000409@Huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210616_021448_692562_8196261C X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 14, 2021 at 03:10:36PM +0100, Jonathan Cameron wrote: > On Fri, 11 Jun 2021 17:59:33 +0100 > Cristian Marussi wrote: > > > From: Peter Hilber > > > > Add abstractions for future transports using message passing, such as > > virtio. Derive the abstractions from the shared memory abstractions. > > > > Abstract the transport SDU through the opaque struct scmi_msg_payld. > > Also enable the transport to determine all other required information > > about the transport SDU. > > > > Signed-off-by: Peter Hilber > > --- > ... > > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h > > index b783ae058c8a..fa4075336580 100644 > > --- a/drivers/firmware/arm_scmi/common.h > > +++ b/drivers/firmware/arm_scmi/common.h > > @@ -410,6 +410,21 @@ void shmem_clear_channel(struct scmi_shared_mem __iomem *shmem); > > bool shmem_poll_done(struct scmi_shared_mem __iomem *shmem, > > struct scmi_xfer *xfer); > > > > +/* declarations for message passing transports */ > > +struct scmi_msg_payld; > > + > > +/** Maximum overhead of message w.r.t. struct scmi_desc.max_msg_size */ > > Doesn't look to be kernel-doc.. > Right, I'll fix. Cristian > > +#define SCMI_MSG_MAX_PROT_OVERHEAD (2 * sizeof(__le32)) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel