From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD782C2B9F4 for ; Thu, 17 Jun 2021 11:59:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7D7461411 for ; Thu, 17 Jun 2021 11:59:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7D7461411 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ccCwKa+iyPtrW665iHHKAzSAUqWTGtjQO2YMUfzjA0U=; b=1+WgXnfgtRnygk kqZcj+M2RFBlsaNpWfqGQOlud6KAic+MwDlJ6sQFoPjbR3jLUbSVVqGqnzuzVCFGkQ4z/aqU2EBzj K6xyGNyqOnjoIoSgnTH3VaJl1JcOSI2nim4qpajwuTD9bSmNsvVLuR0ohr7grBQehtA2snQgGOJgF 52uM9iHdn1+kyEU2rlgD8B20sbn/168d/pDLk+ToUdkkPzGXp+hdq/lEzunXFBItV7QR4EFUB9291 2gd3fSPHwrTWf+EHw8w6jiMhcZsBBI3TDhUxzsMw4vfXRJCGtarGd41M7DtQebuUq0zHdDc4XV7gp 0KaehTn6S5JvjB25S6SQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltqes-00ABQx-K6; Thu, 17 Jun 2021 11:58:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltqel-00ABOJ-TB for linux-arm-kernel@lists.infradead.org; Thu, 17 Jun 2021 11:58:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B42011FB; Thu, 17 Jun 2021 04:57:56 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8EDF43F719; Thu, 17 Jun 2021 04:57:55 -0700 (PDT) Date: Thu, 17 Jun 2021 12:57:38 +0100 From: Andre Przywara To: mark.rutland@arm.com Cc: Jaxson Han , linux-arm-kernel@lists.infradead.org, wei.chen@arm.com Subject: Re: [boot-wrapper PATCH v3 0/8] Add Armv8-R AArch64 support Message-ID: <20210617125738.31f01418@slackpad.fritz.box> In-Reply-To: <20210525062509.201464-1-jaxson.han@arm.com> References: <20210525062509.201464-1-jaxson.han@arm.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_045800_054420_509ADD65 X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 25 May 2021 14:25:01 +0800 Jaxson Han wrote: Hi Mark, > Currently, we cannot boot Linux with boot-wrapper on Armv8-R AArch64: > 1. The Armv8-R AArch64 profile does not support the EL3. > 2. The Armv8-R AArch64 EL2 only supports a PMSA, which Linux does not > support. So it's necessary to drop into EL1 before entering the kernel. > 3. There is no EL2 booting code for Armv8-R AArch64 and no > configuration for dropping to EL1 in boot-wrapper. > > These patches enable boot-wrapper booting Linux with Armv8-R AArch64: > Patch 1 allows boot-wrapper to boot on more platforms. > Patch 2 renames some labels as preparations for booting from lower EL. > Patch 3 remove the redundant setup_stack. > Patch 4-5 does some preparations for lower EL booting. > Patch 6 prepares for GICv3 initialization with EL2. > Patch 7 adds necessary EL2 registers. > Patch 8 adds auto-detection for Armv8-R AArch64 to drop into EL1 > before entering the kernel. So I reviewed the whole series (replies with the missing tags for 2/8 and 8/8 are on the list), and am now happy with it. I also tested this for regressions with various v8-A models. I had some issues with the SMMU on RevC models, but this was also with boot-wrapper master and is unrelated to this series (as the kernel starts booting). So from my point of view this is good to go. Please let us know if you need more information or how we can help with anything to get this merged. Cheers, Andre > Refs: Arm Architecture Reference Manual Supplement - Armv8, for > Armv8-R AArch64 architecture profile. > [https://developer.arm.com/documentation/ddi0600/latest/] > > --- > v2 -> v3: > 1. Refine Patch 1 and move relevant changes into Patch 5 and 8. > 2. Refine Patch 8, more detailed comments and guarantees that those > CPUID fields never lose features when the value in a field increases. > > Jaxson Han (8): > Decouple V2M_SYS config by auto-detect dtb node > aarch64: Rename labels and prepare for lower EL booting > aarch64: Remove the redundant setup_stack > aarch64: Prepare for EL1 booting > aarch64: Prepare for lower EL booting > gic-v3: Prepare for gicv3 with EL2 > aarch64: Prepare for booting with EL2 > aarch64: Introduce EL2 boot code for Armv8-R AArch64 > > Makefile.am | 4 +- > arch/aarch32/include/asm/gic-v3.h | 7 ++ > arch/aarch64/boot.S | 151 +++++++++++++++++++++++++++--- > arch/aarch64/include/asm/cpu.h | 3 + > arch/aarch64/include/asm/gic-v3.h | 38 +++++++- > arch/aarch64/psci.S | 13 +-- > arch/aarch64/spin.S | 8 +- > arch/aarch64/utils.S | 10 +- > gic-v3.c | 2 +- > platform.c | 4 + > 10 files changed, 208 insertions(+), 32 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel