From: Anand Moon <linux.amoon@gmail.com>
To: --to=linux-phy@lists.infradead.org,
--to=linux-arm-kernel@lists.infradead.org,
--to=linux-amlogic@lists.infradead.org,
--to=linux-kernel@vger.kernel.org
Cc: Anand Moon <linux.amoon@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [RFCv1 2/8] phy: amlogic: meson8b-usb2: Use phy init callback function
Date: Thu, 17 Jun 2021 19:41:37 +0000 [thread overview]
Message-ID: <20210617194154.2397-3-linux.amoon@gmail.com> (raw)
In-Reply-To: <20210617194154.2397-1-linux.amoon@gmail.com>
Reorder the code for bulk clk_enable into .init callback function.
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
drivers/phy/amlogic/phy-meson8b-usb2.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c
index 771b73f3b44e..d48171b0b32e 100644
--- a/drivers/phy/amlogic/phy-meson8b-usb2.c
+++ b/drivers/phy/amlogic/phy-meson8b-usb2.c
@@ -142,10 +142,9 @@ static const struct regmap_config phy_meson8b_usb2_regmap_conf = {
.max_register = REG_TUNE,
};
-static int phy_meson8b_usb2_power_on(struct phy *phy)
+static int phy_meson8b_usb2_init(struct phy *phy)
{
struct phy_meson8b_usb2_priv *priv = phy_get_drvdata(phy);
- u32 reg;
int ret;
if (!IS_ERR_OR_NULL(priv->reset)) {
@@ -162,6 +161,14 @@ static int phy_meson8b_usb2_power_on(struct phy *phy)
return ret;
}
+ return 0;
+}
+
+static int phy_meson8b_usb2_power_on(struct phy *phy)
+{
+ struct phy_meson8b_usb2_priv *priv = phy_get_drvdata(phy);
+ u32 reg;
+
regmap_update_bits(priv->regmap, REG_CONFIG, REG_CONFIG_CLK_32k_ALTSEL,
REG_CONFIG_CLK_32k_ALTSEL);
@@ -219,6 +226,7 @@ static int phy_meson8b_usb2_power_off(struct phy *phy)
}
static const struct phy_ops phy_meson8b_usb2_ops = {
+ .init = phy_meson8b_usb2_init,
.power_on = phy_meson8b_usb2_power_on,
.power_off = phy_meson8b_usb2_power_off,
.owner = THIS_MODULE,
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-17 19:45 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 19:41 [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure Anand Moon
2021-06-17 19:41 ` [RFCv1 1/8] phy: amlogic: meson8b-usb2: Use clock bulk to get clocks for phy Anand Moon
2021-06-17 22:33 ` Martin Blumenstingl
2021-06-18 15:32 ` Anand Moon
2021-06-17 19:41 ` Anand Moon [this message]
2021-06-18 12:26 ` [RFCv1 2/8] phy: amlogic: meson8b-usb2: Use phy init callback function Martin Blumenstingl
2021-06-18 13:17 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 3/8] phy: amlogic: meson8b-usb2: Use phy exit " Anand Moon
2021-06-17 19:41 ` [RFCv1 4/8] phy: amlogic: meson8b-usb2: Use phy set_mode " Anand Moon
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-18 13:19 ` Anand Moon
2021-06-18 20:01 ` Martin Blumenstingl
2021-06-21 7:20 ` Anand Moon
2021-06-22 20:27 ` Martin Blumenstingl
2021-06-17 19:41 ` [RFCv1 5/8] phy: amlogic: meson8b-usb2: Reorder phy poweroff " Anand Moon
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-18 15:33 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 6/8] phy: amlogic: meson8b-usb2: Use phy reset " Anand Moon
2021-06-17 22:24 ` Martin Blumenstingl
2021-06-18 15:33 ` Anand Moon
2021-06-18 20:06 ` Martin Blumenstingl
2021-06-21 7:15 ` Anand Moon
2021-06-22 20:11 ` Martin Blumenstingl
2021-06-24 14:54 ` Anand Moon
2021-06-27 20:07 ` Anand Moon
2021-06-27 20:25 ` Martin Blumenstingl
2021-07-02 19:13 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 7/8] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Anand Moon
2021-06-17 22:37 ` Martin Blumenstingl
2021-06-21 7:15 ` Anand Moon
2021-06-22 20:00 ` Martin Blumenstingl
2021-06-17 19:41 ` [RFCv1 8/8] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER Anand Moon
2021-06-17 22:26 ` Martin Blumenstingl
2021-06-17 22:11 ` [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure Martin Blumenstingl
2021-06-18 13:20 ` Anand Moon
2021-06-18 20:16 ` Martin Blumenstingl
2021-06-21 7:21 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617194154.2397-3-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=--to=linux-amlogic@lists.infradead.org \
--cc=--to=linux-arm-kernel@lists.infradead.org \
--cc=--to=linux-kernel@vger.kernel.org \
--cc=--to=linux-phy@lists.infradead.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).