From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E861C4743C for ; Mon, 21 Jun 2021 14:36:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C0096128E for ; Mon, 21 Jun 2021 14:36:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C0096128E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wAGNIPm4mVjTcA8dC5lX1tppFcU0KCqBHc+/Zp2LI3A=; b=QR8uC/CdJBtcTg qPJKO4CoXHbPyCPebu0WadpcJFeJM5/VWZlQV/6EzfpbcDYEer4t6cQxG8s+B1DbpFVTmXcgvNXon fXVVYfFLDyrjCE9Bc/gOcIUbl2I4YYrF9kxWTcUWn6auxjOqx5eK5EYnlQYB1iVfmSa7YSRi5xzmG e+0lriIeAAe46UUhCJKGhk+eoU99RIrMtXlQDL2TXFT4SQw+kmf6j/1m8HhuH0V3kMlrpjPosIbYl bAsnrdcx2vliHBwoVLWB1rbe1YLdUfrVlp8cNug/E0fzGOM4ZhTCJQJAiTL6QWPCDORQjHfzQg4tq ULRNufWisInqnnV1/eGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvKzk-003mtX-12; Mon, 21 Jun 2021 14:33:48 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvKzg-003mry-2y for linux-arm-kernel@lists.infradead.org; Mon, 21 Jun 2021 14:33:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5QaQJhrlff70DLidq/ICZqB3tTQ+lIiyH5FQ4SHS5tw=; b=fzUkOvm1Tdr/8dWixqDSGLxI+ 5mVx/DfkJBrFFrq7DQSCMm19MYDwMW1FjG7TqMshyxpIbfp4aTVSNnQ+LGdbdNRKYBYNZ7jAjKLbH Lo/lAWze0JAWLVgeFI8KIE+//Skjv9nK2lGjmw7hpk1xVqGXVOsseIg2aMr0C5/KQxron45R/PLQ1 UDL/f55FI53A6Dz8M30hdRldipG8dL82JwMdHmIOUK4ZmCBwYu9usmdpknW5dhcNFQNRIknq9ipwK Oo1gxnov8R2nCv06JQxBWu1uF/vCsXJmlUcBeBuCny52Li/0V9sYvrIXCjcjKLVHRyjSFLL63A1x8 lbAiPKIVA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45228) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvKzX-0004GG-OC; Mon, 21 Jun 2021 15:33:35 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lvKzW-0002y2-Ru; Mon, 21 Jun 2021 15:33:34 +0100 Date: Mon, 21 Jun 2021 15:33:34 +0100 From: "Russell King (Oracle)" To: Steen Hegelund Cc: "David S. Miller" , Jakub Kicinski , Andrew Lunn , Microchip Linux Driver Support , Alexandre Belloni , Madalin Bucur , Mark Einon , Masahiro Yamada , Arnd Bergmann , Philipp Zabel , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjarni Jonasson , Lars Povlsen Subject: Re: [PATCH net-next v4 04/10] net: sparx5: add port module support Message-ID: <20210621143334.GN22278@shell.armlinux.org.uk> References: <20210615085034.1262457-1-steen.hegelund@microchip.com> <20210615085034.1262457-5-steen.hegelund@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210615085034.1262457-5-steen.hegelund@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210621_073344_188964_6F74440F X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Jun 15, 2021 at 10:50:28AM +0200, Steen Hegelund wrote: > +static int sparx5_port_pcs_low_set(struct sparx5 *sparx5, > + struct sparx5_port *port, > + struct sparx5_port_config *conf) > +{ > + bool sgmii = false, inband_aneg = false; > + int err; > + > + if (!port->conf.has_sfp) { > + sgmii = true; /* Phy is connnected to the MAC */ > + } else { > + if (conf->portmode == PHY_INTERFACE_MODE_SGMII || > + conf->portmode == PHY_INTERFACE_MODE_QSGMII) > + inband_aneg = true; /* Cisco-SGMII in-band-aneg */ > + else if (conf->portmode == PHY_INTERFACE_MODE_1000BASEX && > + conf->autoneg) > + inband_aneg = true; /* Clause-37 in-band-aneg */ I have to wonder why the presence of inband aneg depends on whether there's a SFP or not... We don't do that kind of thing in other drivers, so what is different here? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel