From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DCD0C2B9F4 for ; Tue, 22 Jun 2021 11:12:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D090D61352 for ; Tue, 22 Jun 2021 11:12:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D090D61352 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SRBtR9PeKJPOSII1+leyavaxWle79qT/fjHJCnMHois=; b=V2jZfA0dFTT+MJ oIlPwJyO15Oy+EeBtw2WKq7hDnMcTHOZpfDJF3vEBFyypqLjwTDhqydjye+egc6S9Jezkr85AHwLz zuNYqQCbdKAF1VEUuAlUdcFc9/LPSqQjAyVnq+9fNPSZEftxM2ODnZWoLLTD8gVN9JGFJuGTNCmdq MrnLkiVcmxDGcXHnTQoBuqF12b7WNQ6qTX4wk3vNho55FZlEmvtV5hfhhBH6GM7CKb6vWDcInrNSg RTc6yqM1o2ZOHnWyE7Fo+QmXDysnP4QtswuSHwMH6Bu/AV0dkoqjhpQg3wJOmpFFjAaaGco6ja/Lx CApZX62gsZgIoAPkxHzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lveIw-006sjc-VJ; Tue, 22 Jun 2021 11:10:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lveIr-006shf-0F for linux-arm-kernel@lists.infradead.org; Tue, 22 Jun 2021 11:10:50 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 127D561076; Tue, 22 Jun 2021 11:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624360248; bh=lqtyp4Cx8BPhhiC+aCM09V0C4tGXRAm837DZNpt2OJ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KgzLPLsxIOuVtQHlDR17vMyUPdcC12xCtUIm8CspHkucEl2g9RtOc/WA0x0LjBX5U ROxBCI2MAhTjJs/ePvAcnlUrPPOjYXAXEp21q0Xd0dzrI7mrswW6gP5orF7bdEVuGz PP3DpGsCCfmZXiI8aXvJur33iRUnVNbSZxfFAL3PQ6LA3aBbqPXruw87dLOzrGNb/U 1nc4pbAfhxQJybnHHTX76kC6nTfQJV7BB+vJGJjQ5Z9a1XadLl/XZWQQrjRd7rCloL azVz4DNCF4YYfD6ORrWj/RjxgwH0F/93X8CtoSwpy8aXFohiLBqibYnA2p8UFYApLF 15UyZTdo5hkug== Date: Tue, 22 Jun 2021 12:10:39 +0100 From: Will Deacon To: Mark Rutland Cc: Nick Desaulniers , Catalin Marinas , Kees Cook , Peter Zijlstra , Bill Wendling , Sami Tolvanen , Peter Oberparleiter , Masahiro Yamada , Miguel Ojeda , Nathan Chancellor , Luc Van Oostenryck , Ard Biesheuvel , Arnd Bergmann , Andrew Morton , Rasmus Villemoes , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, x86@kernel.org, Borislav Petkov , Martin Liska , Marco Elver , Jonathan Corbet , Fangrui Song , linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, Dmitry Vyukov , johannes.berg@intel.com, linux-toolchains@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] Kconfig: add ARCH_WANTS_NO_INSTR+CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO Message-ID: <20210622111039.GA30757@willie-the-truck> References: <20210621231822.2848305-1-ndesaulniers@google.com> <20210621231822.2848305-4-ndesaulniers@google.com> <20210622090540.GA67232@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210622090540.GA67232@C02TD0UTHF1T.local> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210622_041049_155919_AF8BB17B X-CRM114-Status: GOOD ( 17.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 22, 2021 at 10:05:40AM +0100, Mark Rutland wrote: > On Mon, Jun 21, 2021 at 04:18:22PM -0700, Nick Desaulniers wrote: > > We don't want compiler instrumentation to touch noinstr functions, which > > are annotated with the no_profile_instrument_function function > > attribute. Add a Kconfig test for this and make PGO and GCOV depend on > > it. > > > > If an architecture is using noinstr, it should denote that via this > > Kconfig value. That makes Kconfigs that depend on noinstr able to > > express dependencies in an architecturally agnostic way. > > > > Cc: Masahiro Yamada > > Cc: Peter Oberparleiter > > Link: https://lore.kernel.org/lkml/YMTn9yjuemKFLbws@hirez.programming.kicks-ass.net/ > > Link: https://lore.kernel.org/lkml/YMcssV%2Fn5IBGv4f0@hirez.programming.kicks-ass.net/ > > Suggested-by: Nathan Chancellor > > Suggested-by: Peter Zijlstra > > Signed-off-by: Nick Desaulniers > > FWIW, this looks good to me: > > Acked-by: Mark Rutland > > Catalin, Will, are you happy iwth the arm64 bit? Looks fine to me. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel