From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8418C2B9F4 for ; Tue, 22 Jun 2021 16:25:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C74960FE7 for ; Tue, 22 Jun 2021 16:25:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C74960FE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mKKiTV+wpk9XpY0uQ/dNITlDPLZBT/KJCYlSAZoYBWo=; b=HozEmPftXFejs24GEyKizhx7Xa yd7MAUcj2FOd+AlYo8E5SzqDZ7PbTiGdX8FMClEPHv7AyHx+nA2C+wPCTxoY91QuuX5irjDyKZEf3 yhiau5qb8n3M9nDfY1WT9kxxnVTboXv/WKGQP4vIZQ3N6Jcf6p1r1Y8uMg4395NqftQNBVpoiQmMu +pGk6erDFnqh9tLB4Vl+Xj11+qYSuYe6O5YwTRri5CKugR5GXigw0AkUbbh5xE68aodz/pbSCdXRC XqEPqPsacDgF62eBU8oHQeIvQgYLjlueWX5CNM+M5L3xrvpFjyby6Bj8uZ4rReX0LmYokox7cwSwh s3irgPLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvjBX-007tDh-0U; Tue, 22 Jun 2021 16:23:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvjBT-007tCw-0B for linux-arm-kernel@lists.infradead.org; Tue, 22 Jun 2021 16:23:32 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id EBAF860240; Tue, 22 Jun 2021 16:23:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624379010; bh=dvnbdNnOiv03SgjtecC7Dh5JlTHc3Gn16vJg0Lm+0VQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lIZK4me2EB7vjw3OO3BFGCQ6AOkbHde3QpzQhzvTRf4rBlt0/HJ16wOBqS6XKXP1n Os0RgH4qcR6j+Xj/PPQkHFPoTIFuV997H5bRIahKQ8R69mAdtSL8wH6j4XD7zK04Lk PF3vJYOXOfHPOhrUqBSMweeLRhq4B6Nu9pCCVt+lCOrZkj4GlxFbCLe3eL1hfstHLg OxnR/9MoQaKyZMQHZuKbD9hsvKfgUcoC4iro246CKO0gWQ1H1Q2x3JBKuCINIWi9os PKHI4n4SMcyrwbm1PnubdP3LzISh0K2Xb4Cwh1x3Jn439lHLJ52qon/UgEHbLCdbkd UdxJnAsXiMpHg== Date: Tue, 22 Jun 2021 17:23:07 +0100 From: Mark Brown To: Judy Hsiao Cc: Liam Girdwood , Rob Herring , Jaroslav Kysela , Takashi Iwai , Douglas Anderson , Dylan Reid , Jimmy Cheng-Yi Chiang , Judy Hsiao , Tzung-Bi Shih , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH] ASoC: snd-soc-dummy: add Device Tree support Message-ID: <20210622162307.GF4574@sirena.org.uk> References: <20210621074152.306362-1-judyhsiao@chromium.org> <20210621114546.GD4094@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: fortune: not found User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210622_092331_106921_68D4B3E7 X-CRM114-Status: GOOD ( 19.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8628521650197828871==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8628521650197828871== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Y/WcH0a6A93yCHGr" Content-Disposition: inline --Y/WcH0a6A93yCHGr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 23, 2021 at 12:10:53AM +0800, Judy Hsiao wrote: > Thanks for your review comment. > This patch is used to support multi-channel where we want one codec to > control the only GPIO shared by 4 amps. So you've got 4 instances of the same CODEC? Then I'd expect to see those all individually represented in DT. Or if there's a single physical CODEC then I'm not sure what the dummies are for? > In snd_soc_runtime_calc_hw(), by creating dummy codecs that share a > DAI link with a real codec: > 1. The min/ max channel of CPU DAI will be directly adopted. > 2. The formats and sample rates of the DAI link will be determined > by the real codec unless the real codec supports the rate > and format that do not intersect with the rate and format of > snd-soc-dummy. > That is the reason why we don=E2=80=99t specify the format and sample rat= es of > the dummy codec with the real codec determining the properties . It's not clear to me why you'd not just describe the actual CODECs here rather than using a dummy CODEC, the fact that the dummy CODEC is doing what you want is just an accident of the implementation rather than a description of the hardware. --Y/WcH0a6A93yCHGr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDSDmoACgkQJNaLcl1U h9CHhgf9GyO7DmKsckUqnMgiWbG3VYozrFo/OBZbuZQ9BpW1Z1HA8NODEpIGZnJu IFCzwNcBW9kli0vU6+PDVxxhMtuGuj3/+Y2IabUlr/f0Mq6s+rgKJAjPmyqb8MI8 7RkBXF9O0esDEhYBV5w0sMhAp/galLTCgUjPevMdSmfCuiMZHLpKnHW1cW+FgK0m 8gGcALicOwyv2nYo42vozX8jt3ujOrccNTHP0mlPuqj2ceW8IAF/yQDqkb9C7kqL K4aUK/VJ5mcx4z0Aj2PQyFoHn1ITfSOOo4ROsOT89HdupM1TeuCv6pms0KIfHGYG exburGtpvtRoijicCRPkG7E03VLbZg== =UqxB -----END PGP SIGNATURE----- --Y/WcH0a6A93yCHGr-- --===============8628521650197828871== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8628521650197828871==--