From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C203C4743C for ; Wed, 23 Jun 2021 13:55:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53EFC61076 for ; Wed, 23 Jun 2021 13:55:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53EFC61076 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6TZVBYuHLaZSszsVm2x1xZxKQFnxeES8VTvkbmTYfwM=; b=Pld/lzZywtrlYE gvH+EXchfHvGMCPgE9KZzFuWkLOYKXcYOniIEuQGUBao9ArHpQF6q6h7G/e9+t6N5fKWnpRbjiHwz SJrUIDlI2rRmuWn/iOEBQZmi2S1ud3AqlPofmakT+nB+5l5pyrSbOTVbxV/Zr2a0ArbkPxzo4mrc8 ULuaTt3pEC9t24EE767wXtcd1Ju5iFAHMjpRpGnESNnFRWkR+hd8GMDX8MRmyukXaLVQsSWLrCaoG QZdukVeYNvy42iknQO5R7U9y6QaWbOKijnnHpj1eCQuoS6p0qwvs0a1cp4HTNyAoR38BMwzfyEYcZ 0OZOF18ISYf7ZDijgoLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw3K4-00AsEJ-LE; Wed, 23 Jun 2021 13:53:44 +0000 Received: from mail-ej1-f54.google.com ([209.85.218.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw3Jq-00As7q-9L for linux-arm-kernel@lists.infradead.org; Wed, 23 Jun 2021 13:53:31 +0000 Received: by mail-ej1-f54.google.com with SMTP id nb6so4139295ejc.10 for ; Wed, 23 Jun 2021 06:53:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xJccocnoRdorcslUAq9kb6AGcZBt5E/D2oTNxvA/DUE=; b=nyY5M2Oc0jNntxIJ9TaBHcjJBhnB7shUY2Ud0EZqSQy03CJh4T7rWvAzhpGN9SMLon fmhEdRuBODMd4q96yVzTEC5P4Hvd4KFS40lf9OJq/GJZv2Vxbh6W/zBfj0+goqi35i8q q39w5r2TbIpmGD7g1VeW0toRGUlh6P+O6IXuffec9C6ap5JmUROrICPWECfiNuNA4LMX dk+vgKoMACJrVrbadXiBCf2nFJwFEqnKXMjDZhln5StnbSdmOJ2YQtET0784ML2ZAIUI H8PSQF0b2ikCkx0+8SCgsDBa/YUd5fse2dHCHDn+vHEVx5PmNO+HK7KrW9rZ5oRrNOYC ri+g== X-Gm-Message-State: AOAM531kl6QGFpmNzkn5IMXLqldSWm4ZsabbdUbWoAz+ETUgaVAjc5Ga tDrDRrlA348WvXR+t8R5HK0= X-Google-Smtp-Source: ABdhPJx4MiPBQ7sojERe3xK7MmHDIA3eZ06CVhmxc0qfIKDm5CajmkayvlQvbc/hC7PnBccVzO+z/g== X-Received: by 2002:a17:906:ce29:: with SMTP id sd9mr168698ejb.56.1624456408751; Wed, 23 Jun 2021 06:53:28 -0700 (PDT) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id da28sm77961edb.0.2021.06.23.06.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 06:53:28 -0700 (PDT) Date: Wed, 23 Jun 2021 15:53:26 +0200 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, bharat.kumar.gogada@xilinx.com, Hyun Kwon , Bjorn Helgaas , Lorenzo Pieralisi , Marc Zyngier , Ravi Kiran Gummaluri , Rob Herring , Sasha Levin , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v2 2/2] PCI: xilinx-nwl: Enable the clock through CCF Message-ID: <20210623135326.GA54420@rocinante> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210623_065330_406426_1C4E107E X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+cc Sasha for visibility] Hi Michal, Thank you for sending v2 so promptly! And for all the extra changes and fixes. Much appreciated! > Enable PCIE reference clock. There is no remove function that's why > this should be enough for simple operation. > Normally this clock is enabled by default by firmware but there are > usecases where this clock should be enabled by driver itself. > It is also good that clock user is recorded in clock framework. Small nitpicks: it would be PCIe here in the above and in the error message (this is as per [1]), and "use cases" also in the above. This can be corrected when the patch will be merged by either Bjorn or Lorenzo, to avoid sending v3 unnecessarily, provided that they would have a moment to do it, of course. > Fixes: ab597d35ef11 ("PCI: xilinx-nwl: Add support for Xilinx NWL PCIe Host Controller") Thank you! Does it make sense for this change to be back-ported to stable and long-term kernels? I am asking to make sure we do the right thing here, as I can imagine that older kernels (primarily because some folks could use, for example, Ubuntu LTS releases for development) might often be used by people who work with the Xilinx FPGAs and such. [...] > + err = clk_prepare_enable(pcie->clk); > + if (err) { > + dev_err(dev, "can't enable pcie ref clock\n"); > + return err; > + } > + As per the nitpick above, it would be "PCIe", but probably no need to send v3 to correct this. 1. https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com/ Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel