From: kernel test robot <lkp@intel.com>
To: Shravya Kumbham <shravya.kumbham@xilinx.com>
Cc: kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org,
Michal Simek <monstr@monstr.eu>,
Harini Katakam <harini.katakam@xilinx.com>
Subject: [RFC PATCH xlnx] net: xilinx: axienet_ethtools_sset_count() can be static
Date: Thu, 24 Jun 2021 03:44:44 +0800 [thread overview]
Message-ID: <20210623194444.GA4299@cf1f8110e8b5> (raw)
In-Reply-To: <202106240342.Jjf8jp8a-lkp@intel.com>
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2650:5: warning: symbol 'axienet_ethtools_sset_count' was not declared. Should it be static?
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2673:6: warning: symbol 'axienet_ethtools_get_stats' was not declared. Should it be static?
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2700:6: warning: symbol 'axienet_ethtools_strings' was not declared. Should it be static?
Fixes: 0605a36e0574 ("net: xilinx: Ethtool statistics support")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
xilinx_axienet_main.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 3911718d5618b..e56ccdb41867d 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -2647,7 +2647,7 @@ static int axienet_ethtools_get_ts_info(struct net_device *ndev,
* Return: number of strings, on success, Non-zero error value on
* failure.
*/
-int axienet_ethtools_sset_count(struct net_device *ndev, int sset)
+static int axienet_ethtools_sset_count(struct net_device *ndev, int sset)
{
switch (sset) {
case ETH_SS_STATS:
@@ -2670,9 +2670,9 @@ int axienet_ethtools_sset_count(struct net_device *ndev, int sset)
*
* Return: None.
*/
-void axienet_ethtools_get_stats(struct net_device *ndev,
- struct ethtool_stats *stats,
- u64 *data)
+static void axienet_ethtools_get_stats(struct net_device *ndev,
+ struct ethtool_stats *stats,
+ u64 *data)
{
unsigned int i = 0;
@@ -2697,7 +2697,7 @@ void axienet_ethtools_get_stats(struct net_device *ndev,
*
* Return: None.
*/
-void axienet_ethtools_strings(struct net_device *ndev, u32 sset, u8 *data)
+static void axienet_ethtools_strings(struct net_device *ndev, u32 sset, u8 *data)
{
int i;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-06-23 19:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 19:44 [xlnx:master 368/525] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2650:5: sparse: sparse: symbol 'axienet_ethtools_sset_count' was not declared. Should it be static? kernel test robot
2021-06-23 19:44 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623194444.GA4299@cf1f8110e8b5 \
--to=lkp@intel.com \
--cc=harini.katakam@xilinx.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=monstr@monstr.eu \
--cc=shravya.kumbham@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).