[xlnx:master 368/525] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2650:5: sparse: sparse: symbol 'axienet_ethtools_sset_count' was not declared. Should it be static?

[xlnx:master 368/525] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2650:5: sparse: sparse: symbol 'axienet_ethtools_sset_count' was not declared. Should it be static?

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2615 bytes --]

tree:   https://github.com/Xilinx/linux-xlnx master
head:   163a7d26208a6794f595eeee3d54787df5e903d4
commit: 0605a36e057480f3a83ae401e7ff59739da78e82 [368/525] net: xilinx: Ethtool statistics support
config: x86_64-randconfig-s022-20210623 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/Xilinx/linux-xlnx/commit/0605a36e057480f3a83ae401e7ff59739da78e82
        git remote add xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xlnx master
        git checkout 0605a36e057480f3a83ae401e7ff59739da78e82
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1572:37: sparse: sparse: cast to restricted __be32
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1572:37: sparse: sparse: cast to restricted __be32
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1572:37: sparse: sparse: cast to restricted __be32
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1572:37: sparse: sparse: cast to restricted __be32
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1572:37: sparse: sparse: cast to restricted __be32
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1572:37: sparse: sparse: cast to restricted __be32
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1572:35: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __wsum [usertype] csum @@     got unsigned int @@
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1572:35: sparse:     expected restricted __wsum [usertype] csum
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1572:35: sparse:     got unsigned int
>> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2650:5: sparse: sparse: symbol 'axienet_ethtools_sset_count' was not declared. Should it be static?
>> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2673:6: sparse: sparse: symbol 'axienet_ethtools_get_stats' was not declared. Should it be static?
>> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2700:6: sparse: sparse: symbol 'axienet_ethtools_strings' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54008 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[RFC PATCH xlnx] net: xilinx: axienet_ethtools_sset_count() can be static

[kernel test robot]

drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2650:5: warning: symbol 'axienet_ethtools_sset_count' was not declared. Should it be static?
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2673:6: warning: symbol 'axienet_ethtools_get_stats' was not declared. Should it be static?
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2700:6: warning: symbol 'axienet_ethtools_strings' was not declared. Should it be static?

Fixes: 0605a36e0574 ("net: xilinx: Ethtool statistics support")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 xilinx_axienet_main.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 3911718d5618b..e56ccdb41867d 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -2647,7 +2647,7 @@ static int axienet_ethtools_get_ts_info(struct net_device *ndev,
  * Return: number of strings, on success, Non-zero error value on
  *	   failure.
  */
-int axienet_ethtools_sset_count(struct net_device *ndev, int sset)
+static int axienet_ethtools_sset_count(struct net_device *ndev, int sset)
 {
 	switch (sset) {
 	case ETH_SS_STATS:
@@ -2670,9 +2670,9 @@ int axienet_ethtools_sset_count(struct net_device *ndev, int sset)
  *
  * Return: None.
  */
-void axienet_ethtools_get_stats(struct net_device *ndev,
-				struct ethtool_stats *stats,
-				u64 *data)
+static void axienet_ethtools_get_stats(struct net_device *ndev,
+				       struct ethtool_stats *stats,
+				       u64 *data)
 {
 	unsigned int i = 0;
 
@@ -2697,7 +2697,7 @@ void axienet_ethtools_get_stats(struct net_device *ndev,
  *
  * Return: None.
  */
-void axienet_ethtools_strings(struct net_device *ndev, u32 sset, u8 *data)
+static void axienet_ethtools_strings(struct net_device *ndev, u32 sset, u8 *data)
 {
 	int i;
 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel