From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB8D5C48BDF for ; Thu, 24 Jun 2021 07:31:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E56A6100A for ; Thu, 24 Jun 2021 07:31:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E56A6100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CZnhTML2/TH+13JOrg7IDOaTfuBEr2CaeX7NVOyqR40=; b=OYFLyEWWVAkYLN cV3U3UH8L1xqOqt7lMrt1tbhn/NURxaHCT5ZORwipeGcu41BsvgLZymeTiWuHy8R74SUm2k8Sc0y3 R/VZTarKEBY+SJu8i/O1KgFvvtfzgCHm8hTybdXNF8vZD+lfZ7e1Ag95DsRE2TV+4ozB/mF937Nff la4vPlc7oW+jzPeOye4hIYE1B85oOp1nIy05phLrRiIsI4XCVm3PN9dXNqWV1I6b0KhjoGRaYV8qj g5AIosExbi7glDMleghJpnIBnp/f64mndm5veSTXGvuBTX/qhLjRFYTx8qe+OcQjy1PvLi2stjsXl tVCXJv7I3xik/0gTfTEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwJnH-00DBly-WA; Thu, 24 Jun 2021 07:29:00 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwJnD-00DBkt-Ah for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 07:28:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=G1JEYhqSFm1y2jZMFU+nvmNL2Z9dp8rh+B2bQpR6PGs=; b=TwQAIQDP5X5MeSdELo3dCno+l GWR6CZDtYBvm3Z0tZr35Uk1Snw1t7656q1c6wGjuE14zHCsVCbBf5GQ+bU5QPBTZdM8vV/LMZQ61b VaBr/0GWgw+VH9n1HWb2ECmuJnSD/naSePsiGf6HVCP3xtuUjJ0iMZH6KeHWLetmKj16mLhm0PED/ MSUhqYvNntfh6wBQ1gkj7/GufgMz+y2GmH1m2E/OpJZMSpkn4hmlblvQTAsugwLuXdYOI+3YkzFPE 1e6BHE2ZBLsGhdjgvTzu1XXLgMhroHuJeUHwsZFp42tG+0oiaREwjqXDeiSmXYlwV+J7hiYkE2RM2 lM/jWuGvg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45296) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwJn1-0007JR-4G; Thu, 24 Jun 2021 08:28:43 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lwJmw-0005WS-P9; Thu, 24 Jun 2021 08:28:38 +0100 Date: Thu, 24 Jun 2021 08:28:38 +0100 From: Russell King - ARM Linux admin To: 13145886936@163.com Cc: tony@atomide.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, gushengxian Subject: Re: [PATCH] ARM: omap2: remove unneeded variable: "errata" Message-ID: <20210624072838.GA1343@shell.armlinux.org.uk> References: <20210624032751.24315-1-13145886936@163.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210624032751.24315-1-13145886936@163.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_002855_411563_BE356EDC X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 23, 2021 at 08:27:51PM -0700, 13145886936@163.com wrote: > From: gushengxian > > Remove unneeded variable: "errata". > > Signed-off-by: gushengxian NAK. > diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c > index dfc9b21ff19b..ba4a48e3d264 100644 > --- a/arch/arm/mach-omap2/dma.c > +++ b/arch/arm/mach-omap2/dma.c > @@ -79,7 +79,6 @@ static const struct omap_dma_reg reg_map[] = { > > static unsigned configure_dma_errata(void) > { > - unsigned errata = 0; > > /* > * Errata applicable for OMAP2430ES1.0 and all omap2420 > @@ -158,7 +157,7 @@ static unsigned configure_dma_errata(void) > if (cpu_is_omap34xx() && (omap_type() != OMAP2_DEVICE_TYPE_GP)) > SET_DMA_ERRATA(DMA_ROMCODE_BUG); > > - return errata; > + return 0; It is _not_ "unneeded" and you clearly have not compiled the resulting code from your patch. #define SET_DMA_ERRATA(id) (errata |= (id)) errata is used inside the SET_DMA_ERRATA() macro. Hence, building mach-omap2/dma.c would have failed. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel