From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A67C49EA6 for ; Thu, 24 Jun 2021 08:30:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49317613CE for ; Thu, 24 Jun 2021 08:30:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49317613CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X/QWn/DltaLxfafe2RSeT+hn5fufA+J95F2pnpMI3H0=; b=MlhVutmxNagYzN TZgTWi0Dgx3Tgbta1engCOhbXJv4ELe7DDyVNT6ssJK1kheaGfwkL44lvzPJsSzSxSWUfkgBcAPdc ugSLu8yp5NMxc1o47hRLM4lI28Ne8ep5DzS9iyQeNzyv90CSYHe6RmafYJVYujnS5Xd8yGfZTtor4 2fP6D5sQjrH+g0ReGGeZRZ66/ooWjbx1hSudMbtstFmBeT8emihVwT5M8OjCQQFwUwqLFlsbwzpcj F0OEPh64cE+qdiYMh6xaiNGqV+KcsVZbzJ32aQfcRaXU8/5+AvWANkDw2KqsSymRIOti5Yy8hz9MV pLujUTcd0EfhjIKfr11w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwKjk-00DQQu-Vo; Thu, 24 Jun 2021 08:29:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwKjh-00DQQ4-Cr for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 08:29:22 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BCBD9613FE; Thu, 24 Jun 2021 08:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624523361; bh=n3+DR4PNcPYqodN80wD10aoRGrdopEbb0CZAydTJS6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GhCuIF8SdQXKtGcQFyVKTQQvSkJyQi9K1zNRkqZIHg4UwcQZtgUAAh+edYMVuULI6 bxQ3Sodekl6HeI89qyqMxH9NFYfVnqq2JlDk+iuGJNvL59/zOPP9GWpAlU7PBWbqXm 1bTznd7jv6/ldLkNpoOK5ZPxRkZsc/3nDk6Rm3IfBlk5rXsnBEPgnxxO3okcWVaI+J jPD3vnQp5tqchLbeg+qv/Lx8YPIaamn2OdsuKU4ur/5wrjXf+obTpttl8+bpmTGXrh LBe7erXtMqDhmlmtp1Y0ojqc/jKIN/YTUomM2h6Cq6hwK0bpYQEP6oQuYrh0ctzE5M B2JD/TYmRG1fw== Date: Thu, 24 Jun 2021 09:29:15 +0100 From: Will Deacon To: Zhenyu Ye Cc: Catalin Marinas , aneesh.kumar@linux.ibm.com, Marc Zyngier , steven.price@arm.com, Peter Zijlstra , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Xiexiangyou , liushixin2@huawei.com, huyaqin , zhurui3@huawei.com Subject: Re: [PATCH v1] arm64: tlb: fix the TTL value of tlb_get_level Message-ID: <20210624082914.GA1194@willie-the-truck> References: <20210623110412.GA32177@willie-the-truck> <800c06ad-1491-c5ba-c650-c78384bf50c9@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <800c06ad-1491-c5ba-c650-c78384bf50c9@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_012921_518269_ECC01301 X-CRM114-Status: GOOD ( 18.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 24, 2021 at 09:55:53AM +0800, Zhenyu Ye wrote: > On 2021/6/23 19:04, Will Deacon wrote: > > On Wed, Jun 23, 2021 at 03:05:22PM +0800, Zhenyu Ye wrote: > >> diff --git a/arch/arm64/include/asm/tlb.h b/arch/arm64/include/asm/tlb.h > >> index 61c97d3b58c7..c995d1f4594f 100644 > >> --- a/arch/arm64/include/asm/tlb.h > >> +++ b/arch/arm64/include/asm/tlb.h > >> @@ -28,6 +28,10 @@ static void tlb_flush(struct mmu_gather *tlb); > >> */ > >> static inline int tlb_get_level(struct mmu_gather *tlb) > >> { > >> + /* The TTL field is only valid for the leaf entry. */ > >> + if (tlb->freed_tables) > >> + return 0; > >> + > >> if (tlb->cleared_ptes && !(tlb->cleared_pmds || > >> tlb->cleared_puds || > >> tlb->cleared_p4ds)) > > > > Thanks. I can't see a better way around this, so I'll queue the patch. > > The stage-2 page-table code looks ok afaict, but please can you check it > > too? > > The stage-2 page-table codes seem to be correct to me. Thanks for having a look. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel