From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: 13145886936@163.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
gushengxian <gushengxian@yulong.com>
Subject: Re: [PATCH] ARM: pxa: ssp: remove unnecessary print function dev_err()
Date: Thu, 24 Jun 2021 10:24:26 +0100 [thread overview]
Message-ID: <20210624092426.GQ22278@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210624024139.23879-1-13145886936@163.com>
On Wed, Jun 23, 2021 at 07:41:39PM -0700, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
>
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: gushengxian <gushengxian@yulong.com>
> ---
> arch/arm/plat-pxa/ssp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
> index 563440315acd..96b8765e4f57 100644
> --- a/arch/arm/plat-pxa/ssp.c
> +++ b/arch/arm/plat-pxa/ssp.c
> @@ -147,7 +147,6 @@ static int pxa_ssp_probe(struct platform_device *pdev)
>
> ssp->irq = platform_get_irq(pdev, 0);
> if (ssp->irq < 0) {
> - dev_err(dev, "no IRQ resource defined\n");
> return -ENODEV;
> }
Please also remove the now unnecessary braces around the return block.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-24 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 2:41 [PATCH] ARM: pxa: ssp: remove unnecessary print function dev_err() 13145886936
2021-06-24 9:24 ` Russell King (Oracle) [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-24 9:51 13145886936
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624092426.GQ22278@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=13145886936@163.com \
--cc=gushengxian@yulong.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).