From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F563C49EA6 for ; Thu, 24 Jun 2021 10:10:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D669613F9 for ; Thu, 24 Jun 2021 10:10:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D669613F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mB2o14ol63ndealDThcoM9CP/mkiTx3h30lC1SiZ504=; b=cHh1MH9y8hyUSj g/BTJH9/3I7JlHRnU6f+qoHMjNS2g5mrjqybnh/oDmHDinAthEste8JhGu+J77vAyecMo4kZZXIic 5e66r/Mgu30aXubXtvbgvO18jS4ad9XToZ5EPaEJ8WLxFDP0BXT1rDWFWLsrw5JQpTlYFYCD8nKfU h6a9J4OFmdfH+P15NzrPOT6cF5LyTN43JM34n307ULQHKXQHXRU+1ViYl0qP51Yt6onEgUejOap+f fkmYw4jrc9YSfuEfCX/oLxH3oHsUnCN1UcAUzOKvWvcXkB6gLyGLGk04XZ35WFe+KCbgM9fJYP9Lb OCmGzWIx02Kp4Eb3Qyqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwMHv-00DwQP-4a; Thu, 24 Jun 2021 10:08:47 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwMHb-00DwID-8E for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 10:08:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C6BC71063; Thu, 24 Jun 2021 03:08:23 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2B4923F718; Thu, 24 Jun 2021 03:08:23 -0700 (PDT) Date: Thu, 24 Jun 2021 11:08:16 +0100 From: Cristian Marussi To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 1/2] firmware: arm_scmi: Simplify device probe function on the bus Message-ID: <20210624100816.GA40942@e120937-lin> References: <20210624095059.4010157-1-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210624095059.4010157-1-sudeep.holla@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_030827_412161_58771D8E X-CRM114-Status: GOOD ( 18.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Thu, Jun 24, 2021 at 10:50:58AM +0100, Sudeep Holla wrote: > When the driver core calls the probe callback it already checked that > the devices match, so there is no need to call the match callback again. > = > Suggested-by: Uwe Kleine-K=F6nig > Signed-off-by: Sudeep Holla > --- > drivers/firmware/arm_scmi/bus.c | 5 ----- > 1 file changed, 5 deletions(-) > = > Hi Uwe, > = > Just remembered the similarity in SCMI when you posted similar patches > for Arm FF-A. Thought I will push this out before I forget. I have put > suggested and reported by you as I don't have upstream commit id to refer > yet. Hope that is fine. > = > Regards, > Sudeep > = > diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/= bus.c > index 784cf0027da3..dc113ad37ad9 100644 > --- a/drivers/firmware/arm_scmi/bus.c > +++ b/drivers/firmware/arm_scmi/bus.c > @@ -104,11 +104,6 @@ static int scmi_dev_probe(struct device *dev) > { > struct scmi_driver *scmi_drv =3D to_scmi_driver(dev->driver); > struct scmi_device *scmi_dev =3D to_scmi_dev(dev); > - const struct scmi_device_id *id; > - > - id =3D scmi_dev_match_id(scmi_dev, scmi_drv); > - if (!id) > - return -ENODEV; > = > if (!scmi_dev->handle) > return -EPROBE_DEFER; Reviewed-by: Cristian Marussi Tested-by: Cristian Marussi Thanks, Cristian > -- = > 2.25.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel