From: Cristian Marussi <cristian.marussi@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 2/2] firmware: arm_scmi: Ensure drivers provide a probe function
Date: Thu, 24 Jun 2021 11:08:50 +0100 [thread overview]
Message-ID: <20210624100850.GB40942@e120937-lin> (raw)
In-Reply-To: <20210624095059.4010157-2-sudeep.holla@arm.com>
Hi,
On Thu, Jun 24, 2021 at 10:50:59AM +0100, Sudeep Holla wrote:
> The bus probe callback calls the driver callback without further
> checking. Better be safe than sorry and refuse registration of a driver
> without a probe function to prevent a NULL pointer exception.
>
> Fixes: 933c504424a2 ("firmware: arm_scmi: add scmi protocol bus to enumerate protocol devices")
> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/firmware/arm_scmi/bus.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c
> index dc113ad37ad9..6c7e24935eca 100644
> --- a/drivers/firmware/arm_scmi/bus.c
> +++ b/drivers/firmware/arm_scmi/bus.c
> @@ -134,6 +134,9 @@ int scmi_driver_register(struct scmi_driver *driver, struct module *owner,
> {
> int retval;
>
> + if (!driver->probe)
> + return -EINVAL;
> +
> retval = scmi_protocol_device_request(driver->id_table);
> if (retval)
> return retval;
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Tested-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-24 10:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 9:50 [PATCH 1/2] firmware: arm_scmi: Simplify device probe function on the bus Sudeep Holla
2021-06-24 9:50 ` [PATCH 2/2] firmware: arm_scmi: Ensure drivers provide a probe function Sudeep Holla
2021-06-24 10:08 ` Cristian Marussi [this message]
2021-06-24 19:54 ` Uwe Kleine-König
2021-06-24 10:08 ` [PATCH 1/2] firmware: arm_scmi: Simplify device probe function on the bus Cristian Marussi
2021-06-24 19:54 ` Uwe Kleine-König
2021-06-25 10:20 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624100850.GB40942@e120937-lin \
--to=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sudeep.holla@arm.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox