From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B770FC48BDF for ; Thu, 24 Jun 2021 09:44:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83972613F7 for ; Thu, 24 Jun 2021 09:44:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83972613F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=RC4Vn2mZmfFMbpT9cXDaJtHWIFiyGXVNOHkv3K8DoT8=; b=do8lDsHbvlPMX0 5KcSnmcr0NB8Zw65U93I678Qm3BUTxZVZPAh7tG1EgrcyBpHH03PQ1qd8G9Jst54f2SuQkgQYk6f9 11+Jqr5718o3HPfyqtZf+TpgwF0SfEz8fmNNEzSFUgPjwPkJn2rJff9MwZ270ssh+lQ2cdMVhVpxd vyVJt0pV16AvEsHFGhiDKG4U9mcxSCgbJfIoJwpzh8Dxx/S+gcr1edhC+dhQXjidXBWZSYJBgAW1+ f6F08ArJNOFBuIniiRwBkZYQZTYw/+vPf5DR6Xah8zcNi/mppv+6F8VUQsMuBx/z838RlJlTpksB8 4lUoIM6XuIxWA9FtisCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwLsG-00Dlzm-QP; Thu, 24 Jun 2021 09:42:17 +0000 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwLsB-00Dlvo-8k for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 09:42:13 +0000 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15O9WUdX011713; Thu, 24 Jun 2021 09:42:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2020-01-29; bh=ymEh4Gon3CX/f2D9ho1sdSpTmES27suPuVbXpmr21xA=; b=srNk6o9lePa5P9qry1thEGpgU0McNeId8vKK3yGhMbabM8sz1NTWzvGnjYjJ4agkwynN 7KDM40YM1nmWXjcdy9gkfKW7ndNXTKFa90C88wVF3CdgNZu0K5avD6o4sHqUVkwWflfP u9MxldKrTyFUMqjO9+pq2BcB2rsuRcQ6MwzagWfRX3KYpU6LdCheTyv7ZSmuVKK7aSCI DhWojxVgzd5Su9DxfyC53u62whK9Rj/sg5srRG7v6U9gks37Na6qZ9W1BJKIMqz7fiK6 Xf9ylmNw8Wz8zZK9ZbIkRmxB4XhHRa7LWOiH55jMb9PPdeKmrFCBGUcNS5SS3d5UMbdJ Pg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 39cmpxgeck-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jun 2021 09:42:06 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 15O9fj9b083966; Thu, 24 Jun 2021 09:42:05 GMT Received: from pps.reinject (localhost [127.0.0.1]) by aserp3030.oracle.com with ESMTP id 3996mgb62f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jun 2021 09:42:05 +0000 Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 15O9g5fp084878; Thu, 24 Jun 2021 09:42:05 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 3996mgb61k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jun 2021 09:42:04 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 15O9fxRK016682; Thu, 24 Jun 2021 09:41:59 GMT Received: from kadam (/102.222.70.252) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 24 Jun 2021 02:41:58 -0700 Date: Thu, 24 Jun 2021 12:41:51 +0300 From: Dan Carpenter To: kbuild@lists.01.org, Quanyang Wang Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org, Michal Simek , Amit Kumar Mahapatra Subject: [xlnx:xlnx_rebase_v5.10 65/1749] drivers/spi/spi-zynqmp-gqspi.c:1087 zynqmp_qspi_exec_op() warn: inconsistent returns '&xqspi->op_lock'. Message-ID: <202106241608.PjGpyOVM-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-ORIG-GUID: 8o9HM75o22EDPKFDmGFrNPuIA6Xt608E X-Proofpoint-GUID: 8o9HM75o22EDPKFDmGFrNPuIA6Xt608E X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_024211_460460_39C715AE X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.10 head: c830a552a6c34931352afd41415a2e02cca3310d commit: bc753db9c74d949b33bbb8b08a9b6340b57a444f [65/1749] spi: spi-zynqmp-gqspi: add mutex locking for exec_op config: x86_64-randconfig-m001-20210622 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/spi/spi-zynqmp-gqspi.c:1087 zynqmp_qspi_exec_op() warn: inconsistent returns '&xqspi->op_lock'. vim +1087 drivers/spi/spi-zynqmp-gqspi.c 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 946 static int zynqmp_qspi_exec_op(struct spi_mem *mem, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 947 const struct spi_mem_op *op) 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 948 { 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 949 struct zynqmp_qspi *xqspi = spi_controller_get_devdata 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 950 (mem->spi->master); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 951 int err = 0, i; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 952 u8 *tmpbuf; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 953 u32 genfifoentry = 0; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 954 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 955 dev_dbg(xqspi->dev, "cmd:%#x mode:%d.%d.%d.%d\n", 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 956 op->cmd.opcode, op->cmd.buswidth, op->addr.buswidth, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 957 op->dummy.buswidth, op->data.buswidth); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 958 bc753db9c74d94 Quanyang Wang 2020-11-19 959 mutex_lock(&xqspi->op_lock); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 960 zynqmp_qspi_config_op(xqspi, mem->spi); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 961 zynqmp_qspi_chipselect(mem->spi, false); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 962 genfifoentry |= xqspi->genfifocs; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 963 genfifoentry |= xqspi->genfifobus; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 964 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 965 if (op->cmd.opcode) { 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 966 tmpbuf = kzalloc(op->cmd.nbytes, GFP_KERNEL | GFP_DMA); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 967 if (!tmpbuf) 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 968 return -ENOMEM; goto return_err; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 969 tmpbuf[0] = op->cmd.opcode; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 970 reinit_completion(&xqspi->data_completion); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 971 xqspi->txbuf = tmpbuf; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 972 xqspi->rxbuf = NULL; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 973 xqspi->bytes_to_transfer = op->cmd.nbytes; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 974 xqspi->bytes_to_receive = 0; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 975 zynqmp_qspi_write_op(xqspi, op->cmd.buswidth, genfifoentry); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 976 zynqmp_gqspi_write(xqspi, GQSPI_CONFIG_OFST, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 977 zynqmp_gqspi_read(xqspi, GQSPI_CONFIG_OFST) | 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 978 GQSPI_CFG_START_GEN_FIFO_MASK); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 979 zynqmp_gqspi_write(xqspi, GQSPI_IER_OFST, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 980 GQSPI_IER_GENFIFOEMPTY_MASK | 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 981 GQSPI_IER_TXNOT_FULL_MASK); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 982 if (!wait_for_completion_interruptible_timeout 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 983 (&xqspi->data_completion, msecs_to_jiffies(1000))) { 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 984 err = -ETIMEDOUT; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 985 kfree(tmpbuf); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 986 goto return_err; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 987 } 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 988 kfree(tmpbuf); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 989 } 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 990 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 991 if (op->addr.nbytes) { 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 992 for (i = 0; i < op->addr.nbytes; i++) { 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 993 *(((u8 *)xqspi->txbuf) + i) = op->addr.val >> 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 994 (8 * (op->addr.nbytes - i - 1)); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 995 } 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 996 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 997 reinit_completion(&xqspi->data_completion); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 998 xqspi->rxbuf = NULL; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 999 xqspi->bytes_to_transfer = op->addr.nbytes; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1000 xqspi->bytes_to_receive = 0; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1001 zynqmp_qspi_write_op(xqspi, op->addr.buswidth, genfifoentry); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1002 zynqmp_gqspi_write(xqspi, GQSPI_CONFIG_OFST, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1003 zynqmp_gqspi_read(xqspi, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1004 GQSPI_CONFIG_OFST) | 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1005 GQSPI_CFG_START_GEN_FIFO_MASK); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1006 zynqmp_gqspi_write(xqspi, GQSPI_IER_OFST, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1007 GQSPI_IER_TXEMPTY_MASK | 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1008 GQSPI_IER_GENFIFOEMPTY_MASK | 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1009 GQSPI_IER_TXNOT_FULL_MASK); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1010 if (!wait_for_completion_interruptible_timeout 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1011 (&xqspi->data_completion, msecs_to_jiffies(1000))) { 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1012 err = -ETIMEDOUT; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1013 goto return_err; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1014 } 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1015 } 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1016 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1017 if (op->dummy.nbytes) { 5e19e3ddfa5d4b Quanyang Wang 2020-11-16 1018 xqspi->txbuf = NULL; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1019 xqspi->rxbuf = NULL; 5e19e3ddfa5d4b Quanyang Wang 2020-11-16 1020 /* 5e19e3ddfa5d4b Quanyang Wang 2020-11-16 1021 * xqspi->bytes_to_transfer here represents the dummy circles 5e19e3ddfa5d4b Quanyang Wang 2020-11-16 1022 * per data line. 5e19e3ddfa5d4b Quanyang Wang 2020-11-16 1023 */ 5e19e3ddfa5d4b Quanyang Wang 2020-11-16 1024 xqspi->bytes_to_transfer = op->dummy.nbytes * 8 / op->dummy.buswidth; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1025 xqspi->bytes_to_receive = 0; 5e19e3ddfa5d4b Quanyang Wang 2020-11-16 1026 /* 5e19e3ddfa5d4b Quanyang Wang 2020-11-16 1027 * Using op->data.buswidth instead of op->dummy.buswidth since 5e19e3ddfa5d4b Quanyang Wang 2020-11-16 1028 * the specification requires that the dummy.buswidth should 5e19e3ddfa5d4b Quanyang Wang 2020-11-16 1029 * be the same as data.buswidth. 5e19e3ddfa5d4b Quanyang Wang 2020-11-16 1030 */ 5e19e3ddfa5d4b Quanyang Wang 2020-11-16 1031 zynqmp_qspi_write_op(xqspi, op->data.buswidth, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1032 genfifoentry); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1033 zynqmp_gqspi_write(xqspi, GQSPI_CONFIG_OFST, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1034 zynqmp_gqspi_read(xqspi, GQSPI_CONFIG_OFST) | 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1035 GQSPI_CFG_START_GEN_FIFO_MASK); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1036 } 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1037 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1038 if (op->data.nbytes) { 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1039 reinit_completion(&xqspi->data_completion); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1040 if (op->data.dir == SPI_MEM_DATA_OUT) { 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1041 xqspi->txbuf = (u8 *)op->data.buf.out; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1042 xqspi->rxbuf = NULL; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1043 xqspi->bytes_to_transfer = op->data.nbytes; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1044 xqspi->bytes_to_receive = 0; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1045 zynqmp_qspi_write_op(xqspi, op->data.buswidth, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1046 genfifoentry); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1047 zynqmp_gqspi_write(xqspi, GQSPI_CONFIG_OFST, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1048 zynqmp_gqspi_read 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1049 (xqspi, GQSPI_CONFIG_OFST) | 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1050 GQSPI_CFG_START_GEN_FIFO_MASK); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1051 zynqmp_gqspi_write(xqspi, GQSPI_IER_OFST, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1052 GQSPI_IER_TXEMPTY_MASK | 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1053 GQSPI_IER_GENFIFOEMPTY_MASK | 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1054 GQSPI_IER_TXNOT_FULL_MASK); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1055 } else { 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1056 xqspi->txbuf = NULL; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1057 xqspi->rxbuf = (u8 *)op->data.buf.in; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1058 xqspi->bytes_to_receive = op->data.nbytes; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1059 xqspi->bytes_to_transfer = 0; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1060 zynqmp_qspi_read_op(xqspi, op->data.buswidth, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1061 genfifoentry); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1062 zynqmp_gqspi_write(xqspi, GQSPI_CONFIG_OFST, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1063 zynqmp_gqspi_read 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1064 (xqspi, GQSPI_CONFIG_OFST) | 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1065 GQSPI_CFG_START_GEN_FIFO_MASK); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1066 if (xqspi->mode == GQSPI_MODE_DMA) { 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1067 zynqmp_gqspi_write 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1068 (xqspi, GQSPI_QSPIDMA_DST_I_EN_OFST, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1069 GQSPI_QSPIDMA_DST_I_EN_DONE_MASK); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1070 } else { 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1071 zynqmp_gqspi_write(xqspi, GQSPI_IER_OFST, 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1072 GQSPI_IER_GENFIFOEMPTY_MASK | 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1073 GQSPI_IER_RXNEMPTY_MASK | 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1074 GQSPI_IER_RXEMPTY_MASK); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1075 } 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1076 } 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1077 if (!wait_for_completion_interruptible_timeout 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1078 (&xqspi->data_completion, msecs_to_jiffies(1000))) 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1079 err = -ETIMEDOUT; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1080 } 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1081 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1082 return_err: 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1083 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1084 zynqmp_qspi_chipselect(mem->spi, true); bc753db9c74d94 Quanyang Wang 2020-11-19 1085 mutex_unlock(&xqspi->op_lock); 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1086 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 @1087 return err; 1c26372e5aa9e5 Amit Kumar Mahapatra 2020-09-24 1088 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel