From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72021C49EA5 for ; Thu, 24 Jun 2021 20:44:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 360C960FD9 for ; Thu, 24 Jun 2021 20:44:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 360C960FD9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YmVQPndH6oeBBmwHxRpnXLSoKq3jvRiRaFH/0/IO6dg=; b=zBc6l+1q8adkLu KVlSbdK8SzolarAoL/69BHvRfa94TbjjcZHSR58bCcsCUog0RVnI9oKDGfHsGWaGpTKgiptulDtr8 EnBzG07Ag2WghbX9Xa9fDrX8RhfYE8qJ+G6Ox9cGPKgmf20tHmthhMUNOsxsQgjyDUFNuQl1tNCME BGyX3nCVEU/GlAuvdCaNG4L19eBKTbLFcjEPB8JAzCQGiiBPekrYlGNnrC3P768KGunadfDbsOrx0 v0OU+RH9YBLucm/KVxAgWkmvUF4YJbsgmyIbUhK7THYqrXeDqK9TqwBTo29SzEvGHd3PxISk0Pn8C LfDQHjfuF79B8WCROvgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwWCH-00GFIp-M3; Thu, 24 Jun 2021 20:43:37 +0000 Received: from mail-io1-f52.google.com ([209.85.166.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwWCD-00GFI4-TT for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 20:43:35 +0000 Received: by mail-io1-f52.google.com with SMTP id i189so9934136ioa.8 for ; Thu, 24 Jun 2021 13:43:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=kT7rK5sc+dKix955eFVx5gPXvat2NwiKhdWbIUjTAuM=; b=TEvTr1IL8sSETrX7O7QyRqdAvSbsqhaRku/Z0ZLKAwxOqihRFyc/EsdYFQSFL2/CNq gtPqQBnP/18TrOSqb/BApZoS23gbCOFX3fenF8R1mw7J8u5RTo813BwwF/TEy8DGV691 ro5murIEQ5B1M4jKmeYoqfKbpYKg5J9TD6yjY0S4ClCA26BQQr67xIjGC8g5/hs2QF+U t4idg8KzRfG/1UULNIeZDyhV4jc1wC4+xLzYeye6KIQYBesKjLSzJc3/2ad5ArqPDYmQ VIS+O0xGqYFwSR8S7gCowboqaCDCJQ3AzTmOb3IsKeDvgQuvdTlWdF3bpVWzlPzPEIC8 Yo5w== X-Gm-Message-State: AOAM530RVLliAs72m9baR0A09W4CJNth3WsfVeBx9lcK2ralN1Bc088m J4TvfYBZyfNwRTYnyTs+3w== X-Google-Smtp-Source: ABdhPJxE3JC6Ln0Nr0LFkH5NYNUwQkMHm84HO3+NqZ3uBQC2cgcYVYbrRvaK9ruZJaeY1CcqhYqVkw== X-Received: by 2002:a02:3781:: with SMTP id r123mr3243868jar.26.1624567413103; Thu, 24 Jun 2021 13:43:33 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id d2sm683047ioy.33.2021.06.24.13.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 13:43:32 -0700 (PDT) Received: (nullmailer pid 1956153 invoked by uid 1000); Thu, 24 Jun 2021 20:43:27 -0000 Date: Thu, 24 Jun 2021 14:43:27 -0600 From: Rob Herring To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Gregory Clement , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, pali@kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Miquel Raynal , Andrew Lunn , Rob Herring , Sebastian Hesselbarth Subject: Re: [PATCH] pinctrl: armada-37xx: Correct PWM pins definitions Message-ID: <20210624204327.GA1956119@robh.at.kernel.org> References: <20210614222527.11237-1-kabel@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210614222527.11237-1-kabel@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_134333_999140_62CB5494 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 15 Jun 2021 00:25:27 +0200, Marek Beh=FAn wrote: > The PWM pins on North Bridge on Armada 37xx can be configured into PWM > or GPIO functions. When in PWM function, each pin can also be configured > to drive low on 0 and tri-state on 1 (LED mode). > = > The current definitions handle this by declaring two pin groups for each > pin: > - group "pwmN" with functions "pwm" and "gpio" > - group "ledN_od" ("od" for open drain) with functions "led" and "gpio" > = > This is semantically incorrect. The correct definition for each pin > should be one group with three functions: "pwm", "led" and "gpio". > = > Change the "pwmN" groups to support "led" function. > = > Remove "ledN_od" groups. This cannot break backwards compatibility with > older device trees: no device tree uses it since there is no PWM driver > for this SOC yet. Also "ledN_od" groups are not even documented. > = > Signed-off-by: Marek Beh=FAn > --- > .../pinctrl/marvell,armada-37xx-pinctrl.txt | 8 ++++---- > drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 16 ++++++++-------- > 2 files changed, 12 insertions(+), 12 deletions(-) > = Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel