From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADFE6C49EA5 for ; Thu, 24 Jun 2021 21:30:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EB5E613B7 for ; Thu, 24 Jun 2021 21:30:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EB5E613B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+MYovtX1gA5vjDiim16u9q4N2UKfuzLUAvaBMwwM5kI=; b=PQWKQR+wGdhGSP b3Z85PdLwnzSnGQWu84wLs0oWAyoFhwgHTUQse4PycPfXm2CJHZkJT+3f7Go6E7plEl+XNKq3vBW5 Wgfyi3f9qo6xVxEOuyMJROQq4CBO/LrRZzcy8rb3aDUIO/I7a0NRYmQa0Wxzuhvg/MtizboZbhmkx w3vuSoYAQDN2kfaoAVU31/GaokDSCp1hNBm0G3d8gHxGXzWJqSXEqujgheh4X70vMHm21ITPRe+nF 0I7Ounc/5FKzwMWHCb71MDJVya81lim+RDuUAiYbk1JLQ5MQwPOahrk7R/KSvZXfrmBtpRJh1ezTF H3PrQRFg34UOo9m0ym8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwWuJ-00GNfj-MN; Thu, 24 Jun 2021 21:29:07 +0000 Received: from mail-io1-f47.google.com ([209.85.166.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwWuF-00GNfC-0H for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 21:29:04 +0000 Received: by mail-io1-f47.google.com with SMTP id k16so10022434ios.10 for ; Thu, 24 Jun 2021 14:29:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y+ykEWYcQLjlgpcIIfyX0n0bLIPZS2IJ5iGmNYAn4LQ=; b=NoFpgP1/dSModRC/yh8eWYVODV00+S5hlkHgfgd2dLjRfIbzZigP7DJYein7SrNI/o QrGHOmIjJXUWg77E+hQGGeNUKdDwccUL4eyRTvymsy1p0gEhOrXEg8uYsAqlw732IBrX D8zsc05e6k0S7jM76fuaRO+7+n8UkHrXNQl43nX0Ow3xAmBkLQ90BPl9y30saE2aAJPN MHCkbdLwhs5WiZRU/RReomm9Ug7vD2YW14IigvIwJ4ye9rXALuYegyGw98wGBjJBeK4W vKluCF4Q/dT9s8L86+07VKJgcgiRzN2vlllQXNRvJsQ/mmD8u26AYioaomwTesGBN3eK uyzg== X-Gm-Message-State: AOAM530dimcnEMBPVHU5iEjfiVjv4kEItdou3io2Gp4qWQYW0GvQqyxW QzYhXk9IJEyYSNa7DESb1A== X-Google-Smtp-Source: ABdhPJxhsWo9K1agrJ//pvcpy6h/mSqqSv/FoLKL8s07k45EF5g8iQyCAq+n+lb59bzOfKRkUO748g== X-Received: by 2002:a02:3781:: with SMTP id r123mr3387819jar.26.1624570142442; Thu, 24 Jun 2021 14:29:02 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id q8sm2118264iot.30.2021.06.24.14.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 14:29:01 -0700 (PDT) Received: (nullmailer pid 2017356 invoked by uid 1000); Thu, 24 Jun 2021 21:28:53 -0000 Date: Thu, 24 Jun 2021 15:28:53 -0600 From: Rob Herring To: Jamin Lin Cc: Joel Stanley , Andrew Jeffery , Philipp Zabel , Wolfram Sang , Arnd Bergmann , Jean Delvare , Jarkko Nikula , Geert Uytterhoeven , Krzysztof Kozlowski , Khalil Blaiech , Yicong Yang , =?UTF-8?B?QmVuY2UgQ3PDs2vDoXM=?= , Mike Rapoport , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Linus Walleij , Andy Shevchenko , Ryan Chen , "open list:I2C SUBSYSTEM HOST DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , chiawei_wang@aspeedtech.com, troy_lee@aspeedtech.com, steven_lee@aspeedtech.com Subject: Re: [PATCH 2/3] dt-bindings: i2c-new: Add bindings for AST2600 I2C Message-ID: <20210624212853.GA2013136@robh.at.kernel.org> References: <20210617094424.27123-1-jamin_lin@aspeedtech.com> <20210617094424.27123-3-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210617094424.27123-3-jamin_lin@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_142903_103678_9DAB7AC8 X-CRM114-Status: GOOD ( 22.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 17, 2021 at 05:43:39PM +0800, Jamin Lin wrote: > AST2600 support the new register set of I2C controller > Add bindings document to support the new driver of I2C > > Signed-off-by: Jamin Lin > --- > .../bindings/i2c/aspeed,new-i2c.yaml | 107 ++++++++++++++++++ > 1 file changed, 107 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,new-i2c.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,new-i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,new-i2c.yaml > new file mode 100644 > index 000000000000..2c264596b138 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/aspeed,new-i2c.yaml > @@ -0,0 +1,107 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/aspeed,new-i2c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ASPEED I2C on the AST26XX SoCs Device Tree Bindings > + > +description: | > + ASPEED I2C controller support the new register set since AST26XX > + The i2c-global-regs device is used to enable new register set > + > +maintainers: > + - Ryan Chen > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - aspeed,ast2600-i2c-bus > + - items: > + - enum: > + - aspeed,ast2600-i2c-global This is not an i2c controller and a separate block, so it belongs in its own binding doc. > + - const: syscon > + > + reg: > + minItems: 1 > + maxItems: 2 Drop maxItems. 2 is implied by items length. > + items: > + - description: address offset and range of bus > + - description: address offset and range of bus buffer > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: > + root clock of bus, should reference the APB > + clock in the second cell > + > + resets: > + maxItems: 1 > + > + bus-frequency: > + minimum: 100 > + maximum: 5000000 > + default: 100000 > + description: frequency of the bus clock in Hz defaults to 100 kHz when not > + specified > + > + multi-master: > + type: boolean > + description: > + states that there is another master active on this bus > + > + buff-mode: > + type: boolean > + description: > + buffer mode data transfer > + > + byte-mode: > + type: boolean > + description: > + byte mode tata transfer > + > + smbus-alert: > + type: boolean > + description: > + smbus alert protocol > + > +required: > + - reg > + - compatible > + - clocks > + - resets > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + i2c_gr: i2c-global-regs@0 { > + compatible = "aspeed,ast2600-i2c-global", "syscon"; > + reg = <0x0 0x20>; > + clocks = <&syscon ASPEED_CLK_APB2>; > + resets = <&syscon ASPEED_RESET_I2C>; > + }; > + > + i2c0: i2c-bus@80 { > + compatible = "aspeed,ast2600-i2c-bus"; > + #address-cells = <1>; > + #size-cells = <0>; > + #interrupt-cells = <1>; > + reg = <0x80 0x80>, <0xC00 0x20>; > + clocks = <&syscon ASPEED_CLK_APB2>; > + resets = <&syscon ASPEED_RESET_I2C>; > + interrupts = ; > + bus-frequency = <100000>; > + }; > -- > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel