From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D58C2B9F4 for ; Fri, 25 Jun 2021 16:50:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AFF961949 for ; Fri, 25 Jun 2021 16:50:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AFF961949 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4T6+d4KEFNQUSIlOl8th+1QWnrUra1aH0Ntq1rsLn2g=; b=IGBpZBXTmSt7p6 wm4o9SefobSDXitGtkfIXxLk83ZxgBa8Fumks7umYL09G2BtEKx5+UCpGCe3K1O+pO1MbBYoha4Sm adrsxXMEb9w8/B1zMrGqOUorRwVWp7MK3nq3dQUgzGOou5B10kMUuyHNK7K6YQuS9YZ8c1lPD9QLt NUGwuh/gcBF8dE5laZrv/riilcazBeqE1FzF8xDX/Qndznk0nDsNTfyOH6g8Bf+xy71bMFUNTLS2X nroji9nFODf7jyjziSRfA8r8irT597VGICfZ6rpMxHqHZe9tC/vcLfA4ntLwPt+Uem3ok//bXnPV4 vrPeJtgmgJNJgWxVyiwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwp0r-002MOZ-I9; Fri, 25 Jun 2021 16:49:05 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwp0n-002MO3-MG for linux-arm-kernel@lists.infradead.org; Fri, 25 Jun 2021 16:49:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kwgIfr/lhJ0ryHMTahUJt0vf/j0H30v0H27zweCUKY4=; b=RmM6MYi8CJXQUpD5jBXg6mQqx I6hvx10q1MZOSwQlQgYTsD+Y7zeyGwCQGmlq8VnNQ7eYpdRf61PMb7VF06+h5Zzk1s1eExAcx7F6W 52XOWHkYUlq+/8ACcAwwuSJ4vWwZjd5DY2/kccT8XM3IvOSBCQxXebA95AjQAUnZoJiLHSXb4A/rS 9N1kXxmj/EB4DuwGMRSzl7D1ZR1Yf8+zZPG2+fgDH10cSZ0N/S1xJYLwTJHY3pkm1JsCi18XsJTz1 OGi2pz/aWCYPWyYS5LXNHvh2lmykl+VfwXH2psA3GVWeyU7BAOA05rufDlX/xABQx6qoV1gwfFpu9 062j/bl1A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45354) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwp0R-00010f-V9; Fri, 25 Jun 2021 17:48:40 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lwp0M-0006pT-SI; Fri, 25 Jun 2021 17:48:35 +0100 Date: Fri, 25 Jun 2021 17:48:34 +0100 From: "Russell King (Oracle)" To: "Voon, Weifeng" Cc: Andrew Lunn , "Ling, Pei Lee" , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , "Ong, Boon Leong" , Wong Vee Khee , "Wong, Vee Khee" , "Tan, Tee Min" , "Sit, Michael Wei Hong" , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next V1 3/4] net: stmmac: Reconfigure the PHY WOL settings in stmmac_resume() Message-ID: <20210625164834.GY22278@shell.armlinux.org.uk> References: <20210621094536.387442-1-pei.lee.ling@intel.com> <20210621094536.387442-4-pei.lee.ling@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210625_094901_769207_DCC11288 X-CRM114-Status: GOOD ( 19.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 25, 2021 at 03:58:17PM +0000, Voon, Weifeng wrote: > > > No, the interrupt will not be discarded. If the PHY is in interrupt > > > mode, the interrupt handler will triggers and ISR will clear the WOL > > status bit. > > > The condition here is when the PHY is in polling mode, the PHY driver > > > does not have any other mechanism to clear the WOL interrupt status bit. > > > Hence, we need to go through the PHY set_wol() again. > > > > I would say you have a broken setup. If you are explicitly using the > > interrupt as a wakeup source, you need to be servicing the interrupt. You > > cannot use polled mode. > > Sorry for the confusion. But I would like to clarify the I should use the > term of "WOL event status" rather than "WOL interrupt status". > For interrupt mode, clearing the "WOL interrupt status" register will auto > clear the "WOL event status". > For polling mode, the phy driver can manually clear the "WOL event status" by > setting 1 to "Clear WOL Status" bit. If WOL raises an interrupt signal from the PHY, but the PHY interrupt signal is not wired, how does the wakeup happen? What is the PHY interrupt wired to? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel