From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 408BCC49EA5 for ; Sat, 26 Jun 2021 09:24:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB861614A7 for ; Sat, 26 Jun 2021 09:24:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB861614A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9AA7jD/ayOObFHvbQw+YlCcbnyzKeziyBXKX4+vrbF8=; b=TLBEtcRdbniAC0 Y/kvbfBvSr+pGxH9SttQSIoNEdUWFWcIruNtyqvSN8Q7YSJmq+RzFxEUXzmtNHkiIhd/iEzD9m3Fc +BMizJOwnu+WcFexQp7M7Q0QMWA0/COjm9cMtvVYDQ4X+kpjiXhjag84p6bWwFvVTuDvja9mdDGka am+YTkV24qOQJZayhxZrzblJZrpNSVSv0huCez7jXpw1ApJK/wAdwd2HBeiucGBpOIYkpClzRTNu7 9eY/VR1ya372GZsB0yhItZ1vTZGXd8XQzcgtcPMqRDRPKYd20DR7GAvh3oGdnk+eMMSuDrakUKgli 6ztmpxhByaCxfkOvqfJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lx4X6-003lc4-KL; Sat, 26 Jun 2021 09:23:24 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lx4X2-003lYE-2d for linux-arm-kernel@lists.infradead.org; Sat, 26 Jun 2021 09:23:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5tE7gWvpvwFlyaG2zRUYzBcE9B7dXwCRVgZyQuAA+1k=; b=SyBMxvB2RafWxopZbDER7nZv2 rWwf/m9jrVM9tPSxLy0FYvUr4vtjcrLfs0qsFb69yN2H32RQpMs+7mO6SK0lSIvPQq580fefQ/uG1 uGOK3pkHNAOQWFI5S/qlAJHGtyWnRDbgxF6fsn2bESb5QeU38DX33BIPQO/lHY5ls6GiwmWW3+i3d CH3DHjtheUWiLXhnfAJizpzvGuN1Qo6HKArk+7ioUzpPL5FVmbC1xavbo9U9KpxWMVA0o/FW6aTFM v3L2muixt+zFNcHMnqdk9TfhLmT5RCMf0FzFX7lHnsMGtTRku2pNAY/h0k28ceDdH3Tf+zdy2vwrH RxFK8CvPA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45374) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lx4V1-0001d4-Fq; Sat, 26 Jun 2021 10:21:15 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lx4Uz-0007X1-HF; Sat, 26 Jun 2021 10:21:13 +0100 Date: Sat, 26 Jun 2021 10:21:13 +0100 From: "Russell King (Oracle)" To: Jinchao Wang Cc: guillaume.tucker@collabora.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: mm: Prefer unsigned int to bare use of unsigned Message-ID: <20210626092113.GZ22278@shell.armlinux.org.uk> References: <20210626065833.6653-1-wjc@cdjrlc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210626065833.6653-1-wjc@cdjrlc.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210626_022320_167129_24392002 X-CRM114-Status: UNSURE ( 9.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jun 26, 2021 at 02:58:33PM +0800, Jinchao Wang wrote: > * By default, we write directly to secure registers. Platforms must > * override this if they are running non-secure. > */ > -static void l2c_write_sec(unsigned long val, void __iomem *base, unsigned reg) > +static void l2c_write_sec(unsigned long val, void __iomem *base, unsigned int reg) ... and then I'll get another patch because this now goes over 80 characters. No thanks. There is nothing inherently wrong with "unsigned" - it's always been legal C, and I'd prefer to keep the code as-is under arch/arm in regard of this. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel