From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 981D9C2B9F4 for ; Mon, 28 Jun 2021 10:13:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6272761C68 for ; Mon, 28 Jun 2021 10:13:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6272761C68 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SM4xDFsHMtlQeI6J4Z71drvmGH5pQdOucQbJkLvsNlY=; b=Tp9Lv20IA6trL0nY7MXy1ECnze ha95ai4XzBEUSNZQKX8thdwcts2bLL+fOPRijrXLAmVep7teZCd29G1ufT59/Yh66MTq2v74Vx9Dv q4Yo+sVWMDK80TUDdMt+dGJWTJCyPSHiixJsHG8nlTnJx/sgrG7YhGHiFE9Kp5ok7VO2Yz9hxAJaI peD7ahWyLWjwrUumWoobnkJv0E/oCPcMR7d7lDSMP29/VwrW+/Z4joNn+nvI0VM3F3dHtGAo5QMnn /NVm2zY2Jh81A3Iz3EEAjCzAVhUXbvYgeAyMA4W//Cwy3ur7E1gGmaNbDZ05Po6QD7ryiBgCwDV+V QoB+q7Gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxoEY-007a1n-7h; Mon, 28 Jun 2021 10:11:18 +0000 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxoET-007Zz9-RA; Mon, 28 Jun 2021 10:11:15 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id CA8F92B00873; Mon, 28 Jun 2021 06:11:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 28 Jun 2021 06:11:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=plgjL9DAPOj+IJveFhfJC/nWlW8 yqlKjHxjWHKswgTY=; b=dHpm6JF8XTDHNKuetck3J/8jJbiTaSqNQ7PzuUvBDnu apDZj5dq/mNOEVIeZ99HjOd12zVWNnYTKLdTaR6tq4FpRgxhZwhx+HkK92a2KZlu kPi6jColnmgeDXf7KlqKNGrR0C45z0u35ImhL1bx8LeykjGwm9F4T1Wa76B/N5tv Jjdxc0VZCxEpiPyBsLrc2hxNO9icbGNsPM+udn4WXBuIqFeIbj70HYs+Srzw9bm+ 4U8gSxMAviJkKX2WP2crv5lS/TcAQ15SuB82tjdKoiQZYjL/lElAo/6GW5ZWoOp5 PfUhFIB0x7+uAD7NyhSU9XmnqreJ0YtEarT6Iv4mviA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=plgjL9 DAPOj+IJveFhfJC/nWlW8yqlKjHxjWHKswgTY=; b=HzQbRG9j6qI7UwV0Om93PM f1gD6MaVceY+aoxPGGSzdakrVsYQK3DRdItk8rR6Bm4ntDeb7MVtoaV5kREuI2un xKMyF0FyLhHNpBnzsyg1PwW+pfrIacx/52ZpBL68TB6X7qN4o4bLMF7+01AVKeJ1 eEEO0ZRqgreNJ+7mgtVkBRlUHl60mRG/tG1rt6sIxKxqrYfpdj+8Px3Y4Z0Cx663 JN1nfvPSTUXrlo8oYsxHrDmJshaI/w4mUz29jlF89yGIuIaMk397U+ylgsQKqpBT Lk/oB4vGN7Gr8rxOLnatDGB5VZtCSy3fAldxDMmJ0Qeu13ke2RlpxyqpEePC8vPA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeehgedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepveevfeffudeviedtgeethffhteeuffetfeffvdehvedvheetteehvdelfffg jedvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Jun 2021 06:11:04 -0400 (EDT) Date: Mon, 28 Jun 2021 12:11:02 +0200 From: Maxime Ripard To: Dave Stevenson Cc: Laurent Pinchart , Marek Vasut , Nicolas Saenz Julienne , Eric Anholt , Tim Gover , LKML , DRI Development , Andrzej Hajda , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm/vc4: dsi: Only register our component once a DSI device is attached Message-ID: <20210628101102.nunllcc7rog2nkc4@gilmour> References: <20200707101912.571531-1-maxime@cerno.tech> <20210621160517.5fptdj4tkbzgqn76@gilmour> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210628_031113_967407_A5CB52E2 X-CRM114-Status: GOOD ( 33.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7212877888200409249==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7212877888200409249== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qpwle5uhkiiqkop7" Content-Disposition: inline --qpwle5uhkiiqkop7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Jun 21, 2021 at 05:18:22PM +0100, Dave Stevenson wrote: > Hi Maxime >=20 > On Mon, 21 Jun 2021 at 17:05, Maxime Ripard wrote: > > > > Hi Laurent, > > > > On Sun, Jun 20, 2021 at 04:44:33AM +0300, Laurent Pinchart wrote: > > > Hi Maxime, > > > > > > I'm testing this, and I'm afraid it causes an issue with all the > > > I2C-controlled bridges. I'm focussing on the newly merged ti-sn65dsi83 > > > driver at the moment, but other are affected the same way. > > > > > > With this patch, the DSI component is only added when the DSI device = is > > > attached to the host with mipi_dsi_attach(). In the ti-sn65dsi83 driv= er, > > > this happens in the bridge attach callback, which is called when the > > > bridge is attached by a call to drm_bridge_attach() in vc4_dsi_bind(). > > > This creates a circular dependency, and the DRM/KMS device is never > > > created. > > > > We discussed it on IRC, but it makes more sense here. > > > > The thing is, that patch is fixing a circular dependency we discussed > > with Andrzej a year ago: > > > > https://lore.kernel.org/dri-devel/20200630132711.ezywhvoiuv3swo57@gilmo= ur.lan/ > > > > It seems like we have to choose between having the panels or bridges > > working :/ >=20 > The Pi panel using the panel-raspberrypi-touchscreen driver is flawed > as it controls the power to the FT5406 touchscreen element as well as > the display. If DRM powers down the display, power goes to the > touchscreen too, but the edt-ft5x06 touchscreen driver has no notion > of this :-( >=20 > The two parts have been broken into bridge/tc358762 and > regulator/rpi-panel-attiny-regulator which then allows the edt-ft5x06 > driver to keep control over power. I haven't had it be 100% reliable > though, so I'm still investigating as time allows, but this seems like > the better solution than panel-raspberrypi-touchscreen. >=20 > With the tc358762 node back under the DSI host node, I think that > circular dependency you were trying to solve goes away. > However with sn65dsi83 being I2C configured, is that an issue again? Even though getting rid of the old driver make it less likely and reverting that commit make it less likely, we still have the same fundamental issue. One thing we could do would be to always register the DSI encoder and report the connector as connected if the panel has probed. However, I'm not sure how it helps with a bridge. Bridges over i2c don't seem too far-fetched to consider too. Maxime --qpwle5uhkiiqkop7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYNmgNgAKCRDj7w1vZxhR xbCSAQDhJXOKSKI7tHoYRtt5y+gQnDIL8yc75+P6M808aYJvPAEAynmyr1AOeqFC SLL/qDqyjb4DPXRaAHHgn587rXB5LQo= =oZSV -----END PGP SIGNATURE----- --qpwle5uhkiiqkop7-- --===============7212877888200409249== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7212877888200409249==--