From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48B3CC2B9F4 for ; Mon, 28 Jun 2021 12:49:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EB4A61C43 for ; Mon, 28 Jun 2021 12:49:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EB4A61C43 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L7fZ9dNEHRm79ltksPtpjXOvswSTjNQmDWUl2v6qQPQ=; b=qwMt8ufE/ndo4sTl7knIjfnD3m svrCuj+U4jP03WuqW4UTn5sE6ogWNs0hcFubxKtIDHPYpHv2TEPKEJyXi19QdlaBQQE6P4xRKdhAF nZZ9msPR1NEj55y1BQmuVhV1ctOUd4/MJtZlygtBsiLB1mn7YWJen07kCZ1wtS2CPxQg7MrtZGNTr or5HQb6E5J9MX9P12LDoRW3Bs42/TTa66kIreClVnbfJMmo3SFKoFhYrvRCar7/VHanLUCPobKEbq qdNsLxCD4Tq1cgJgz2WquFdB8J8OgIHesVk3iJdAx9v3IjBzj81l5ODSVm3yKP1VZATSajBDpezm8 MfN1jx6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxqew-0082ji-JO; Mon, 28 Jun 2021 12:46:42 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxqes-0082i5-Cp for linux-arm-kernel@lists.infradead.org; Mon, 28 Jun 2021 12:46:40 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 9569E58073B; Mon, 28 Jun 2021 08:46:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 28 Jun 2021 08:46:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=FGZcwoZwyPYceIqBEn/JL4z0fxH 5zp8oJcvt5w3ABb4=; b=XjUIgotobppm/S2dYlC7NoZCJ/kNNH0oSeeon95yHoB H9MShuY7w68ElblP8T8S1w7sEfRA1EYmMBGLD9ukAEbNEHH6ba24/RfkjfqvUK7t XOvKskUlGp3k1hsJWVZv75Tt/rhYAm/vj2itcFPiLNuxQxTn5EZAzuxW25krnkQU oLmlnh4qwobducCXpO/lpEtO2QE62N0wLGWGeJdo0nAasd5UJJ4gOIgI2nTR3xoh zkC1xOcEiT7rq6mcEgWaIIy0yPpnRQQSDb5SVhnWWKJE+UmS60lBV3xv4p1XNfuk +QqFIMhz4Osbcgi8du6Mt8NQq7k8PcSjQoKMnI8MqqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=FGZcwo ZwyPYceIqBEn/JL4z0fxH5zp8oJcvt5w3ABb4=; b=TH3R+UNmoK5PEOZO0SEp/9 NiyHWqi6Z9WkqJHlk3iZ9Cyatb64kvA42MRX1STlR8cAvlQKHFiBD4grIKs8nGUM KCHQK9IgD0RfvIo85eYwgwJ9EfW2C1rT3Khb+iVOUp+sSILxN2cQYSxxcyHleXzd 6YpI04UCgALJtfoBE4Pk/nkld56HRobKfYY0xrEOWPffHrkzuWbu808Cl6IGo23l OgTtd8+lwfgAEgWnLLv+zY/8UkAJKEPwBhiUdUQFUugLsomXRB7fEL7OI+LRbSoC JaVhxa04zZkRyQE+aTlfEnySfIJGwVD+YJImqofDcG5OeYtpINcbOKCiKGowlpzQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeehgedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesghdtre ertddtvdenucfhrhhomhepofgrgihimhgvucftihhprghrugcuoehmrgigihhmvgestggv rhhnohdrthgvtghhqeenucggtffrrghtthgvrhhnpeffteetveeijeetuefhffegkeetgf fhieelheehtdduudethffhjedtvddtudelvdenucffohhmrghinhepuggvvhhitggvthhr vggvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Jun 2021 08:46:36 -0400 (EDT) Date: Mon, 28 Jun 2021 14:46:34 +0200 From: Maxime Ripard To: fengzheng923@gmail.com Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller Message-ID: <20210628124634.radw3ywstfdl2fqw@gilmour> References: <20210625090721.6183-1-fengzheng923@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210625090721.6183-1-fengzheng923@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210628_054638_549237_7C9189BB X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4610375068365212736==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4610375068365212736== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ersryph7t25vlhha" Content-Disposition: inline --ersryph7t25vlhha Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 25, 2021 at 05:07:21AM -0400, fengzheng923@gmail.com wrote: > From: Ban Tao >=20 > DT binding documentation for this new ASoC driver. >=20 > Signed-off-by: Ban Tao > Reviewed-by: Rob Herring >=20 > --- > v1->v2: > 1.Fix some build errors. > --- > v2->v3: > 1.Fix some build errors. > --- > v3->v4: > 1.None. > --- > .../sound/allwinner,sun50i-h6-dmic.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun= 50i-h6-dmic.yaml >=20 > diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-= dmic.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmi= c.yaml > new file mode 100644 > index 000000000000..d9107685b78d > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.ya= ml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/allwinner,sun50i-h6-dmic.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner H6 DMIC Device Tree Bindings > + > +maintainers: > + - Ban Tao > + > +properties: > + "#sound-dai-cells": > + const: 0 > + > + compatible: > + const: allwinner,sun50i-h6-dmic > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: Bus Clock > + - description: Module Clock > + > + clock-names: > + items: > + - const: bus > + - const: mod > + > + dmas: > + items: > + - description: RX DMA Channel > + > + dma-names: > + items: > + - const: rx > + > + resets: > + maxItems: 1 > + > +required: > + - "#sound-dai-cells" > + - compatible > + - reg > + - clocks > + - clock-names > + - dmas > + - dma-names > + - resets > + > +additionalProperties: false > + > +examples: > + - | > + dmic: dmic@5095000 { > + #sound-dai-cells =3D <0>; > + compatible =3D "allwinner,sun50i-h6-dmic"; > + reg =3D <0x05095000 0x400>; > + clocks =3D <&ccu 101>, <&ccu 100>; > + clock-names =3D "bus", "mod"; > + dmas =3D <&dma 7>; > + dma-names =3D "rx"; > + resets =3D <&ccu 42>; > + }; You can keep the clock and reset indices, it's more readable that way, you just have to add the headers dt-bindings/clock/sun50i-h6-ccu.h and dt-bindings/reset/sun50i-h6-ccu.h like what Documentation/devicetree/bindings/iommu/allwinner,sun50i-h6-iommu.yaml is doing. Also, this controller has an interrupt. Even if the driver doesn't use it it should be in the binding. Maxime --ersryph7t25vlhha Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYNnEqgAKCRDj7w1vZxhR xae2AP4qPv9ltkegaT6Rdk9GGRXJUgBLvDbFtsYo+bDb8jTrGwD/S+Pb9PvRC7ey moBzsqtqHcl2FG/ce2wg5N3rQ9f7EwU= =c0fk -----END PGP SIGNATURE----- --ersryph7t25vlhha-- --===============4610375068365212736== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4610375068365212736==--