From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 855D4C11F64 for ; Thu, 1 Jul 2021 13:03:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46E256140B for ; Thu, 1 Jul 2021 13:03:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46E256140B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eItqZCIhJKKyY6Z2Pj45UW2yR8HfqrvCSLnOjnYmYv4=; b=rC4OdLmXrPGgvU 3lNZqNesLOvuilZgpKXwQsdgbDGYW4+K/iT9Jwx0yhpQSxD+07TsJX2vMHUt0GGIBAiS5oMU+ol5/ GGrXJS4OdoNK3GU1fR3s4ChA+q5yk8robgeNadBhhRKpG+OOV6f9fuO8IkrGIghhvfvTrnFAJFN21 7RyMA8HOl251YKKUxQbiaQOomYFbwJXmTntUsOYq1Tqfbee6Z7e2oTEAeZKRxSihYPrXoXKbtTqJ1 Z56aSmrulArZMTlP0/mnOz7MfMUPZMuLK7LDxSOogau6imPu47oOSOGsbq87Fovvk0WYKX+27L8Oq eF4casnMiq45DUtNi2YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lywKQ-00HMAp-LT; Thu, 01 Jul 2021 13:02:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lywKN-00HM9L-0i for linux-arm-kernel@lists.infradead.org; Thu, 01 Jul 2021 13:02:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id DDAD56140B; Thu, 1 Jul 2021 13:01:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625144515; bh=iHSHG/c7nR83GudWbkb74eh2Q3S1tPDocmMIvzxBwxI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r1fhICH1688wSS5RIgsm/HH8jTIkrAb09EbweFoFHMMOdYK0c1cl2TrqRJMzxJf0A 34gPvJmmuP40y0tyr80fVb/PVALcQvo14bkIgBkYMFY1BpGBeAwG8ug18OwYmweRB2 d3kzdYN51EoXMX6dMwKFdnlTiNuO5PvNMTLZYhzqu3j9RsjPZe7DcA1tpv23Utw73V o+WUPlFHGaJnsQG9m6kwhxeWBEJbJ/uI1VO+dWt0nRoVkAR1SVm31K+Od3ZsC+JUGZ R66XWaCnIdzq82WXf32VT4O3RpYngK1td+OS4I6TijYKgDAnkrxLdUdh7ejBmR490S 0rqcZdipkInQg== Date: Thu, 1 Jul 2021 14:01:49 +0100 From: Will Deacon To: Fuad Tabba Cc: kvmarm@lists.cs.columbia.edu, maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v2 03/13] KVM: arm64: Fix names of config register fields Message-ID: <20210701130149.GC9757@willie-the-truck> References: <20210615133950.693489-1-tabba@google.com> <20210615133950.693489-4-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210615133950.693489-4-tabba@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210701_060159_126684_BEFA1962 X-CRM114-Status: GOOD ( 17.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 15, 2021 at 02:39:40PM +0100, Fuad Tabba wrote: > Change the names of hcr_el2 register fields to match the Arm > Architecture Reference Manual. Easier for cross-referencing and > for grepping. > > Also, change the name of CPTR_EL2_RES1 to CPTR_NVHE_EL2_RES1, > because res1 bits are different for VHE. > > No functional change intended. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/include/asm/kvm_arm.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h > index 25d8a61888e4..bee1ba6773fb 100644 > --- a/arch/arm64/include/asm/kvm_arm.h > +++ b/arch/arm64/include/asm/kvm_arm.h > @@ -31,9 +31,9 @@ > #define HCR_TVM (UL(1) << 26) > #define HCR_TTLB (UL(1) << 25) > #define HCR_TPU (UL(1) << 24) > -#define HCR_TPC (UL(1) << 23) > +#define HCR_TPCP (UL(1) << 23) This one is a bit weird: the field is called TPCP if the CPU supports FEAT_DPB but is called TPC otherwise! So I don't think renaming it like this really makes anything better. Perhaps add a comment: #define HCR_TPC (UL(1) << 23) /* TPCP if FEAT_DPB */ ? Rest of the patch looks good: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel