From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F92C11F69 for ; Thu, 1 Jul 2021 13:49:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 500C8613FB for ; Thu, 1 Jul 2021 13:49:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 500C8613FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TSCjBFLSMnDqAy4ovufTgdAGs+TcG06sYd05Pva6NY8=; b=DePxVUjXQ35EHi rcBZnw7NmO11FW8V9xaUVZJ2U2DFS5CQBSlXparMwRjIgPyyGfgzGankP79zuGsbRdDxO+RevdHHr U4CMgKZQGLTPZUArl7T00UUnzFS5RF2v5793R9tur9y2kiirbrGREyYmZRL2X8Eh1AXoiDe5i+eV9 eAOFX+9nd6k2/c9KgvSXlcOat8GLN3mN7OZdPy6HGw4OWGszC6XWpFY7HjuO/ILfXZ9Oxe8gb08Rd IrAsKK+rjkIECQS1Z9DIMqfrEwywBKM/d70kssEbL8VgpDhb6W0KTHeTlqL0nHsnKoyxzpAqkTTaH FjMe+erAEB6suA11gdnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyx3R-00HXkC-4U; Thu, 01 Jul 2021 13:48:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyx3O-00HXji-4w for linux-arm-kernel@lists.infradead.org; Thu, 01 Jul 2021 13:48:31 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 27F8A61420; Thu, 1 Jul 2021 13:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625147309; bh=xq5lgInObWsa70Xiu5Iswt0q2HU0wkkrlQXuVnMsCo4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ni1obni1R2bCfhKrCikDMlNHSVodaAc8ARaPmYETdp5Zl7ssxEgxXjZz100rN0RGt LrI2nbs/WlmdHqVvzTVJsU0bh652wq9lqj3DJgUEozyfcS289SzxXnKk1P915HooOE +YdIpUg8W0evBQWvjQpsBInL334396gv70OP3t+8XN8kGzz8jXW7k4cKDse1f1Sn52 pV6ebuMtHttt0ENkQ3UvwM799w302Uex4kgEYxne99sB3eKoJUcljPGeL4Kj8iE/xL S2ppHWa4hHvlwRDma85SQ4b1DmOemJHVje85dHZgaJFA+AERqwEcZBDhWYoeeeu/fL P1s6ObOE7OJKg== Date: Thu, 1 Jul 2021 14:48:23 +0100 From: Will Deacon To: Fuad Tabba Cc: kvmarm@lists.cs.columbia.edu, maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v2 08/13] KVM: arm64: Guest exit handlers for nVHE hyp Message-ID: <20210701134823.GH9757@willie-the-truck> References: <20210615133950.693489-1-tabba@google.com> <20210615133950.693489-9-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210615133950.693489-9-tabba@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210701_064830_245745_B6A3E002 X-CRM114-Status: GOOD ( 17.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 15, 2021 at 02:39:45PM +0100, Fuad Tabba wrote: > Add an array of pointers to handlers for various trap reasons in > nVHE code. > > The current code selects how to fixup a guest on exit based on a > series of if/else statements. Future patches will also require > different handling for guest exists. Create an array of handlers > to consolidate them. > > No functional change intended as the array isn't populated yet. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/kvm/hyp/include/hyp/switch.h | 19 ++++++++++++++ > arch/arm64/kvm/hyp/nvhe/switch.c | 35 +++++++++++++++++++++++++ > 2 files changed, 54 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/include/hyp/switch.h b/arch/arm64/kvm/hyp/include/hyp/switch.h > index e4a2f295a394..f5d3d1da0aec 100644 > --- a/arch/arm64/kvm/hyp/include/hyp/switch.h > +++ b/arch/arm64/kvm/hyp/include/hyp/switch.h > @@ -405,6 +405,18 @@ static inline bool __hyp_handle_ptrauth(struct kvm_vcpu *vcpu) > return true; > } > > +typedef int (*exit_handle_fn)(struct kvm_vcpu *); > + > +exit_handle_fn kvm_get_nvhe_exit_handler(struct kvm_vcpu *vcpu); > + > +static exit_handle_fn kvm_get_hyp_exit_handler(struct kvm_vcpu *vcpu) > +{ > + if (is_nvhe_hyp_code()) > + return kvm_get_nvhe_exit_handler(vcpu); > + else > + return NULL; > +} nit: might be a bit tidier with a ternary if (?:). But either way: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel