[PATCH] power: supply: cw2015: use dev_err_probe to allow deferred probe

[PATCH] power: supply: cw2015: use dev_err_probe to allow deferred probe

[Peter Robinson]

Deal with deferred probe using dev_err_probe so the error is handled
and avoid logging lots probe defer information like the following:

[    9.125121] cw2015 4-0062: Failed to register power supply
[    9.211131] cw2015 4-0062: Failed to register power supply

Fixes: b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/power/supply/cw2015_battery.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c
index d110597746b0..091868e9e9e8 100644
--- a/drivers/power/supply/cw2015_battery.c
+++ b/drivers/power/supply/cw2015_battery.c
@@ -679,7 +679,9 @@ static int cw_bat_probe(struct i2c_client *client)
 						    &cw2015_bat_desc,
 						    &psy_cfg);
 	if (IS_ERR(cw_bat->rk_bat)) {
-		dev_err(cw_bat->dev, "Failed to register power supply\n");
+		/* try again if this happens */
+		dev_err_probe(&client->dev, PTR_ERR(cw_bat->rk_bat),
+			"Failed to register power supply\n");
 		return PTR_ERR(cw_bat->rk_bat);
 	}
 
-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] power: supply: cw2015: use dev_err_probe to allow deferred probe

[Javier Martinez Canillas]

On Fri, Jul 2, 2021 at 12:07 AM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> Deal with deferred probe using dev_err_probe so the error is handled
> and avoid logging lots probe defer information like the following:
>
> [    9.125121] cw2015 4-0062: Failed to register power supply
> [    9.211131] cw2015 4-0062: Failed to register power supply
>
> Fixes: b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---

Right, I also found this error message annoying and agree that's too noisy.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Best regards,
Javier

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] power: supply: cw2015: use dev_err_probe to allow deferred probe

[Sebastian Reichel]

[-- Attachment #1.1: Type: text/plain, Size: 904 bytes --]

Hi,

On Fri, Jul 02, 2021 at 12:14:40AM +0200, Javier Martinez Canillas wrote:
> On Fri, Jul 2, 2021 at 12:07 AM Peter Robinson <pbrobinson@gmail.com> wrote:
> >
> > Deal with deferred probe using dev_err_probe so the error is handled
> > and avoid logging lots probe defer information like the following:
> >
> > [    9.125121] cw2015 4-0062: Failed to register power supply
> > [    9.211131] cw2015 4-0062: Failed to register power supply
> >
> > Fixes: b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")
> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > ---
> 
> Right, I also found this error message annoying and agree that's too noisy.
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Thanks, queued (but would have been nicer to just return
dev_err_probe() instead of doing another round of PTR_ERR
conversion).

-- Sebastian

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel