From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A58F8C07E99 for ; Mon, 5 Jul 2021 11:26:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71CC2613C2 for ; Mon, 5 Jul 2021 11:26:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71CC2613C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2K1573eAR05u4nkp9lCRuOGFMFEo4iDpJLrZ7BFFE+M=; b=PHH1CIvhRX93O6 U4oKjfI2nrCSIO9MUlVW+xNriCaUj4BA6Xs0Ps8R8fuOhOqiZkWhBrS410VoXHBubwtyZdAi+FrPI Zamhag0oDHrAmHSTjS3BPDe1iAKdNgbAsCkEtN5Jywkvm7sMh17CpLAg9TFkTpdvaB/I1J3v0c2jf Hjbtrh7kRMcp0/28b8vHHOA2Mh+symx8jNNU/ZXjI8l6vkGClH3BXHmGOYM5oCG8AQ4eBG0GYXz4B d2Yvxshy3FxHhmC3ck9G1KNeprfKhtjF+XUcZlj9LMiA0Ij2/wO7pQglJ8hTRUib1tHpObEnYkJ5r n2Y1+V2aDXWdVpmQQwNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0Mic-008khT-01; Mon, 05 Jul 2021 11:24:54 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0MiX-008kfs-B4 for linux-arm-kernel@lists.infradead.org; Mon, 05 Jul 2021 11:24:50 +0000 Received: by mail-pl1-x62b.google.com with SMTP id e17so748427plh.8 for ; Mon, 05 Jul 2021 04:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7HWSIChMpvUjyne/+iJK2NPPKvcxByEobpjhiLGyCKk=; b=bPA/eh65H3IBxzAl/nscoi1CePeGE5JUOHngiDPYOwI161KXtYRyGEqH1FUqqIwLft 97jn4zqxhljeQ78qtpttp9UGw5flJbhVGQU3RHuB1DIQfgCeuBA5wDhvRy89YcchNRIV VQh3kU5ISqOov3FaltGDSNlOIkJg8sFA909+eFzzP9WjJ8ql5LPdT3qqF2AO0JbdClzr M1ao4D4ABua/DyW+EJc/nNskJ7n44JmzxOKSdf/uwkRBnklC54/SqvjQoF3uugmLaRp4 PFXpaN9p6hRAyw5ir03FV4B41Mp2XLgPFUyRxjgrfQJIdB7Hjmc1YIfzEH1Cs0xIlTIJ NWgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7HWSIChMpvUjyne/+iJK2NPPKvcxByEobpjhiLGyCKk=; b=YMy7NtH+KObw66th7zc8hYHZsNZkduz3xBdcohTWf0Z2ss6YZtKxtPMdtk3x1StCWs CMoWcgB0CBfF1u4bBsSFm+H34r2iXtADtdN6ZLLxjYxQB+rS2A7bmeeRqDYlrCNl8QO2 euIX0AbAk5d7czvnboJsz+NNlyvCQGXrJ34XhatF7L/RNqQ14ub2Pt1/WBXL92Lqn1eD TBiar8ip+APQEGE4ntxNvrtiVLsikiLWX3q6/jkxXw9lGyNbFba6V7ckkEYMRIvqE9ol iM9lrcOjyT+OBOWzBXjGuViylyg2gBkhOU4IIDUFmMQ6ygVAGhuDPWxVvrhHjSnnRvxh m4Uw== X-Gm-Message-State: AOAM531/gjFrewfT4QFQ90rvjmWOyRwh0By3Bg/uW83q+WAtKoM5pNm1 CXr1oZcfUxljQylKMjudE44= X-Google-Smtp-Source: ABdhPJyhdW1IXbRJTGRkQQldq1nzoqRNJAfPauv5zx+jq/5w2S/3Erw0Ek8YX4oIplABIeeZeiFCSQ== X-Received: by 2002:a17:90b:2307:: with SMTP id mt7mr14580381pjb.131.1625484288340; Mon, 05 Jul 2021 04:24:48 -0700 (PDT) Received: from ojas ([122.177.226.131]) by smtp.gmail.com with ESMTPSA id c184sm12408849pfa.38.2021.07.05.04.24.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 04:24:48 -0700 (PDT) Date: Mon, 5 Jul 2021 16:54:34 +0530 From: Ojaswin Mujoo To: Dan Carpenter Cc: kbuild@lists.01.org, nsaenz@kernel.org, lkp@intel.com, kbuild-all@lists.01.org, gregkh@linuxfoundation.org, stefan.wahren@i2se.com, arnd@arndb.de, phil@raspberrypi.com, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/5] staging: vchiq: Move vchiq char driver to its own file Message-ID: <20210705112409.GA42167@ojas> References: <3b7178086322f774772d95141764ed99d0698139.1625401927.git.ojaswin98@gmail.com> <202107051622.6i1l1vdL-lkp@intel.com> <20210705105804.GA41070@ojas> <20210705111944.GH26672@kadam> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210705111944.GH26672@kadam> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210705_042449_435165_836629ED X-CRM114-Status: GOOD ( 27.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 05, 2021 at 02:19:44PM +0300, Dan Carpenter wrote: > On Mon, Jul 05, 2021 at 04:28:04PM +0530, Ojaswin Mujoo wrote: > > Hello Dan, > > > > On Mon, Jul 05, 2021 at 12:56:09PM +0300, Dan Carpenter wrote: > > > Hi Ojaswin, > > > > > > url: https://github.com/0day-ci/linux/commits/Ojaswin-Mujoo/vchiq-Patch-to-separate-platform-and-cdev-code/20210705-000124 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 77ad1f0e99bd00af024e650b862cfda3137af660 > > > config: i386-randconfig-m021-20210705 (attached as .config) > > > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > Reported-by: Dan Carpenter > > > > > > smatch warnings: > > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c:1235 vchiq_release() warn: argument 3 to %lx specifier is cast from pointer > > > > > > vim +1235 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c > > > > > > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1227 static int vchiq_release(struct inode *inode, struct file *file) > > > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1228 { > > > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1229 struct vchiq_instance *instance = file->private_data; > > > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1230 struct vchiq_state *state = vchiq_get_state(); > > > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1231 struct vchiq_service *service; > > > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1232 int ret = 0; > > > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1233 int i; > > > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1234 > > > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 @1235 vchiq_log_info(vchiq_arm_log_level, "%s: instance=%lx", __func__, > > > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1236 (unsigned long)instance); > > > > > > This should eventually be converted to %p so it doesn't defeat KASLR. > > > (Not that we really care on raspberry pi, I think?) > > Yes, that does seem right, however, this patchset only moves the code from > > vchiq_arm.c to vchiq_dev.c and I've not really touched any of the > > existing code itself (Except moving it to a new file which is why it shows up > > in the patch). > > > > Hence, I'm not sure if this fix is in scope of this patchset. (I also > > have a similar warning by kernel test robot here [1] which and I'm not > > sure if I need to act upon). Maybe we can look at this in a separate > > patch? > > Yes. Correct. Don't mix this into the patch, do it "eventually". Or > you don't have to do it at all since it wasn't something you introduced. > Someone will check the driver for Smatch warnings before it can be moved > out of staging. > > (I just forwarded the kbuild bot messages for informational purposes > only). Ahh okay, got it. Thanks, Ojaswin > > regards, > dan carpenter > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel