From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57B58C07E95 for ; Wed, 7 Jul 2021 16:59:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2207161CBE for ; Wed, 7 Jul 2021 16:59:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2207161CBE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=7qSc2pkYnlnz1reUCRqjdP4FrfATEeKoASPw2j2e5y0=; b=B8I3lUkSE9PKjZ j1hpmyRb/DXQNnqL5ycBUlL2hh/aA83M4DMStrX2VjHD5vJiEehFlQ5XnjEujqh0w87FLfmq0/mfF hddR09UYrsA5P2HQv7ZyNzJy5Yu/FAmOjz+AKgMQeroeFpcsA3qO75s6dBS+AOb5XcanyJLK7uAUg SfS36OgixBZEE7twpgLcEQ37eVuxVViibXsTX9mNEtb6x3sXr/8SSddyoIr3J2wOt0yqC0npnto2C g7ZFDojJnslAb29GDg5jtQn0LvWCKfh29YuObfkE+mQd8SVxY4lmh/AvnZZ8g7V8wjJHMVOZTpnpb wxf0VUFG72CpxHfHU+Lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1Arq-00FKcp-AM; Wed, 07 Jul 2021 16:57:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1Arl-00FKc4-Mr; Wed, 07 Jul 2021 16:57:43 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 67CD161CC9; Wed, 7 Jul 2021 16:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625677060; bh=pKg+53aXLttA74ug+LXLCafFqlN4UP06zqq+zHWqBMI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=qaVM8sbMBbYeCFb2kv15TMgBg0hQzIyqnb2OAW4cPtPGWiFcWaM3YYEOpY7SVyRp/ 5yYqUb/GNFFDgvXFwHCsTmR7jUx1lIH6APvjaxlue0rWZCuu67zBddRtZXQSbTr1KM Cn6s8fUUhJy4icnFNFD8jyhqfxcURx1tlrvVTAU4jnIJ94o4B+stbLK/rsMjkwN/iX 6YL1VC3WMxv11uHgwrdWhLDa0LiIL+e88w1DIeK7LhCDMPzf9Ih9HAFyNooifxme8B ivYKvTgD1+LCIa+EorgTO6kT4v9hVaqOf+ZtYJWWD/wCWweCrOVffn30wP6JFi304Z hPEeEEK6Qfc7A== Date: Wed, 7 Jul 2021 11:57:35 -0500 From: Bjorn Helgaas To: Neil Armstrong Cc: Art Nikpal , Huacai Chen , =?utf-8?B?6ZmI5Y2O5omN?= , Yue Wang , Kevin Hilman , Lorenzo Pieralisi , Rob Herring , Krzysztof Wilczynski , Jerome Brunet , Christian Hewitt , Martin Blumenstingl , PCI , linux-arm-kernel , "open list:ARM/Amlogic Meson..." , LKML , Artem Lapkin , Nick Xie , Gouwa Wang Subject: Re: [PATCH 0/4] PCI: replace dublicated MRRS limit quirks Message-ID: <20210707165735.GA905464@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210707_095741_828041_C47A227A X-CRM114-Status: GOOD ( 31.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 07, 2021 at 06:43:13PM +0200, Neil Armstrong wrote: > On 07/07/2021 17:54, Bjorn Helgaas wrote: > > On Tue, Jul 06, 2021 at 11:54:05AM +0200, Neil Armstrong wrote: > >> In their Designware PCIe controller driver, amlogic sets the > >> Max_Payload_Size & Max_Read_Request_Size to 256: > >> https://elixir.bootlin.com/linux/latest/source/drivers/pci/controller/dwc/pci-meson.c#L260 > >> https://elixir.bootlin.com/linux/latest/source/drivers/pci/controller/dwc/pci-meson.c#L276 > >> in their root port PCIe Express Device Control Register. > >> > >> Looking at the Synopsys DW-PCIe Databook, Max_Payload_Size & > >> Max_Read_Request_Size are used to decompose into AXI burst, but it > >> seems the Max_Payload_Size & Max_Read_Request_Size are set by > >> default to 512 but the internal Max_Payload_Size_Supported is set to > >> 256, thus changing these values to 256 at runtime to match and > >> optimize bandwidth. > >> > >> It's said, "Reducing Outbound Decomposition" : > >> - "Ensure that your application master does not generate bursts of > >> size greater than or equal to Max_Payload_Size" > >> > >> - "Program your PCIe system with a larger value of Max_Payload_Size > >> without exceeding Max_Payload_Size_Supported" > >> > >> - "Program your PCIe system with a larger value of Max_Read_Request > >> without exceeding Max_Payload_Size_Supported: > >> > >> So leaving 512 in Max_Payload_Size & Max_Read_Request leads to > >> Outbound Decomposition which decreases PCIe link and degrades the > >> AXI bus by doubling the bursts, leading to this fix to avoid > >> overflowing the AXI bus. > >> > >> So it seems to be still needed, I assume this *should* be handled in > >> the core somehow to propagate these settings to child endpoints to > >> match the root port Max_Payload_Size & Max_Read_Request sizes. > >> > >> Maybe by adding a core function to set these values instead of using > >> the dw_pcie_find_capability() & dw_pcie_write/readl_dbi() helpers > >> and set a state on the root port to propagate the value ? > > > > I don't have the Synopsys DW-PCIe Databook, so I'm lacking any > > context. The above *seems* to say that MPS/MRRS settings affect AXI > > bus usage. > > It does when the TLPs are directed to the RC. That's a defect in the RC. > > The MPS and MRRS registers are defined to affect traffic on *PCIe*. If > > a platform uses MPS and MRRS values to optimize transfers on non-PCIe > > links, that's a problem because the PCI core code that manages MPS and > > MRRS has no knowledge of those non-PCIe parts of the system. > > Yes and no, it only affects PCIe in P2P, in non-P2P is will certainly affect > transfers on the internal SoC/Processor/Chip internal bus/fabric. > > > You might be able to deal with this in Synopsys-specific code somehow, > > but it's going to be a bit of a hassle because I don't want it to make > > maintenance of the generic MPS/MRRS code harder. > > I understand, but this is why these quirks are currently implemented in the > controller driver and only applies when the controller has been probed > and to each endpoint detected on this particular controller. > > So we may continue having separate quirks for each controller if the core > isn't the right place to handle MPS/MRRS. The PCI core is the correct place to handle MPS/MRRS because their behavior is defined by the PCIe spec. Quirks are the way to work around this defect in the Synopsys PCIe IP. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel