From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B03C07E96 for ; Sun, 11 Jul 2021 08:09:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE08561220 for ; Sun, 11 Jul 2021 08:09:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE08561220 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rIW+sFc5DCkLq0u5Ljs6pSknBYYyroJ40y0o3H6uxVc=; b=QmR5tq2ivAH8ku EY0H/nqPKNSZfx2/VW2nLqEiba9cDflSnseeOyT9pkpI1d2anlq1wLtE/MTLVrN0u5CieDYojX7vs OUN6a6UEhRUSXZ7VRYcxrxYhNx5ljXaTMOa270ECZn0udpqfTk/Rtj/KpQvOoDNzJoR8f5J7rJc/o KHMnRD62BbLItewSWK2GesaRmnF9WX180HCYfCZwk5TrXWNIaeIvMSSR169h7FbPWmqrQHCMxJTVS n4mIO55B5QUK8X7mkQCgmMpr+SPg/gU8Dyi11mdo2a9svSeaciAGw9n4EBkoYbQvYnpKuENVZhb+H 5u4ZkJ8OtYrfwLqEmQfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2UVY-004hmt-6h; Sun, 11 Jul 2021 08:08:12 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2UVU-004hm2-C1 for linux-arm-kernel@lists.infradead.org; Sun, 11 Jul 2021 08:08:09 +0000 Received: by mail-pl1-x62a.google.com with SMTP id x16so6511089plg.3 for ; Sun, 11 Jul 2021 01:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uoCCXZXvrI1rDzjVf/fCu+A/YGEVLGhBR8+AmTK+J0g=; b=nkvEfNPrkZ14CAZBB2c+ZcblrbsE5/lHUZQ+id/905lrUSb8SJuMEfca56Cj7l6bfn 6Od72UoVGjRaARvUzTksn2P5XKXAGpkhRH6VKfVMDNu4u3X4s90iKLz65HWTHcsN96C4 pX6IO61HhJKP6TOZERzHkmM3UbZ4t6IqK+MCAHT2w+U5+n/Pv+J+Yr4RGFRBoaAgm6/g y0wh4QlPWBmxec+EeyLFVTPZXw2o3wObzm52+2wWR6fHFLB3N/45RzZcCWm4Nyuv7eIE kuQ66P/wu+fKbF+w1grRW/9doUyh6RxU67MacmvQoDB79CtaGArSlOHFacde8WJSzj/3 Ps8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uoCCXZXvrI1rDzjVf/fCu+A/YGEVLGhBR8+AmTK+J0g=; b=naUKg8NbznPg35A4ygJgvIMF5awdOgvoZU2wFL6tmLH4seQmcmcipqEhWNBx6BudsG ADS0beU3jJiiW992QUAUKZBwRSh1ubf3tKZWWEYkx/9xmYgji4STrtbguVokNMUQWPSI 2biEsc3fX9opZVbRSO4sNKqufLvSECN/LNRKxHCokc+G/o00+PCgcf6D7W6gC838mw7b bgKUatxxq7bLWm3NenbzOuI5ZuvqcxwG1e/6Oggg8WrXNMLO/K7kM5mH0ZRNFjZoZJ/D tFiLSij9FRh0Y8T5SkzxxNJvJi73Nuqrp2afO4p/qbygDglThNVn4AzAcp2y1m4GHoT5 ZpEQ== X-Gm-Message-State: AOAM533bYn5j7QHMI1mXVdNEcOdW4LDnE8pbcEq301tVXmmQtVOaslB8 WqS+evPtBhyMXXuu0VT1fc+ZyQ== X-Google-Smtp-Source: ABdhPJy9WSM9plj/arZagBkfTvNz3p9NQ5BVrKge1/+AbtvvWIAeYCdVgS7pN1pwU3FJzkhcbfHF5A== X-Received: by 2002:a17:90a:9f06:: with SMTP id n6mr8060917pjp.219.1625990887376; Sun, 11 Jul 2021 01:08:07 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([202.131.71.237]) by smtp.gmail.com with ESMTPSA id b19sm10319016pjh.29.2021.07.11.01.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jul 2021 01:08:06 -0700 (PDT) Date: Sun, 11 Jul 2021 16:08:00 +0800 From: Leo Yan To: Adrian Hunter Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Mathieu Poirier , Suzuki K Poulose , Mike Leach , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 07/10] perf: Cleanup for HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT Message-ID: <20210711080800.GD273828@leoy-ThinkPad-X240s> References: <20210704071644.107397-1-leo.yan@linaro.org> <20210704071644.107397-8-leo.yan@linaro.org> <86cd5d3d-2441-2f8e-28ab-54802e47c68b@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86cd5d3d-2441-2f8e-28ab-54802e47c68b@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210711_010808_440871_28DB8316 X-CRM114-Status: GOOD ( 17.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adrian, On Sat, Jul 10, 2021 at 03:36:53PM +0300, Adrian Hunter wrote: > On 4/07/21 10:16 am, Leo Yan wrote: > > Since the __sync functions have been dropped, This patch removes unused > > build and checking for HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT in perf tool. > > > > Note, there have a test for SYNC_COMPARE_AND_SWAP and the test file is > > located in build/feature/test-sync-compare-and-swap.c. Since there > > still has several components using the sync functions, it's deliberately > > to not be removed. > > I don't quite follow that. If they aren't using the feature test > macro, then why keep the feature test? There are files are still using __sync_xxx_compare_and_swap() functions, e.g. in the folder tools/testing/selftests/bpf. On the other hand, after drop __sync functions from perf, there have no any Makefile check the feature 'feature-sync-compare-and-swap'. So it's safe to remove the feature test. Sorry for confusion. Will drop the feature test in new patch set. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel