From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19034C07E99 for ; Mon, 12 Jul 2021 10:00:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C57F9610CD for ; Mon, 12 Jul 2021 10:00:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C57F9610CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xiXy3cdTqwt5keI3GD0sFxSVv0hrwFHV4UsZdRVnA0Q=; b=UumD5VXlJIAqaY rdbFuQjfiS/hpC6CAXMJJEtGxsgFDzorFSDDsgm2wYLgb1EXCAyWEDqRRG9INRf4vNOch8xD8Imrn gGhF5F+M0xRzlmjw8Ah2lXzMrft+wVCGn5c7myge/FvSSpBferd2l2puiGUOjtUdIxihTZ0xihFzi QtWWmm2mZqmiSpoK27I7qSelKtNXpcmoU2edovt78HVudGJW3ym0fGfodc35Eu9m6glf7mO+dF9Xj 2SWyUp/sx77h5CEIfxVy3gPK+i0CCeehedBjrdtaljgCFrjGnSIazkxxMm2vCnddMzre4pKsAdRgI X/tv3gYi2iD1VC0qxD9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2si2-006o9C-FK; Mon, 12 Jul 2021 09:58:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2shz-006o8U-4D for linux-arm-kernel@lists.infradead.org; Mon, 12 Jul 2021 09:58:40 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 483AA61002; Mon, 12 Jul 2021 09:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626083918; bh=tAO2c2XXve5OQIfwuwmw8NDac9gYcA9t8R4T8p3VA0Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sp0gWhgawuzzkSTZB9An1dEpC06L7mSKerBgmHNsBuQEZqcX7v/G/eqD1eXNqzWe4 yZAkZzS6Jq5C0os3RCAFe1lMoJqAY+DAPY2CpxU4/0RukVap9iaXoSgjoHUaZz7PfF p6cCtj476QWfjI+v+DjtN/6VgQUdHDWlK9/akaQFyv9Jv7bhQ5OxzaVbvD69pX4stF +7Di9KazK8Wt2lnWl3MXvN24QJtGwNkSpiH0cuXUm3lOPnGNAKAwUHUBj4pWWqcjHW sOOQNC+TOsXyJqjR+Bu5As4jU8sJnn23PPD6Pw13Nr+3iDT9TTBLnemK86jOnQsmN7 VzQWv0FdIsWmA== Date: Mon, 12 Jul 2021 10:58:32 +0100 From: Will Deacon To: Andrey Konovalov Cc: Mark Rutland , Sam Tebbs , Robin Murphy , Andrew Morton , Linux ARM , LKML , Catalin Marinas , Dmitry Vyukov , Alexander Potapenko , Andrey Ryabinin , Marco Elver Subject: Re: [PATCH] kasan: fix build for CONFIG_KASAN_HW_TAGS Message-ID: <20210712095832.GA27643@willie-the-truck> References: <20210708144411.25467-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_025839_229408_C7303798 X-CRM114-Status: GOOD ( 22.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 10, 2021 at 09:16:14PM +0200, Andrey Konovalov wrote: > On Thu, Jul 8, 2021 at 4:44 PM Mark Rutland wrote: > > > > When CONFIG_KASAN_HW_TAGS is selected, uses _RET_IP_, > > but doesn't explicitly include where this is defined. > > > > We used to get this via a transitive include, but since commit: > > > > f39650de687e3576 ("kernel.h: split out panic and oops helpers") > > > > ... this is no longer the case, and so we get a build failure: > > > > | CC arch/arm64/mm/kasan_init.o > > | In file included from arch/arm64/mm/kasan_init.c:10: > > | ./include/linux/kasan.h: In function 'kasan_slab_free': > > | ./include/linux/kasan.h:211:39: error: '_RET_IP_' undeclared (first use in this function) > > | 211 | return __kasan_slab_free(s, object, _RET_IP_, init); > > | | ^~~~~~~~ > > | ./include/linux/kasan.h:211:39: note: each undeclared identifier is reported only once for each function it appears in > > | ./include/linux/kasan.h: In function 'kasan_kfree_large': > > | ./include/linux/kasan.h:219:28: error: '_RET_IP_' undeclared (first use in this function) > > | 219 | __kasan_kfree_large(ptr, _RET_IP_); > > | | ^~~~~~~~ > > | ./include/linux/kasan.h: In function 'kasan_slab_free_mempool': > > | ./include/linux/kasan.h:226:34: error: '_RET_IP_' undeclared (first use in this function) > > | 226 | __kasan_slab_free_mempool(ptr, _RET_IP_); > > | | ^~~~~~~~ > > | ./include/linux/kasan.h: In function 'kasan_check_byte': > > | ./include/linux/kasan.h:277:35: error: '_RET_IP_' undeclared (first use in this function) > > | 277 | return __kasan_check_byte(addr, _RET_IP_); > > | | ^~~~~~~~ > > > > Fix this by including explicitly. > > Hi Mark, > > Marco already sent a fix for this. It should be in the mm tree. > (Although the link to it in the Andrew's notification email doesn't > work. But they rarely do :) Do you have a link to the patch? I couldn't spot it in linux-next. Thanks, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel