From: Cristian Marussi <cristian.marussi@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: arm_scmi: Fix kernel doc warnings
Date: Mon, 12 Jul 2021 15:32:31 +0100 [thread overview]
Message-ID: <20210712143231.GA6592@e120937-lin> (raw)
In-Reply-To: <20210712130801.2436492-2-sudeep.holla@arm.com>
On Mon, Jul 12, 2021 at 02:08:01PM +0100, Sudeep Holla wrote:
> Kernel doc validation script is unhappy and complains with the below set
> of warnings.
>
> | Function parameter or member 'fast_switch_possible' not described in 'scmi_perf_proto_ops'
> | Function parameter or member 'power_scale_mw_get' not described in 'scmi_perf_proto_ops'
> | cannot understand function prototype: 'struct scmi_sensor_reading '
> | cannot understand function prototype: 'struct scmi_range_attrs '
> | cannot understand function prototype: 'struct scmi_sensor_axis_info '
> | cannot understand function prototype: 'struct scmi_sensor_intervals_info '
>
> Fix them adding appropriate documents or missing keywords.
>
Hi,
LGTM.
I've found a few more kernel-doc warning in SCMI stack.
I'll send those in a separate patch if you'd wanna put all together.
FWIW, Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-12 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 13:08 [PATCH] firmware: arm_scpi: Fix kernel doc warnings Sudeep Holla
2021-07-12 13:08 ` [PATCH] firmware: arm_scmi: " Sudeep Holla
2021-07-12 14:32 ` Cristian Marussi [this message]
2021-07-14 16:39 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712143231.GA6592@e120937-lin \
--to=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).