From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ohad@wizery.com,
dongas86@gmail.com, bjorn.andersson@linaro.org, cleger@kalray.eu
Subject: Re: [PATCH 1/2] remoteproc: fix an typo in fw_elf_get_class code comments
Date: Mon, 12 Jul 2021 11:29:59 -0600 [thread overview]
Message-ID: <20210712172959.GA1779922@p14s> (raw)
In-Reply-To: <20210706142156.952794-1-aisheng.dong@nxp.com>
On Tue, Jul 06, 2021 at 10:21:55PM +0800, Dong Aisheng wrote:
> Drop 'and' which looks like unnecessary.
>
> Fixes: 73516a33588c ("remoteproc: Add elf helpers to access elf64 and elf32 fields")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> drivers/remoteproc/remoteproc_elf_helpers.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/remoteproc_elf_helpers.h b/drivers/remoteproc/remoteproc_elf_helpers.h
> index 26404e68e17a..e6de53a5000c 100644
> --- a/drivers/remoteproc/remoteproc_elf_helpers.h
> +++ b/drivers/remoteproc/remoteproc_elf_helpers.h
> @@ -15,7 +15,7 @@
> * fw_elf_get_class - Get elf class
> * @fw: the ELF firmware image
> *
> - * Note that we use and elf32_hdr to access the class since the start of the
> + * Note that we use elf32_hdr to access the class since the start of the
> * struct is the same for both elf class
The sentence should read:
"Note that we use an elf32_hdr..."
With the above:
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> *
> * Return: elf class of the firmware
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-07-12 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 14:21 [PATCH 1/2] remoteproc: fix an typo in fw_elf_get_class code comments Dong Aisheng
2021-07-06 14:21 ` [PATCH 2/2] remoteproc: fix kernel doc for struct rproc_ops Dong Aisheng
2021-07-12 17:41 ` Mathieu Poirier
2021-07-12 17:29 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712172959.GA1779922@p14s \
--to=mathieu.poirier@linaro.org \
--cc=aisheng.dong@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=cleger@kalray.eu \
--cc=dongas86@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).