From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7D8DC07E99 for ; Mon, 12 Jul 2021 17:31:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B69BF606A5 for ; Mon, 12 Jul 2021 17:31:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B69BF606A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CnMYzJNfXPniHfbKpeVt2gGJz9tKM24Wsj7JfjxwqSI=; b=FWn9f+L1k0B2Kj p8HM70Hn9kueX+Jy/kc+48HVlN54RJiZdGoEmc7kHVn6IIzQRJ6s208+a5OGfSrUnocy8PpNTjI2P ASScPhjr6vgGAQvj5B8B4wFBXHTJx1ev5VjCdpaZ+ZhZ4iB+d5Q4NVd+hGHzoOjwd/T69uemN2Anq WWG+7SELoM29H+Zf+LjzxFv1CQ/FkyvrQJZo/KFASSt2uf80uNFSZFWhrb0/0GxmjVPS+MgbG//wJ MNBqinBGqbFYzO5pejJNaHp+rbkGaNOUngRTdRWEYjWuK/PcGjCMHcVxf69LFFm1wc+Pk6jrZeekh H4O6tbXBvQoaoecOW0Vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2zku-0083tp-IQ; Mon, 12 Jul 2021 17:30:08 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2zkp-0083tU-VE for linux-arm-kernel@lists.infradead.org; Mon, 12 Jul 2021 17:30:05 +0000 Received: by mail-pg1-x534.google.com with SMTP id a2so18994170pgi.6 for ; Mon, 12 Jul 2021 10:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Bl5lPT61BurctfIDgaQ/f+sYzra2LoJ5ZZtY4MpkY2g=; b=TqY7DcGO/1xFL+T2KqKL7w85TzTUNFwRjE2Gdn9SU28zTn/q682lhMKQ0D94N0/n9k arK8S11fW7lRxpmMy8nHbNL9qeckO/TixqSMYfFB7bV/U3Xj2axsiXJ3GjhrYl8+aOqL oVBAgj6qOiIp4iuMRqLcnc5sdlMr6CnRQNF9YzeBoh10u6TLlsucs3r4MApqHXcEmbGR W+7zPYvs5saKL7nKCRZYAwdLEQn+ZVHum2rNjD3y5RCgfjzPGQ4BNlIEYnUG+Gnb6Sqw 9x2Q5bShpoRvGZnYN0JvvkXeC/jDEnH2zssWQTEMSXuwbZEk9+tbkL62OITli+kb8bXs j2CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Bl5lPT61BurctfIDgaQ/f+sYzra2LoJ5ZZtY4MpkY2g=; b=SW79K/Myp4KgLVbVVjF3GN140u/2K0oPdijOgiWSo+4f002bP+gBjuuzcNLW8v2HHY TuhUxv9pUJ58JxbHKgnEWKD2hYRY1Hr74BIsyNS1tygF9+GGO1hy22G2Z8gQxBOemyRD VJRqSwY+p4e4PieUPgQP0iq/IV7kV4j25KyXAfCpTQyEv0TDXDz22UAS7CmKg5t5gx9j rnEvo6q0ADFqPdOHQ4UnyiiJNRDLYPSx8jrGj+mTyOnSBknYsHuapevhxvSUTt4NadfR GQvOl7MgN+HUO2OqMj3AQfVbEzQs4KVaqxGLasT2TMToAQQlFNJJTD4WhQNAxTiKjmoO 9tWQ== X-Gm-Message-State: AOAM530EftWYnE/dyLtPUB4/P/2+cPdWt7DAY2vz4+tfp9J/Ibr/n0Xe ozETxrqfj/5HuCZXQ0aq2rqZ6w== X-Google-Smtp-Source: ABdhPJzJ/qZkXJ5cnnU664jPmMtJ3W4uZcbnY7JuJfu8VUdQbkBY8OVfYOpHXf2OyJvY16nJ9O5HvA== X-Received: by 2002:a63:5a5b:: with SMTP id k27mr248089pgm.74.1626111002679; Mon, 12 Jul 2021 10:30:02 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id j2sm16553920pfj.168.2021.07.12.10.30.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 10:30:01 -0700 (PDT) Date: Mon, 12 Jul 2021 11:29:59 -0600 From: Mathieu Poirier To: Dong Aisheng Cc: linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, cleger@kalray.eu Subject: Re: [PATCH 1/2] remoteproc: fix an typo in fw_elf_get_class code comments Message-ID: <20210712172959.GA1779922@p14s> References: <20210706142156.952794-1-aisheng.dong@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210706142156.952794-1-aisheng.dong@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_103004_085745_230346E3 X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 06, 2021 at 10:21:55PM +0800, Dong Aisheng wrote: > Drop 'and' which looks like unnecessary. > > Fixes: 73516a33588c ("remoteproc: Add elf helpers to access elf64 and elf32 fields") > Signed-off-by: Dong Aisheng > --- > drivers/remoteproc/remoteproc_elf_helpers.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/remoteproc_elf_helpers.h b/drivers/remoteproc/remoteproc_elf_helpers.h > index 26404e68e17a..e6de53a5000c 100644 > --- a/drivers/remoteproc/remoteproc_elf_helpers.h > +++ b/drivers/remoteproc/remoteproc_elf_helpers.h > @@ -15,7 +15,7 @@ > * fw_elf_get_class - Get elf class > * @fw: the ELF firmware image > * > - * Note that we use and elf32_hdr to access the class since the start of the > + * Note that we use elf32_hdr to access the class since the start of the > * struct is the same for both elf class The sentence should read: "Note that we use an elf32_hdr..." With the above: Reviewed-by: Mathieu Poirier > * > * Return: elf class of the firmware > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel