From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D04C07E95 for ; Tue, 13 Jul 2021 13:22:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26AAB6115B for ; Tue, 13 Jul 2021 13:22:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26AAB6115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+03H7aNq2C9RUeltlfxnBXDLoPx74CIDI5/56khTmBw=; b=jeE9oVsKHI2SZJ F4etRuL+758YbZPH9ZD9XhA71KLMRpf9/SvAsss4OqHPWv3QjvV/58/1KvHbQdE7TwgZk9FTwOjtK CzlCy7g5lqWVadYsYfxyYuPec09uMivY88cpSLNzBqXSvwVpgCJgP1DxTFcYqL8rPX5Oo8vBxwpJq lnXpoEauhnkARBCCS26gWpJUy/gNC7cJIJKG13poaF5B1EiHKfB9oBOpLjHwNUMEoHhE+tUIq2a32 2f3Lhm7nJdmQAmjOzNCfJNTLg7CwuLfkntj4Mu43K6SqSduJJDeymGzpW4iwzB8cNXeTu9d8enEdN nD5/nHaNyAzxS/QNrcjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3IKG-00AVEJ-Cy; Tue, 13 Jul 2021 13:19:52 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3IB8-00ATW2-VI for linux-arm-kernel@lists.infradead.org; Tue, 13 Jul 2021 13:10:30 +0000 Received: by mail-pf1-x42a.google.com with SMTP id 21so19566358pfp.3 for ; Tue, 13 Jul 2021 06:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VUU1Kwvq4GBakNNijA9o5ryuRCyw2WYxhJlpoTQmeDM=; b=F+19KqtKCMQP1/ZSGE0pKtTbAbaCy4Gy7dSnmcaKh6mlDPZcmZADNKNXMBl1BLmlgg fZEIrUhlTvD7ckmpRogdtNLrBgnsfug/fOz+izrAXCsBuGI0/sPaY1OJSok69hUjj9lv rVa5k8mLIVa4jvPEJ/12PMQYklfYqi7MASgtBYjPMYm9G1Evcn8hc8ckbGazly6vZYrR KwSrAj6hX0hr10iW7gIiUYzTx0HPlx4pYE0rPAQEtcRdax8KMDMXvkJD7TZ5c0qThQhg ehU1tXHaV5gJ7HbpAbO+ZJBWKRlgnzFrhikl7SigIricfVFBHxVVlvXoZZdzM1zalEFs QzmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VUU1Kwvq4GBakNNijA9o5ryuRCyw2WYxhJlpoTQmeDM=; b=qiS5eAccyOL1AE+fO1XBqyHk2H9ogdfveTpo4vU2nNmeCaeHfylceCraunC6CeSutm lshFH0Gkyvxadj7cW3HjAriLHZ/ZoMs41ByukBOWVpqBCuXimGn61/hRgnFIBNSuGBV+ YgXjLBfTHVOFEVt49ce9nh0+7xszyxJC690O7Zm5/M/BWO6GW+FTgcfnVVKbrHFluNKv EgY6MLA9C81UCt5/erGJMFxYqr7m4h9UV09d/qB+ZHZfsPC62t48qKNFa2i+WNWwdL5T fQkjl48+wQUcvGRYmum/LV7CpjeaM2rZp2mXieXi6/8uhx8e2PfPPHFfGRKaUPNDq1NP ARUA== X-Gm-Message-State: AOAM530zXCG90Ymot24+yajwniePj3DgwhpUUasKL9j5LhfuXm9knINm RC+3dvj7844WFhfUCMfTzh1mdg== X-Google-Smtp-Source: ABdhPJwPLGUmEVAkt/uYOyw07UUtKM7cvXZoj28ALl+IDI3I8DSEq4m+ESyjcRWzcjoCA9/lSdUCog== X-Received: by 2002:a63:d709:: with SMTP id d9mr4258879pgg.337.1626181825205; Tue, 13 Jul 2021 06:10:25 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([202.131.71.237]) by smtp.gmail.com with ESMTPSA id z13sm4449296pfn.94.2021.07.13.06.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 06:10:24 -0700 (PDT) Date: Tue, 13 Jul 2021 21:10:18 +0800 From: Leo Yan To: Adrian Hunter Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Mathieu Poirier , Suzuki K Poulose , Mike Leach , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 07/11] perf auxtrace: Remove auxtrace_mmap__read_snapshot_head() Message-ID: <20210713131018.GB748506@leoy-ThinkPad-X240s> References: <20210711104105.505728-1-leo.yan@linaro.org> <20210711104105.505728-8-leo.yan@linaro.org> <4c65b6ba-2258-ff36-2ecc-92219e61e578@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4c65b6ba-2258-ff36-2ecc-92219e61e578@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210713_061027_111015_0BF0FD9A X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 12, 2021 at 05:32:11PM +0300, Adrian Hunter wrote: [...] > > --- a/tools/perf/util/auxtrace.c > > +++ b/tools/perf/util/auxtrace.c > > @@ -1686,13 +1686,12 @@ static int __auxtrace_mmap__read(struct mmap *map, > > union perf_event ev; > > void *data1, *data2; > > > > + head = auxtrace_mmap__read_head(mm); > > + > > if (snapshot) { > > - head = auxtrace_mmap__read_snapshot_head(mm); > > if (auxtrace_record__find_snapshot(itr, mm->idx, mm, data, > > &head, &old)) > > That leaves a nested 'if' which is not kernel style i.e. could be > > if (snapshot && > auxtrace_record__find_snapshot(itr, mm->idx, mm, data, &head, &old)) Will refine in next spin, thanks for suggestion! > > return -1; > > - } else { > > - head = auxtrace_mmap__read_head(mm); > > } > > > > if (old == head) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel