From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Aisheng Dong <aisheng.dong@nxp.com>
Cc: "linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"ohad@wizery.com" <ohad@wizery.com>,
"dongas86@gmail.com" <dongas86@gmail.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 4/4] remoteproc: imx_rproc: fix rsc-table name
Date: Tue, 13 Jul 2021 11:07:13 -0600 [thread overview]
Message-ID: <20210713170713.GB1816225@p14s> (raw)
In-Reply-To: <DB9PR04MB84772D8DAA30CF992F9076E180149@DB9PR04MB8477.eurprd04.prod.outlook.com>
On Tue, Jul 13, 2021 at 02:47:44AM +0000, Aisheng Dong wrote:
> Hi Mathieu,
>
> Thanks for the feedback.
>
> > From: Mathieu Poirier <mathieu.poirier@linaro.org>
> > Sent: Tuesday, July 13, 2021 2:09 AM
> >
> > On Tue, Jul 06, 2021 at 10:23:35PM +0800, Dong Aisheng wrote:
> > > Usually the dash '-' is preferred in node name.
> >
> > ... And yet the DT binding shows &m4_reserved_sysmem1 and
> > &m4_reserved_sysmem2.
> >
> > Either change it all or leave as is.
>
> These are phandles and not node names.
> So should be ok.
>
> BTW, I've sent V2, could you help review V2 series?
> https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210707094033.1959752-1-aisheng.dong@nxp.com/
>
Looks like I reviewed the wrong version...
> Regards
> Aisheng
>
> >
> > Thanks,
> > Mathieu
> >
> > > So far, not dts in upstream kernel, so we just update node name in
> > > driver.
> > >
> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> > > Cc: Peng Fan <peng.fan@nxp.com>
> > > Fixes: 5e4c1243071d ("remoteproc: imx_rproc: support remote cores
> > > booted before Linux Kernel")
> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > > ---
> > > drivers/remoteproc/imx_rproc.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/remoteproc/imx_rproc.c
> > > b/drivers/remoteproc/imx_rproc.c index 12de153abb2d..26eb130f3263
> > > 100644
> > > --- a/drivers/remoteproc/imx_rproc.c
> > > +++ b/drivers/remoteproc/imx_rproc.c
> > > @@ -600,7 +600,7 @@ static int imx_rproc_addr_init(struct imx_rproc
> > *priv,
> > > }
> > > priv->mem[b].sys_addr = res.start;
> > > priv->mem[b].size = resource_size(&res);
> > > - if (!strcmp(node->name, "rsc_table"))
> > > + if (!strcmp(node->name, "rsc-table"))
> > > priv->rsc_table = priv->mem[b].cpu_addr;
> > > b++;
> > > }
> > > --
> > > 2.25.1
> > >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-13 17:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 14:23 [PATCH 1/4] remoteproc: fix the wrong default value of is_iomem Dong Aisheng
2021-07-06 14:23 ` [PATCH 2/4] remoteproc: imx_rproc: fix TCM io memory type Dong Aisheng
2021-07-07 2:20 ` Peng Fan
2021-07-07 6:05 ` Dong Aisheng
2021-07-06 14:23 ` [PATCH 3/4] remoteproc: imx_rproc: fix ignoring mapping vdev regions Dong Aisheng
2021-07-07 2:23 ` Peng Fan (OSS)
2021-07-06 14:23 ` [PATCH 4/4] remoteproc: imx_rproc: fix rsc-table name Dong Aisheng
2021-07-07 2:21 ` Peng Fan (OSS)
2021-07-12 18:08 ` Mathieu Poirier
2021-07-13 2:47 ` Aisheng Dong
2021-07-13 17:07 ` Mathieu Poirier [this message]
2021-07-07 2:14 ` [PATCH 1/4] remoteproc: fix the wrong default value of is_iomem Peng Fan
2021-07-07 3:25 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713170713.GB1816225@p14s \
--to=mathieu.poirier@linaro.org \
--cc=aisheng.dong@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=dongas86@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox