From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D772AC12002 for ; Wed, 14 Jul 2021 23:42:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 916E3613C8 for ; Wed, 14 Jul 2021 23:42:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 916E3613C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PjyVQDI21JWB4cuMONuU3RHanK9qgzs915BVuyVllPs=; b=lLvR8eckv/Tlf/ HAGrbTUoQw+iaX6H/sWRKRs/VmyQemL53aapDNomYfzDabpxQRofbuXoAJgkWsFlimvqmrNRq7Vqe 5jQM7wiawu59zy+pV8yRaCW2LzLERlEARi0GRkQx99IDod/T1OnxyErXguuui8VX3PWU6rJdM3QFb N11R9RRKI1ZtWGq3UkfEFh9BjJ3oC/bB+e2QHnvbUZCxPnumTV+/tperjxhuZTrWK2LgbRAu1bKz9 RvnKopxnNbTOEKEGSMgwi+UXPqmjRzn7S87thIuFi5EAl1GJ7QWf/kd1Rwsb76fk8ZIg2Wo4mUa/P W77gdW+nSBa8AlACVz+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3oUB-00GMzm-Ro; Wed, 14 Jul 2021 23:40:16 +0000 Received: from mail-io1-f47.google.com ([209.85.166.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3m42-00FG48-7C for linux-arm-kernel@lists.infradead.org; Wed, 14 Jul 2021 21:05:09 +0000 Received: by mail-io1-f47.google.com with SMTP id x10so3822228ion.9 for ; Wed, 14 Jul 2021 14:05:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uFlLvjLhE+D5X3z01n3T7/D1edVtL4g+ysZ7NAiCzC8=; b=bBvSOwE09uG+YbGYeJj17fsDq1I/8YONAvYKCixAwe2eCudJNBhh+TAVF6W3tiMSUE lwnp8XcQjl0NJRrg9UcY6lvCj3NEdMT7g9e0YhFT+ODQO28V/vUf3uwbnTWpA+qzHDC0 BJ7JIkDGiYK0YBjMCDh1rJWuZsbtTbw7CfXK64vJlHLrUqSW8bFjSFxQVzO1HEtxDFAx OTCjtmx2JIiBtf9JjyXRtL/Zz1mWRKtHJBTggthSWd2VbZWVtzxlz+sdpbrT5v5PTibf AANWcsWDcVEEKw5vD5l/35MaJnPXj2MBkk7fZjjVNmuESVMwEvjmLR4wT7/ieSjAFEPx 57vw== X-Gm-Message-State: AOAM530kqbAl5Lwnzg30QhkoFAFGnMf0kTJNGgmPronSE3kC96NHSjDT hP5TpSMmD9jHfXxxgVOGkA== X-Google-Smtp-Source: ABdhPJwHfWZOiOMqxgq7S7wSy3VFa4SGeHXDDjjR+0+RTr6LodRjuwpKb3ch8Qwm9JHaUJ9lq+nE+w== X-Received: by 2002:a05:6602:2bc9:: with SMTP id s9mr60381iov.11.1626296704235; Wed, 14 Jul 2021 14:05:04 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id h6sm1718611iop.40.2021.07.14.14.05.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jul 2021 14:05:03 -0700 (PDT) Received: (nullmailer pid 3521178 invoked by uid 1000); Wed, 14 Jul 2021 21:04:58 -0000 Date: Wed, 14 Jul 2021 15:04:58 -0600 From: Rob Herring To: Ming Qian Cc: mchehab@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, hverkuil-cisco@xs4all.nl, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 01/13] dt-bindings: media: imx8q: add imx video codec bindings Message-ID: <20210714210458.GA3512308@robh.at.kernel.org> References: <201c608e24da92498fde48708afa2dedde5c8f0b.1624954576.git.ming.qian@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201c608e24da92498fde48708afa2dedde5c8f0b.1624954576.git.ming.qian@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_140506_359153_64A4EDC6 X-CRM114-Status: GOOD ( 20.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 29, 2021 at 04:21:02PM +0800, Ming Qian wrote: > Add devicetree binding documentation for IMX8Q Video Processing Unit IP > > Signed-off-by: Ming Qian > Signed-off-by: Shijie Qin > Signed-off-by: Zhou Peng > --- > .../bindings/media/nxp,imx8q-vpu.yaml | 191 ++++++++++++++++++ > 1 file changed, 191 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/nxp,imx8q-vpu.yaml > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8q-vpu.yaml b/Documentation/devicetree/bindings/media/nxp,imx8q-vpu.yaml > new file mode 100644 > index 000000000000..b9e38caf3d10 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/nxp,imx8q-vpu.yaml > @@ -0,0 +1,191 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/nxp,imx8q-vpu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8Q video encode and decode accelerators > + > +maintainers: > + - Ming Qian > + - Shijie Qin > + > +description: |- > + The Amphion MXC video encoder(Windsor) and decoder(Malone) accelerators present > + on NXP i.MX8Q SoCs. > + > +properties: > + $nodename: > + pattern: "^vpu@[0-9a-f]+$" > + > + compatible: > + oneOf: > + - const: nxp,imx8qm-vpu > + - const: nxp,imx8qxp-vpu > + > + reg: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + memory-region: > + description: > + Phandle to a node describing reserved memory used by VPU. > + (see bindings/reserved-memory/reserved-memory.txt) How many? > + > +patternProperties: > + "^mailbox@[0-9a-f]+$": > + description: > + Each vpu encoder or decoder correspond a MU, which used for communication > + between driver and firmware. Implement via mailbox on driver. > + $ref: ../mailbox/fsl,mu.yaml# > + > + > + "^vpu_core@[0-9a-f]+$": > + description: > + Each core correspond a decoder or encoder, need to configure them > + separately. NXP i.MX8QM SoC has one decoder and two encoder, i.MX8QXP SoC > + has one decoder and one encoder. > + type: object > + > + properties: > + compatible: > + oneOf: > + - const: nxp,imx8q-vpu-decoder > + - const: nxp,imx8q-vpu-encoder > + > + reg: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + mbox-names: > + items: > + - const: tx0 > + - const: tx1 > + - const: rx > + > + mboxes: > + description: > + List of phandle of 2 MU channels for tx, 1 MU channel for rx. > + maxItems: 1 > + > + nxp,boot-region: > + description: > + Phandle to a node describing reserved memory used by firmware > + loading. > + $ref: /schemas/types.yaml#/definitions/phandle 'memory-region' is what points to reserved regions. If you have more than one, then you need to define what each index is. > + > + nxp,rpc-region: > + description: > + Phandle to a node describing reserved memory used by RPC shared > + memory between firmware and driver. > + $ref: /schemas/types.yaml#/definitions/phandle > + > + nxp,print-offset: > + description: > + The memory offset from RPC address, used by reserve firmware log. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + required: > + - compatible > + - reg > + - power-domains > + - mbox-names > + - mboxes > + - nxp,boot-region > + - nxp,rpc-region > + - nxp,print-offset > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - power-domains > + - memory-region > + > +additionalProperties: true Nope. 'true' is only acceptible for common bindings. > + > +examples: > + # Device node example for i.MX8QM platform: > + - | > + #include > + > + vpu: vpu@2c000000 { > + compatible = "nxp,imx8qm-vpu"; > + ranges = <0x2c000000 0x2c000000 0x2000000>; > + reg = <0x2c000000 0x1000000>; > + #address-cells = <1>; > + #size-cells = <1>; > + power-domains = <&pd IMX_SC_R_VPU>; > + memory-region = <&vpu_reserved>; > + > + mu_m0: mailbox@2d000000 { > + compatible = "fsl,imx6sx-mu"; > + reg = <0x2d000000 0x20000>; > + interrupts = <0 472 4>; > + #mbox-cells = <2>; > + power-domains = <&pd IMX_SC_R_VPU_MU_0>; > + }; > + > + mu1_m0: mailbox@2d020000 { > + compatible = "fsl,imx6sx-mu"; > + reg = <0x2d020000 0x20000>; > + interrupts = <0 473 4>; > + #mbox-cells = <2>; > + power-domains = <&pd IMX_SC_R_VPU_MU_1>; > + }; > + > + mu2_m0: mailbox@2d040000 { > + compatible = "fsl,imx6sx-mu"; > + reg = <0x2d040000 0x20000>; > + interrupts = <0 474 4>; > + #mbox-cells = <2>; > + power-domains = <&pd IMX_SC_R_VPU_MU_2>; > + }; > + > + vpu_core0: vpu_core@2d080000 { > + compatible = "nxp,imx8q-vpu-decoder"; > + reg = <0x2d080000 0x10000>; > + power-domains = <&pd IMX_SC_R_VPU_DEC_0>; > + mbox-names = "tx0", "tx1", "rx"; > + mboxes = <&mu_m0 0 0 > + &mu_m0 0 1 > + &mu_m0 1 0>; > + nxp,boot-region = <&decoder_boot>; > + nxp,rpc-region = <&decoder_rpc>; > + nxp,print-offset = <0x180000>; > + }; > + > + vpu_core1: vpu_core@2d090000 { > + compatible = "nxp,imx8q-vpu-encoder"; > + reg = <0x2d090000 0x10000>; > + power-domains = <&pd IMX_SC_R_VPU_ENC_0>; > + mbox-names = "tx0", "tx1", "rx"; > + mboxes = <&mu1_m0 0 0 > + &mu1_m0 0 1 > + &mu1_m0 1 0>; > + nxp,boot-region = <&encoder1_boot>; > + nxp,rpc-region = <&encoder1_rpc>; > + nxp,print-offset = <0x80000>; > + }; > + > + vpu_core2: vpu_core@2d0a0000 { > + reg = <0x2d0a0000 0x10000>; > + compatible = "nxp,imx8q-vpu-encoder"; > + power-domains = <&pd IMX_SC_R_VPU_ENC_1>; > + mbox-names = "tx0", "tx1", "rx"; > + mboxes = <&mu2_m0 0 0 > + &mu2_m0 0 1 > + &mu2_m0 1 0>; > + nxp,boot-region = <&encoder2_boot>; > + nxp,rpc-region = <&encoder2_rpc>; > + nxp,print-offset = <0x80000>; > + }; > + }; > + > +... > -- > 2.31.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel