From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2113DC07E96 for ; Thu, 15 Jul 2021 16:31:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6C46613F0 for ; Thu, 15 Jul 2021 16:31:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6C46613F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LFf4yx6vGyharvsc6M2MIdc4W/6sUyPqOBU+Gst/YHI=; b=KyyFICUecf+NZZ PRDi2/IOuMW0dDjSGni+BXlSdiIVZdH0rUSLX0WAsNtiro2+9or6Wlq+JqQUzyO0W2NGw21rZYVtZ xaNKR6GXL4kF+s8Aau6Mpp3uAbJAeXqwdw+7UL5s8iDu0NtAoL9MfXHgSoIA23fsBWMiEIBYxJ8xT GZfWQHXV9LDTyTSbF91rNn4VJ2iUyFzLu1bOrebi4LInKICTbyQS649kaKpkIotVaAJWd3L9ceTUJ cy+rllBAqELXiQyu3FtOHF8eQWbD520W+60j80yQZvTN9Jf/kHwxKH7EXO6esPT2GbPalBS9vTM3U x3eSYURqxve0HCJTLrxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m44EF-001LUd-5k; Thu, 15 Jul 2021 16:28:51 +0000 Received: from mail-io1-f49.google.com ([209.85.166.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m44EA-001LTl-UJ for linux-arm-kernel@lists.infradead.org; Thu, 15 Jul 2021 16:28:48 +0000 Received: by mail-io1-f49.google.com with SMTP id l18so7148794iow.4 for ; Thu, 15 Jul 2021 09:28:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DU/pjsNZXYd/mflQi0Kfu+Fvn8JWm+lHh6CuqP6iNvc=; b=mjpLP/9sI7psgm5FE/N7wDEGK/YY4+IjSEKSYFBsJvuv703HwKGOw1LA+S+4Qw03MA bWv4/D8jBUhOY8mzrjygy/cWADEZE0DDB0OSCisQUsIb3t+dQFZBP+SvNkGNyzyph4XQ 0+lYcBXgYyry7ddQj3AALGIaQnCq6sQnW0jRkuu0KvspbMcUxUuhiMAHhRiphMr1j5vs UfZpGfWL8eY7EMFY0WKPoFdh3WK2ympHs6p9kMEYy+O2QxutfJUlBB8pXFQ4MliJbd1v qJg1McOuSHtMavJ82tWI5CyM5aE7J46MbxsTX+zFdmdigIgHiZ1fJsGsIx0E5X3sLBNq QmSw== X-Gm-Message-State: AOAM530iNvH1ZSh+kF78+5n2BzcHJUqMqZq39chjN+Mw4urwqZRcZLeP 8NvgSLDehIr5f7xtyytQ+A== X-Google-Smtp-Source: ABdhPJyfCdrhjQU34aG9qE+M9t/V6VN32ihTfjbCf3Coc++/H9jqzMpmnWxNQkGbjUo/KkWnF+pVcw== X-Received: by 2002:a6b:4e02:: with SMTP id c2mr3883015iob.166.1626366526415; Thu, 15 Jul 2021 09:28:46 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id a11sm3368502ilf.79.2021.07.15.09.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 09:28:45 -0700 (PDT) Received: (nullmailer pid 1194569 invoked by uid 1000); Thu, 15 Jul 2021 16:28:40 -0000 Date: Thu, 15 Jul 2021 10:28:40 -0600 From: Rob Herring To: Iwona Winiarska Cc: linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, x86@kernel.org, devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , Jean Delvare , Guenter Roeck , Jonathan Corbet , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , Borislav Petkov , Yazen Ghannam , Mauro Carvalho Chehab , Pierre-Louis Bossart , Tony Luck , Andy Shevchenko , Jae Hyun Yoo Subject: Re: [PATCH 04/14] dt-bindings: Add bindings for peci-aspeed Message-ID: <20210715162840.GA1187226@robh.at.kernel.org> References: <20210712220447.957418-1-iwona.winiarska@intel.com> <20210712220447.957418-5-iwona.winiarska@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210712220447.957418-5-iwona.winiarska@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210715_092847_029413_EADA8EAC X-CRM114-Status: GOOD ( 24.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 13, 2021 at 12:04:37AM +0200, Iwona Winiarska wrote: > Add device tree bindings for the peci-aspeed controller driver. > > Co-developed-by: Jae Hyun Yoo > Signed-off-by: Jae Hyun Yoo > Signed-off-by: Iwona Winiarska > --- > .../devicetree/bindings/peci/peci-aspeed.yaml | 111 ++++++++++++++++++ > 1 file changed, 111 insertions(+) > create mode 100644 Documentation/devicetree/bindings/peci/peci-aspeed.yaml > > diff --git a/Documentation/devicetree/bindings/peci/peci-aspeed.yaml b/Documentation/devicetree/bindings/peci/peci-aspeed.yaml > new file mode 100644 > index 000000000000..6061e06009fb > --- /dev/null > +++ b/Documentation/devicetree/bindings/peci/peci-aspeed.yaml > @@ -0,0 +1,111 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/peci/peci-aspeed.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aspeed PECI Bus Device Tree Bindings > + > +maintainers: > + - Iwona Winiarska > + - Jae Hyun Yoo > + > +allOf: > + - $ref: peci-controller.yaml# > + > +properties: > + compatible: > + enum: > + - aspeed,ast2400-peci > + - aspeed,ast2500-peci > + - aspeed,ast2600-peci > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + description: | > + Clock source for PECI controller. Should reference the external > + oscillator clock. > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + clock-divider: > + description: This value determines PECI controller internal clock > + dividing rate. The divider will be calculated as 2 raised to the > + power of the given value. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 7 > + default: 0 > + > + msg-timing: > + description: | > + Message timing negotiation period. This value will determine the period > + of message timing negotiation to be issued by PECI controller. The unit > + of the programmed value is four times of PECI clock period. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 255 > + default: 1 > + > + addr-timing: > + description: | > + Address timing negotiation period. This value will determine the period > + of address timing negotiation to be issued by PECI controller. The unit > + of the programmed value is four times of PECI clock period. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 255 > + default: 1 > + > + rd-sampling-point: > + description: | > + Read sampling point selection. The whole period of a bit time will be > + divided into 16 time frames. This value will determine the time frame > + in which the controller will sample PECI signal for data read back. > + Usually in the middle of a bit time is the best. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 15 > + default: 8 > + > + cmd-timeout-ms: > + description: | > + Command timeout in units of ms. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 1000 > + default: 1000 Are all of these properties common for PECI or specific to this controller? The former needs to go into the common schema. The latter need vendor prefixes. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - resets > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + peci-controller@1e78b000 { > + compatible = "aspeed,ast2600-peci"; > + reg = <0x1e78b000 0x100>; > + interrupts = ; > + clocks = <&syscon ASPEED_CLK_GATE_REF0CLK>; > + resets = <&syscon ASPEED_RESET_PECI>; > + clock-divider = <0>; > + msg-timing = <1>; > + addr-timing = <1>; > + rd-sampling-point = <8>; > + cmd-timeout-ms = <1000>; > + }; > +... > -- > 2.31.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel