From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A351C07E96 for ; Thu, 15 Jul 2021 16:33:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22420613F0 for ; Thu, 15 Jul 2021 16:33:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22420613F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RnMlldmaDoClGPIy7xJBBvTe2pc8BnC8hlJG4LujuGY=; b=zs6H9QdEQmPiCb KK2u9UdstxO/WBLSWVxvzK6mj9YRhx23jicG0oSB/EJr1v4q7icx806Mf62EX1gmfjr71Vhz7KdEy 8ZUSr3gMc/5rwh+OKu0kCrQx80JEqalt1zgkjIXHer+ATUbA0VEqdo+8Y5wMKT0M9YLrvq71LvDN1 TEp3KopX1cTr/dpSlKuj/VyYmwTD1I3edt+sfkrTa6HywXjY2etJFeCw9MJBHFHb+NhfC+JvHrtcZ FjLGNAl2EYOPmOYD5NW2K6YeoxfTFVvb22mY4qhbYKRA7VYjsS5b0xTC1vwoaJqAUY7XQ2NKx0vHe T8YZZsAR9QSv+V6tkMig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m44Gs-001MEh-MB; Thu, 15 Jul 2021 16:31:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m44Gn-001MCs-QR for linux-arm-kernel@lists.infradead.org; Thu, 15 Jul 2021 16:31:31 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A2486613F0; Thu, 15 Jul 2021 16:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626366689; bh=kNwNkHWVRlL9o2aS1QzB7BFjO7ooHM5sYMqHihEc2Jw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=In5D7b/Ll4sT4t3FsDbc4UycKCAOgHbFqn1eGgx+IaN7Nr6V+yGg9b5yvBy4Yu1it zO4/TPVkYYKttihj7kQNe1tSvQKTQ9/wUbQ5YeOhjYHFuoXCszLjudlGhchpzTguHF 2tfO1CpwCCQ4Xp/NWY2JI1XAeGGfVG/+Ed7Gxh8gNk3xXOCKFawBja57ePdPnnWdZr ETDAf8pMDgL7FdILnZNrsKlqzWJRwP7DJuPzKCi1w1b0XB5HUKVoSgSPeOwgG/QOqi AAtKb6DdB5UiIue7b3Eo+v5Xt4+GrqZ3nZEyVfZjK5Fh42f6kGazvyonkcSY0TbzuU nqNcGy/4Ub+3Q== Date: Thu, 15 Jul 2021 17:31:25 +0100 From: Will Deacon To: Shaokun Zhang Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Marc Zyngier Subject: Re: [PATCH] arm64: cpufeature: Use defined macro instead of magic numbers Message-ID: <20210715163124.GB1330@willie-the-truck> References: <1626243183-32937-1-git-send-email-zhangshaokun@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1626243183-32937-1-git-send-email-zhangshaokun@hisilicon.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210715_093129_903903_C39DF1A0 X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 14, 2021 at 02:13:03PM +0800, Shaokun Zhang wrote: > Macro 'CLIDR_LOUU_SHIFT' and 'CLIDR_LOUIS_SHIFT' are defined, so use > these to replace the magic numbers. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Signed-off-by: Shaokun Zhang > --- > arch/arm64/kernel/cpufeature.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 125d5c9471ac..4ee3496bcff8 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -1733,7 +1733,7 @@ static void cpu_has_fwb(const struct arm64_cpu_capabilities *__unused) > u64 val = read_sysreg_s(SYS_CLIDR_EL1); > > /* Check that CLIDR_EL1.LOU{U,IS} are both 0 */ > - WARN_ON(val & (7 << 27 | 7 << 21)); > + WARN_ON(val & (7 << CLIDR_LOUU_SHIFT | 7 << CLIDR_LOUIS_SHIFT)); > } I think this would be even better as: WARN_ON(CLIDR_LOUU(val) || CLIDR_LOUIS(val)); Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel