From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F225AC07E95 for ; Fri, 16 Jul 2021 13:39:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFD1161001 for ; Fri, 16 Jul 2021 13:39:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFD1161001 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KZ+tBwUZKEdWRMlemscykKMJ+wg759aXUPGgoCGw62I=; b=FXdWxNLcJHK9UW OuL0tY9NwB6andrEXUFK2db0wamjj1T5ApmLftP3X2996aj2h+zQd1sk7m3NeHLPZUPHeqF8QhSWf FcDJHkllkS6UdB8ra5eOa8JgUKg+UcMjqhgeLD8xvoAh0s4z584X0ms3l723UkEC+De14SX3wbclC yzAJ/ateQVe3LTavBpp/3A6YJ2gVgWHO297T5pa2Bf7FqZitdv/IGyXHvXLotLJXG5UVMeU9xYoiL lMfXd1E4s991h9CwF4mRZybIn7ifQSq/XJLZU5qeBF5b9FnrDVscFpdljxNHAtc4Zhvw69bOzJF+J LEsTcFpKsp6gwy+9fAbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4O2V-004Utp-Bs; Fri, 16 Jul 2021 13:38:03 +0000 Received: from mail-vs1-xe35.google.com ([2607:f8b0:4864:20::e35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4O25-004UnE-Hr for linux-arm-kernel@lists.infradead.org; Fri, 16 Jul 2021 13:37:38 +0000 Received: by mail-vs1-xe35.google.com with SMTP id a66so4990148vsd.10 for ; Fri, 16 Jul 2021 06:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kik/mXU4khOLPHjSUQV5RBOw87HL5ZNvFNtK8f6lYqo=; b=rfEsv5IDoF4NeJSYoGhwsZ+JeZIprJwc7qlm4gmDeKPMKY/zE8WZwq/qiRVuVqqFOY s7qX9unUxTmri9NOjgiTK1vxnujwNzGBe+7hd2Q0M9FgsTDblPLwdMmtmB3Ii7jOD8+3 z45doXLX+Sf/NNwKLvySRd500nOuigsU2f0DLiViQQNFjKyEk5FYPK+KXBg0s4sVha5D yVGGSI9NEe+EiBkjr4T0RaFkLY9KCwIyIDTvPgF3t05sERqMDv3Rcx3JzUUPyR//+s+k UxT54sgwK2yC2Ry6BzSpKBONXeN6EOudcEw36EsxI6SW+QbqmQFbY5jnkLvbsfEQZCQc IXuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kik/mXU4khOLPHjSUQV5RBOw87HL5ZNvFNtK8f6lYqo=; b=o+ujp9Gc4963bJ+D4lZF5BgnTbRd0JSBpFxK5EchpDuE+QW1ESijPUKP2KqAdDEgpA gmTqDQZF8pQY1DyfDGuag8n7QXyEvHfoAoRQymXkcdVxtB96uErRlr9dYHc1/Rw9cknY e6ZhazGnJN2pf7wbyqP0U9eKZpbwh7oIVtawK97kjZRAEXAMtI6YlsSLNbqIjbCFDi2U DWUOmNFCpo9U8sJPryHV7N/F441AdmRxsrOjJCDQcv34Cwk6+dcctA+CuJTVHA8Veg/s U/wnnUAlb4ZH45nO5qCtj2ogXVtOhnxIvbKKf77441cSSLhvk3XD9tmYUFkXLgGxkTF4 P8GQ== X-Gm-Message-State: AOAM531rG4u5vtyW4ZEU6UxZ7GbH5pwVcW/dcg38QpBOOkLglhYzcCT0 PHRdn8y4t2Draoi5j14zjx4= X-Google-Smtp-Source: ABdhPJxc1+bUvUnqwpqN3VxUgaMV7SuDvuhS4kgAEudVMX5mP1tH+X0B15Luyts4OJE8++3wLrgoTQ== X-Received: by 2002:a67:87c6:: with SMTP id j189mr12337994vsd.0.1626442656838; Fri, 16 Jul 2021 06:37:36 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:485:504a:9f0b:cb12:835a:e9f9]) by smtp.gmail.com with ESMTPSA id 184sm1352572vks.33.2021.07.16.06.37.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 06:37:36 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Cc: linux-arm-kernel@lists.infradead.org, o.rempel@pengutronix.de, Markus.Niebel@tq-group.com, Fabio Estevam Subject: [PATCH 3/4] ARM: dts: imx6qdl-tqma6: Fix the SPI chipselect polarity Date: Fri, 16 Jul 2021 10:36:58 -0300 Message-Id: <20210716133659.3372047-3-festevam@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210716133659.3372047-1-festevam@gmail.com> References: <20210716133659.3372047-1-festevam@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_063737_655515_5C20899B X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The conversion of the spi-imx driver to use GPIO descriptors in commit 8cdcd8aeee28 ("spi: imx/fsl-lpspi: Convert to GPIO descriptors") helped to detect the following SPI chipselect polarity mismatch on an imx6q-sabresd for example: [ 4.854337] m25p80@0 enforce active low on chipselect handle Prior to the above commit, the chipselect polarity passed via cs-gpios property was ignored and considered active-low. The reason for such mismatch is clearly explained in the comments inside drivers/gpio/gpiolib-of.c: * SPI children have active low chip selects * by default. This can be specified negatively * by just omitting "spi-cs-high" in the * device node, or actively by tagging on * GPIO_ACTIVE_LOW as flag in the device * tree. If the line is simultaneously * tagged as active low in the device tree * and has the "spi-cs-high" set, we get a * conflict and the "spi-cs-high" flag will * take precedence. To properly represent the SPI chipselect polarity, change it to active-low when the "spi-cs-high" property is absent. Signed-off-by: Fabio Estevam --- arch/arm/boot/dts/imx6qdl-tqma6.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi index b18b83ac6aee..51a3a5392c95 100644 --- a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi +++ b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi @@ -20,7 +20,7 @@ reg_3p3v: regulator-3p3v { &ecspi1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_ecspi1>; - cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>; + cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>; status = "okay"; m25p80: flash@0 { -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel