From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B07C7C636C9 for ; Sat, 17 Jul 2021 15:43:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70F6B61159 for ; Sat, 17 Jul 2021 15:43:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70F6B61159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gGvLro1fd84rgOCZvFGmMi77PFtXY+HcgV9qdzIZ4kM=; b=erqAsFLP5LYRfT H5U1yjedVfmQAErVSU0dIxeUEiw/dLwAvfShe5prT0Hq3McmnFAiQhPMzDZqML81NeHi+f/iunP9v Y7rXPrr5e/odbwLV+uKwBeEyCx7FQiLeTI6alyPMw/1M7wgyw6338dpMLzgaArW67bVybVc34hCCH aSrNEtBY2YWefvLgUNyFdU1dmS2EwACvKBc7wrKJkmgrOOaXN0Vn8B2/6VBOYS70F54Uns5YcoASK ZUrB+ZN0S+KDVIVBNnSpH4qzN5h94JXRUzNBDdXewWhSMyRT3ZHYFs9kqm2yA02FAPfeVZyb78JW/ pAcbphdG01Wzpx8mNh1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4mRp-006lpj-P9; Sat, 17 Jul 2021 15:41:49 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4mRl-006lp3-54; Sat, 17 Jul 2021 15:41:46 +0000 Received: by mail-pg1-x52e.google.com with SMTP id y17so13304828pgf.12; Sat, 17 Jul 2021 08:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=joQ8gEeTx6Yiij5UFZWM2uMjNke7wP9TlqjIUNge51M=; b=d8CLmdnIzEpfIgHQZ3lctgsM+Ll9uXpCnw6FK8u2FvmNaciwfEqcae8VPqK0UBwWBT F/Tfv2WucvBot95eTUkTEqmM21hV51mCirP2RFQ4dj6i8K/riP6i2VvEpbGErMYtg45C MNt2UeRF3x6E0waatVGUyOIl2ay7K0zDZ/h8SHgzEXsERFSjs+1vGXQHAp1+E0REdbhK nG/dy11kVfvqCagWSYon64fGT2Hvyz92qk4p3jSiyMaickRqyfdD9ph/r7O/yr+jq7+E V3ATxNSj3HTkqckg1jYB/ftOxO1j5MFb+DJaw0NApKBclLYp91uC+YheWkPYu3JWvgyK RceA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=joQ8gEeTx6Yiij5UFZWM2uMjNke7wP9TlqjIUNge51M=; b=ILb/myBqHpY+HboIihlEAV4lEzPjAp06rz+UIhIyJYrYBqFc+PbGUtdsZsi+NJA4A0 Y3E7s7HDxHzE1uM24XfxS9DoH6ddmBkJKuWA/1OaAXcF2RYWpDICRO64jraB71PWXh+T 5xCodPMS/vLUueD/5TozcdxR5b34l19ptHMr158mBRv0nLL7FTp+affTA89XUOKMFCIk YpIzrlc6C4eCOKHWQmx+m/CC0/cbQ8h0wIJK0J04SSEXpod1MN9BrISUPHO2CEjNPbnY G/6EJYgsYa7oR9Au97NMrXyl9Q3Lp2XMR17pvXmuwaopMVIHGoYYVF5r86RL56NjwDRO GuCQ== X-Gm-Message-State: AOAM5304akLh8srczPkWr3TOLXhUGckiYGy8inbN7Ph17WdWTE+xietf 6T1BgLnqKDlYP341LPNQlD4= X-Google-Smtp-Source: ABdhPJzpED/z+AzlaCHgvYtysgYgXl0cEeH9cNxEg30LHu8mqrynywd7fdi9wIVfeMVwiYHoKA1EWg== X-Received: by 2002:a63:d74c:: with SMTP id w12mr15631066pgi.91.1626536501212; Sat, 17 Jul 2021 08:41:41 -0700 (PDT) Received: from haswell-ubuntu20.lan ([138.197.212.246]) by smtp.gmail.com with ESMTPSA id m13sm13461930pfc.119.2021.07.17.08.41.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jul 2021 08:41:40 -0700 (PDT) From: DENG Qingfang To: Eric Woudstra Cc: Vladimir Oltean , Sean Wang , Landen Chao , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Wunderlich Subject: Re: [PATCH] mt7530 fix mt7530_fdb_write vid missing ivl bit Date: Sat, 17 Jul 2021 23:41:31 +0800 Message-Id: <20210717154131.82657-1-dqfext@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: <20210716153641.4678-1-ericwouds@gmail.com> <20210716210655.i5hxcwau5tdq4zhb@skbuf> MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210717_084145_242913_13466196 X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 17, 2021 at 10:09:53AM +0200, Eric Woudstra wrote: > > You are right now there is a problem with vlan unaware bridge. > > We need to change the line to: > > if (vid > 1) reg[1] |= ATA2_IVL; Does it not work with vid 1? > > I have just tested this with a vlan unaware bridge and also with vlan bridge option disabled in the kernel. Only after applying the if statement it works for vlan unaware bridges/kernel. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel