From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF527C636C9 for ; Mon, 19 Jul 2021 09:17:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7A4761026 for ; Mon, 19 Jul 2021 09:17:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7A4761026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mSUWB9kbFVNjlDcGM6rH+6Y2vpVef5HkIEbYcXpliE4=; b=DSvxnz4IJJ6cru 4tiQFFDDQ57QwxcqeodiQZ+Xx+FM0GB2Cj57P89gQiLFoa0DHqa/QUIFk+3xPOWshxpDs4cGJlbGg kBVuxSUYrTX08W6c58Rn2e45AlagOYpHY+cEcFIPSC/UA1YiljTrLbwED7L3VVGxf6nNkPriJRc95 fHfQlc74su4hepNZHd83wK6WSNAqC7NdtZE3vmuPwtotpHOpNzoqOL4tyGuSEqU/vvN1OspfbuUNJ 0mY5ONtNVi0xlwouiOnya4diYVdUDbi/p6sds+YtUHYGChtjVIIy+htAO/6ADqMuFj6fxgZ4sm0es GBS+DF2giNIvXVHZ5qug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5PNP-0092Ko-5R; Mon, 19 Jul 2021 09:15:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5PNL-0092Jl-C4 for linux-arm-kernel@lists.infradead.org; Mon, 19 Jul 2021 09:15:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 641126D; Mon, 19 Jul 2021 02:15:45 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5BF923F73D; Mon, 19 Jul 2021 02:15:42 -0700 (PDT) Date: Mon, 19 Jul 2021 10:15:35 +0100 From: Cristian Marussi To: Peter Hilber Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com Subject: Re: [PATCH v6 10/17] firmware: arm_scmi: Make polling mode optional Message-ID: <20210719091535.GG49078@e120937-lin> References: <20210712141833.6628-1-cristian.marussi@arm.com> <20210712141833.6628-11-cristian.marussi@arm.com> <4ad5a421-d9ab-816f-b721-9f88ffabfb39@opensynergy.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4ad5a421-d9ab-816f-b721-9f88ffabfb39@opensynergy.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210719_021547_570416_B937D147 X-CRM114-Status: GOOD ( 22.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 15, 2021 at 06:36:10PM +0200, Peter Hilber wrote: > On 12.07.21 16:18, Cristian Marussi wrote: > > Add a check for the presence of .poll_done transport operation so that > > transports that do not need to support polling mode have no need to provide > > a dummy .poll_done callback either and polling mode can be disabled in the > > SCMI core for that tranport. > > > > Signed-off-by: Cristian Marussi > > --- > > drivers/firmware/arm_scmi/driver.c | 43 ++++++++++++++++++------------ > > 1 file changed, 26 insertions(+), 17 deletions(-) > > > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > > index a952b6527b8a..4183d25c9289 100644 > > --- a/drivers/firmware/arm_scmi/driver.c > > +++ b/drivers/firmware/arm_scmi/driver.c > > @@ -777,25 +777,34 @@ static int do_xfer(const struct scmi_protocol_handle *ph, > > } > > if (xfer->hdr.poll_completion) { > > - ktime_t stop = ktime_add_ns(ktime_get(), SCMI_MAX_POLL_TO_NS); > > - > > - spin_until_cond(scmi_xfer_done_no_timeout(cinfo, xfer, stop)); > > - > > - if (ktime_before(ktime_get(), stop)) { > > - unsigned long flags; > > - > > - /* > > - * Do not fetch_response if an out-of-order delayed > > - * response is being processed. > > - */ > > - spin_lock_irqsave(&xfer->lock, flags); > > - if (xfer->state == SCMI_XFER_SENT_OK) { > > - info->desc->ops->fetch_response(cinfo, xfer); > > - xfer->state = SCMI_XFER_RESP_OK; > > + if (info->desc->ops->poll_done) { > > + ktime_t stop = ktime_add_ns(ktime_get(), > > + SCMI_MAX_POLL_TO_NS); > > + > > + spin_until_cond(scmi_xfer_done_no_timeout(cinfo, xfer, > > + stop)); > > + > > + if (ktime_before(ktime_get(), stop)) { > > + unsigned long flags; > > + > > + /* > > + * Do not fetch_response if an out-of-order delayed > > + * response is being processed. > > + */ > > + spin_lock_irqsave(&xfer->lock, flags); > > + if (xfer->state == SCMI_XFER_SENT_OK) { > > + info->desc->ops->fetch_response(cinfo, > > + xfer); > > + xfer->state = SCMI_XFER_RESP_OK; > > + } > > + spin_unlock_irqrestore(&xfer->lock, flags); > > + } else { > > + ret = -ETIMEDOUT; > > } > > - spin_unlock_irqrestore(&xfer->lock, flags); > > } else { > > - ret = -ETIMEDOUT; > > + dev_warn_once(dev, > > + "Polling mode is not supported by transport.\n"); > > + ret = EINVAL; > > s/EINVAL/-EINVAL Ah. Right. I'll fix. Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel