From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00A4CC07E9D for ; Mon, 19 Jul 2021 10:09:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C626F610FB for ; Mon, 19 Jul 2021 10:08:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C626F610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ymCKjk5caHyE+3BhPLCvbaCHRGUNK7f0xEwgcJnktQk=; b=5F60LEF32wjYnJ 13E3122yagNJ1nh7MXfqLzsmvlwVBka72K7b2BJWjSzICopSkW93iI369TvbV4Q/KYQKcvsSyonc1 tFwCHBwDtQo1GxqLodCRyizn2/7ctFMyoRZwp/+yW8zDFiVPN4gErJa3II8C+bBdBst4+aWmYv5Ap 9PCTMCmlSbRi9LXgzhEHj/cjMNiOMNX6W/LuaeBhImhnPGQfJCuHYqSBhi3uGPAAusojS6oEfwbKh RJbdt/BHmjLpIn85ei7603zbD5sVekmifLr5OxSzRfqdVTjiDHUihpaB6UbDsflQ4HbgkuMhVzMSj XdRSQgTRV9VCetiul1+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5QAy-009CAK-2f; Mon, 19 Jul 2021 10:07:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5QAW-009C36-Mo for linux-arm-kernel@lists.infradead.org; Mon, 19 Jul 2021 10:06:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A46146D; Mon, 19 Jul 2021 03:06:34 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 53A513F73D; Mon, 19 Jul 2021 03:06:33 -0700 (PDT) Date: Mon, 19 Jul 2021 11:05:16 +0100 From: Dave Martin To: Mark Brown Cc: Catalin Marinas , Will Deacon , Szabolcs Nagy , Jeremy Linton , "H . J . Lu" , Yu-cheng Yu , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, libc-alpha@sourceware.org Subject: Re: [PATCH v4 3/4] elf: Remove has_interp property from arch_adjust_elf_prot() Message-ID: <20210719100516.GV4187@arm.com> References: <20210712115259.29547-1-broonie@kernel.org> <20210712115259.29547-4-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210712115259.29547-4-broonie@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210719_030636_855449_80FA568E X-CRM114-Status: GOOD ( 20.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 12, 2021 at 12:52:58PM +0100, Mark Brown wrote: > Since we have added an is_interp flag to arch_parse_elf_property() we can > drop the has_interp flag from arch_elf_adjust_prot(), the only user was > the arm64 code which no longer needs it and any future users will be able > to use arch_parse_elf_properties() to determine if an interpreter is in > use. Reviewed-By: Dave Martin > > Signed-off-by: Mark Brown > Tested-by: Jeremy Linton > --- > arch/arm64/kernel/process.c | 2 +- > fs/binfmt_elf.c | 2 +- > include/linux/elf.h | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > index 5a6c3b198bd3..992d827b37b0 100644 > --- a/arch/arm64/kernel/process.c > +++ b/arch/arm64/kernel/process.c > @@ -693,7 +693,7 @@ static inline int arm64_elf_bti_flag(bool is_interp) > > > int arch_elf_adjust_prot(int prot, const struct arch_elf_state *state, > - bool has_interp, bool is_interp) > + bool is_interp) > { > if ((prot & PROT_EXEC) && > (state->flags & arm64_elf_bti_flag(is_interp))) > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index 81e151a57df2..ae8094d42480 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -580,7 +580,7 @@ static inline int make_prot(u32 p_flags, struct arch_elf_state *arch_state, > if (p_flags & PF_X) > prot |= PROT_EXEC; > > - return arch_elf_adjust_prot(prot, arch_state, has_interp, is_interp); > + return arch_elf_adjust_prot(prot, arch_state, is_interp); > } > > /* This is much more generalized than the library routine read function, > diff --git a/include/linux/elf.h b/include/linux/elf.h > index 1c45ecf29147..d8392531899d 100644 > --- a/include/linux/elf.h > +++ b/include/linux/elf.h > @@ -101,11 +101,11 @@ extern int arch_parse_elf_property(u32 type, const void *data, size_t datasz, > > #ifdef CONFIG_ARCH_HAVE_ELF_PROT > int arch_elf_adjust_prot(int prot, const struct arch_elf_state *state, > - bool has_interp, bool is_interp); > + bool is_interp); > #else > static inline int arch_elf_adjust_prot(int prot, > const struct arch_elf_state *state, > - bool has_interp, bool is_interp) > + bool is_interp) > { > return prot; > } > -- > 2.20.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel