From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B74C07E9D for ; Mon, 19 Jul 2021 10:09:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1470C610F7 for ; Mon, 19 Jul 2021 10:09:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1470C610F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I0ocQccsxrcTK+E0pc7l0ANkxL9tQOCQkESYpeLwmO4=; b=J3RNHNt+QNqkN2 rsAKjzGFfS7W+l3gC8R3CBlTiJkX+ByG1BPHNdpv0qJsaWiB95fnpjxje/jXbKpSUyUSnyg0zU705 T/buFaDEjX357kMY0fmfd972CrOgppCc+mruX+wQm/3Nhb2qSnWA7Zx7jIse7l7ogcvnWl7PPM2VE S5YjH9jwE+Oc1iUANgOYE/C8Z3w7rz8n3FTw+06gdkrqJxSePXj825HHnNSnpAnrsNdRammMXyKQg x6MJ94C6IYa0lTPy/ThsmLw7LH2WB4tf1M6M5cb3CrIWWqPbsyhQFERCjf2RCH5tkUr7+snjZZ0el UhGyJZYtAW1myIEEkyBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5QBJ-009CHp-83; Mon, 19 Jul 2021 10:07:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5QAf-009C5q-IY for linux-arm-kernel@lists.infradead.org; Mon, 19 Jul 2021 10:06:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F42E6D; Mon, 19 Jul 2021 03:06:44 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E0803F73D; Mon, 19 Jul 2021 03:06:43 -0700 (PDT) Date: Mon, 19 Jul 2021 11:05:26 +0100 From: Dave Martin To: Mark Brown Cc: Catalin Marinas , Will Deacon , Szabolcs Nagy , Jeremy Linton , "H . J . Lu" , Yu-cheng Yu , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, libc-alpha@sourceware.org Subject: Re: [PATCH v4 4/4] elf: Remove has_interp property from arch_parse_elf_property() Message-ID: <20210719100526.GW4187@arm.com> References: <20210712115259.29547-1-broonie@kernel.org> <20210712115259.29547-5-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210712115259.29547-5-broonie@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210719_030645_729248_EF88E871 X-CRM114-Status: GOOD ( 19.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 12, 2021 at 12:52:59PM +0100, Mark Brown wrote: > Since all current users of arch_parse_elf_property() are able to treat the > interpreter and main executable orthogonaly the has_interp argument is now > redundant so remove it. Reviewed-by: Dave Martin > > Signed-off-by: Mark Brown > Tested-by: Jeremy Linton > --- > arch/arm64/include/asm/elf.h | 2 +- > fs/binfmt_elf.c | 2 +- > include/linux/elf.h | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h > index 9f86dbce2680..a6e9032b951a 100644 > --- a/arch/arm64/include/asm/elf.h > +++ b/arch/arm64/include/asm/elf.h > @@ -262,7 +262,7 @@ struct arch_elf_state { > > static inline int arch_parse_elf_property(u32 type, const void *data, > size_t datasz, bool compat, > - bool has_interp, bool is_interp, > + bool is_interp, > struct arch_elf_state *arch) > { > /* No known properties for AArch32 yet */ > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index ae8094d42480..f0b3c24215f6 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -753,7 +753,7 @@ static int parse_elf_property(const char *data, size_t *off, size_t datasz, > > ret = arch_parse_elf_property(pr->pr_type, data + o, > pr->pr_datasz, ELF_COMPAT, > - has_interp, is_interp, arch); > + is_interp, arch); > if (ret) > return ret; > > diff --git a/include/linux/elf.h b/include/linux/elf.h > index d8392531899d..cdb080d4b34a 100644 > --- a/include/linux/elf.h > +++ b/include/linux/elf.h > @@ -88,14 +88,14 @@ struct arch_elf_state; > #ifndef CONFIG_ARCH_USE_GNU_PROPERTY > static inline int arch_parse_elf_property(u32 type, const void *data, > size_t datasz, bool compat, > - bool has_interp, bool is_interp, > + bool is_interp, > struct arch_elf_state *arch) > { > return 0; > } > #else > extern int arch_parse_elf_property(u32 type, const void *data, size_t datasz, > - bool compat, bool has_interp, bool is_interp, > + bool compat, bool is_interp, > struct arch_elf_state *arch); > #endif > > -- > 2.20.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel