From: Will Deacon <will@kernel.org>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: Shaokun Zhang <zhangshaokun@hisilicon.com>,
linux-arm-kernel@lists.infradead.org,
Lingyan Huang <huanglingyan2@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH v2] arm64: SSBS/DIT: print SSBS and DIT bit when printing PSTATE
Date: Wed, 21 Jul 2021 11:25:36 +0100 [thread overview]
Message-ID: <20210721102536.GA10216@willie-the-truck> (raw)
In-Reply-To: <b447f904-9db1-c807-135b-e4a1416cc69c@arm.com>
On Wed, Jul 21, 2021 at 09:31:18AM +0100, Vladimir Murzin wrote:
> On 7/21/21 3:43 AM, Shaokun Zhang wrote:
> > From: Lingyan Huang <huanglingyan2@huawei.com>
> >
> > The current code to print PSTATE when generating backtraces does not
> > include SSBS bit and DIT bit, so add this information.
> >
> > Cc: Vladimir Murzin <vladimir.murzin@arm.com>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Will Deacon <will@kernel.org>
> > Signed-off-by: Lingyan Huang <huanglingyan2@huawei.com>
> > Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> > ---
> > ChangeLog:
> > v1-->v2:
> > 1. Address Vladimir's comment on update compat_user_mode
> >
> > arch/arm64/kernel/process.c | 11 ++++++++---
> > 1 file changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
> > index c8989b999250..3da2ad00fa0c 100644
> > --- a/arch/arm64/kernel/process.c
> > +++ b/arch/arm64/kernel/process.c
> > @@ -163,7 +163,7 @@ static void print_pstate(struct pt_regs *regs)
> > u64 pstate = regs->pstate;
> >
> > if (compat_user_mode(regs)) {
> > - printk("pstate: %08llx (%c%c%c%c %c %s %s %c%c%c)\n",
> > + printk("pstate: %08llx (%c%c%c%c %c %s %s %c%c%c %cPAN %cDIT %cSSBS)\n",
> > pstate,
> > pstate & PSR_AA32_N_BIT ? 'N' : 'n',
> > pstate & PSR_AA32_Z_BIT ? 'Z' : 'z',
> > @@ -174,12 +174,15 @@ static void print_pstate(struct pt_regs *regs)
> > pstate & PSR_AA32_E_BIT ? "BE" : "LE",
> > pstate & PSR_AA32_A_BIT ? 'A' : 'a',
> > pstate & PSR_AA32_I_BIT ? 'I' : 'i',
> > - pstate & PSR_AA32_F_BIT ? 'F' : 'f');
> > + pstate & PSR_AA32_F_BIT ? 'F' : 'f',
> > + pstate & PSR_AA32_PAN_BIT ? '+' : '-',
>
> Hmm, commit message doesn't mention PAN bit... but I leave it to maintainers.
Agreed, I don't see the rationale for exposing PAN for 32-bit userspace
tasks. Please drop this part for v3.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-07-21 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 2:43 [PATCH v2] arm64: SSBS/DIT: print SSBS and DIT bit when printing PSTATE Shaokun Zhang
2021-07-21 8:31 ` Vladimir Murzin
2021-07-21 10:25 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721102536.GA10216@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=huanglingyan2@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=vladimir.murzin@arm.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox