Re: [PATCH 52/54] arm64: dts: allwinner: Remove regulator-ramp-delay

Samuel Holland
2021-07-22T05:58:09Z

On 7/21/21 9:04 AM, Maxime Ripard wrote:
> The regulator-ramp-delay property isn't documented in the binding for
> the AXP806, and it's ignored by the driver. Remove those properties.

This is a generic regulator property, parsed by
of_get_regulation_constraints, which is called by
regulator_of_get_init_data in the regulator core. And it appears in
bindings/regulator/regulator.yaml. I believe the binding needs to be
fixed, not the device trees.

Regards,
Samuel

> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 2 --
> arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts | 2 --
> arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 2 --
> 3 files changed, 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> index 6249e9e02928..a02644eebbe4 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> @@ -256,7 +256,6 @@ reg_dcdca: dcdca {
> regulator-always-on;
> regulator-min-microvolt = <810000>;
> regulator-max-microvolt = <1160000>;
> - regulator-ramp-delay = <2500>;
> regulator-name = "vdd-cpu";
> };
>
> @@ -264,7 +263,6 @@ reg_dcdcc: dcdcc {
> regulator-enable-ramp-delay = <32000>;
> regulator-min-microvolt = <810000>;
> regulator-max-microvolt = <1080000>;
> - regulator-ramp-delay = <2500>;
> regulator-name = "vdd-gpu";
> };
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
> index c45d7b7fb39a..69c0293aeb16 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
> @@ -262,7 +262,6 @@ reg_dcdca: dcdca {
> regulator-always-on;
> regulator-min-microvolt = <800000>;
> regulator-max-microvolt = <1160000>;
> - regulator-ramp-delay = <2500>;
> regulator-name = "vdd-cpu";
> };
>
> @@ -270,7 +269,6 @@ reg_dcdcc: dcdcc {
> regulator-enable-ramp-delay = <32000>;
> regulator-min-microvolt = <810000>;
> regulator-max-microvolt = <1080000>;
> - regulator-ramp-delay = <2500>;
> regulator-name = "vdd-gpu";
> };
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> index 1ffd68f43f87..6a1ee4232675 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> @@ -245,7 +245,6 @@ reg_dcdca: dcdca {
> regulator-always-on;
> regulator-min-microvolt = <810000>;
> regulator-max-microvolt = <1160000>;
> - regulator-ramp-delay = <2500>;
> regulator-name = "vdd-cpu";
> };
>
> @@ -253,7 +252,6 @@ reg_dcdcc: dcdcc {
> regulator-enable-ramp-delay = <32000>;
> regulator-min-microvolt = <810000>;
> regulator-max-microvolt = <1080000>;
> - regulator-ramp-delay = <2500>;
> regulator-name = "vdd-gpu";
> };