Re: [PATCH 24/54] dt-bindings: mfd: Convert X-Powers AXP binding to a schema

Rob Herring
2021-07-22T02:12:47Z

On Wed, 21 Jul 2021 16:03:54 +0200, Maxime Ripard wrote:
> The X-Powers AXP PMICs are supported by Linux thanks to its device tree
> binding.
>
> Now that we have the DT validation in place, let's convert the device
> tree bindings for that driver over to a YAML schema.
>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> .../devicetree/bindings/mfd/axp20x.txt | 272 -------------
> .../bindings/mfd/x-powers,axp152.yaml | 381 ++++++++++++++++++
> 2 files changed, 381 insertions(+), 272 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/axp20x.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/gpio/x-powers,axp209-gpio.yaml'
xargs: dt-doc-validate: exited with status 255; aborting
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.example.dt.yaml: pmic@68: '#interrupt-cells' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.example.dt.yaml: pmic@68: 'interrupt-controller' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.example.dt.yaml: pmic@68: 'oneOf' conditional failed, one must be fixed:
'interrupts' is a required property
'interrupts-extended' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
make[1]: *** Deleting file 'Documentation/devicetree/bindings/mfd/x-powers,axp152.example.dt.yaml'
Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/gpio/x-powers,axp209-gpio.yaml'
make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/mfd/x-powers,axp152.example.dt.yaml] Error 255
make: *** [Makefile:1418: dt_binding_check] Error 2
\ndoc reference errors (make refcheckdocs):
Documentation/devicetree/bindings/gpio/gpio-axp209.txt: Documentation/devicetree/bindings/mfd/axp20x.txt

See https://patchwork.ozlabs.org/patch/1508269

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.