Re: [PATCH 01/54] ASoC: dt-bindings: Add WM8978 Binding

Rob Herring
2021-07-23T21:34:56Z

On Wed, Jul 21, 2021 at 04:03:31PM +0200, Maxime Ripard wrote:
> Even though we had the wm8978 driver for some time and a number of
> boards using it already, we never had a binding for it. Let's add it
> based on what the driver expects and the boards are providing.
>
> Cc: alsa-devel@alsa-project.org
> Cc: devicetree@vger.kernel.org
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> .../devicetree/bindings/sound/wlf,wm8978.yaml | 58 +++++++++++++++++++
> 1 file changed, 58 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
> new file mode 100644
> index 000000000000..6761380261e3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/wlf,wm8978.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Wolfson WM8978 Codec Device Tree Bindings
> +
> +maintainers:
> + - Mark Brown <broonie@kernel.org>

No one from Wolfson cares about this device?

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

> +
> +properties:
> + '#sound-dai-cells':
> + const: 0
> +
> + compatible:
> + const: wlf,wm8978
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 526000
> +
> +required:
> + - '#sound-dai-cells'
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + codec@0 {
> + #sound-dai-cells = <0>;
> + compatible = "wlf,wm8978";
> + reg = <0>;
> + spi-max-frequency = <500000>;
> + };
> + };
> +
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + codec@0 {
> + #sound-dai-cells = <0>;
> + compatible = "wlf,wm8978";
> + reg = <0>;
> + };
> + };
> +
> +...
> --
> 2.31.1