From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE57C6377B for ; Wed, 21 Jul 2021 21:19:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CFF6611C1 for ; Wed, 21 Jul 2021 21:19:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CFF6611C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B+mR9hSylnBBYpaIOQyzt7sTi57Fr99wECFdZfXGbUc=; b=KWds8uupWwTYih 277Tb4uE6ydD8TgWZOLjjGRYTxrbK2VRdZie/S2zBKD7bl0MCDhNGejbuHWl7lnyW+DtcbEq6YHUD UggCYcj/CeniCYLNXUTmT1XipucIHbIsZvBOa/nsdew6t5RxEzs5ms0qQ7SQ0UJphljkWOPVW4ufo hSPyvY4M0wQpj45kbx4pyUIChETQmNHqGh8Y9e4U8Fm85HgU8ZBTnMoTXXf84eqmbRYQNTa6SpoeH zsahehdOUqPIIO/LMSK/oJGi0gYsBeIbKt8HR8YNUx6xUajWldaSbUtjZWPBu7jcwZih3m2G8m556 rOpL5fLfKLRDkH6svnqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6JbG-00HHw3-GL; Wed, 21 Jul 2021 21:17:54 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6JbC-00HHuv-Km for linux-arm-kernel@lists.infradead.org; Wed, 21 Jul 2021 21:17:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626902269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xS7zB88wP1Ct8tl3wZJBYvmGfA8uHUm0YRA5Jgo14nI=; b=RiJ1I3fhYr630IOji9XRmWIPPARE8oNVKson8hvGyAuq5TR+oBIgxYhOkN4y2KucvynwwD 0oWAaiDrx1Gr5Mc7v2YhKhy61fZ1h+WYdRiaVWEVPLbvhcCZpAg2kviPFnwGzB7CeLtsz3 KqrleK/8Dm+La8J2TDHkvUX88imb6AE= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-338-W3HWnPNhPXW4BFhhC-b2pw-1; Wed, 21 Jul 2021 17:17:47 -0400 X-MC-Unique: W3HWnPNhPXW4BFhhC-b2pw-1 Received: by mail-il1-f198.google.com with SMTP id a7-20020a9233070000b02901edc50cdfdcso2263393ilf.19 for ; Wed, 21 Jul 2021 14:17:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xS7zB88wP1Ct8tl3wZJBYvmGfA8uHUm0YRA5Jgo14nI=; b=U+PYdP57k8UoOqinecAnvusjmR9Xq0Rnw4MDcjrEQMOb5t+sIW63TTjYG2nJo+fZvU mmngdgSLI/vnAWfiUC7O+TlHDwtNXJQ/N2aLmXYzvcANk0+NuNsnHkN3R3Q9kiv/CSHe LV6wdRllaVGfpnyvJ0+ISWGh0tUv/Y/XwgkhXbrXVx4bTkHbdjjQT2+3uXmOriy4RuPi JdRqLyiluR5ovVOKdx1uXHDD4tCU964IKJZyP6GHnegEXXbzjeph2lQcbxa5YGTNs4iS z3QfQzeBDE9gO1Li/bkxOj0FDGkIvF3tMD75jqeqQ5TzRc5p0V8TrtbRW6gCNoYR30Fh ZGCg== X-Gm-Message-State: AOAM532uR84XtjFK8dYr9Cc2AhiIrESm/CYsQ241gWm+a4+nz5HpUIxD qaTRWqNKhS8b7/1ZBYMF2w+lceUdJ1MMix7fATPAgcLhKxXtC8pEEmektdqD4X3D0OIRYE/QJrG 46Q48bj/vTZXEdP0kv2zEqiM445oS2ujZL6U= X-Received: by 2002:a05:6638:240c:: with SMTP id z12mr32205864jat.41.1626902266899; Wed, 21 Jul 2021 14:17:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBlvz5/fIzXCPHPyLAiDDc3sODGKzE5IDkrPThRVZQuX/uKMDGuLWG9b8A3eweAr3W8umHRw== X-Received: by 2002:a05:6638:240c:: with SMTP id z12mr32205837jat.41.1626902266587; Wed, 21 Jul 2021 14:17:46 -0700 (PDT) Received: from gator ([140.82.166.162]) by smtp.gmail.com with ESMTPSA id w21sm14507636iol.52.2021.07.21.14.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jul 2021 14:17:45 -0700 (PDT) Date: Wed, 21 Jul 2021 23:17:43 +0200 From: Andrew Jones To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Srivatsa Vaddagiri , Shanker R Donthineni , will@kernel.org Subject: Re: [PATCH 10/16] KVM: arm64: Add some documentation for the MMIO guard feature Message-ID: <20210721211743.hb2cxghhwl2y22yh@gator> References: <20210715163159.1480168-1-maz@kernel.org> <20210715163159.1480168-11-maz@kernel.org> MIME-Version: 1.0 In-Reply-To: <20210715163159.1480168-11-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_141750_812305_24FB4E3C X-CRM114-Status: GOOD ( 30.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 15, 2021 at 05:31:53PM +0100, Marc Zyngier wrote: > Document the hypercalls user for the MMIO guard infrastructure. > > Signed-off-by: Marc Zyngier > --- > Documentation/virt/kvm/arm/index.rst | 1 + > Documentation/virt/kvm/arm/mmio-guard.rst | 73 +++++++++++++++++++++++ > 2 files changed, 74 insertions(+) > create mode 100644 Documentation/virt/kvm/arm/mmio-guard.rst > > diff --git a/Documentation/virt/kvm/arm/index.rst b/Documentation/virt/kvm/arm/index.rst > index 78a9b670aafe..e77a0ee2e2d4 100644 > --- a/Documentation/virt/kvm/arm/index.rst > +++ b/Documentation/virt/kvm/arm/index.rst > @@ -11,3 +11,4 @@ ARM > psci > pvtime > ptp_kvm > + mmio-guard > diff --git a/Documentation/virt/kvm/arm/mmio-guard.rst b/Documentation/virt/kvm/arm/mmio-guard.rst > new file mode 100644 > index 000000000000..a5563a3e12cc > --- /dev/null > +++ b/Documentation/virt/kvm/arm/mmio-guard.rst > @@ -0,0 +1,73 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + > +============== > +KVM MMIO guard > +============== > + > +KVM implements device emulation by handling translation faults to any > +IPA range that is not contained a memory slot. Such translation fault ^ in ^ a > +is in most cases passed on to userspace (or in rare cases to the host > +kernel) with the address, size and possibly data of the access for > +emulation. > + > +Should the guest exit with an address that is not one that corresponds > +to an emulatable device, userspace may take measures that are not the > +most graceful as far as the guest is concerned (such as terminating it > +or delivering a fatal exception). > + > +There is also an element of trust: by forwarding the request to > +userspace, the kernel asumes that the guest trusts userspace to do the assumes > +right thing. > + > +The KVM MMIO guard offers a way to mitigate this last point: a guest > +can request that only certainly regions of the IPA space are valid as certain > +MMIO. Only these regions will be handled as an MMIO, and any other > +will result in an exception being delivered to the guest. > + > +This relies on a set of hypercalls defined in the KVM-specific range, > +using the HVC64 calling convention. > + > +* ARM_SMCCC_KVM_FUNC_MMIO_GUARD_INFO > + > + ============== ======== ================================ > + Function ID: (uint32) 0xC6000002 > + Arguments: none > + Return Values: (int64) NOT_SUPPORTED(-1) on error, or > + (uint64) Protection Granule (PG) size in > + bytes (r0) > + ============== ======== ================================ > + > +* ARM_SMCCC_KVM_FUNC_MMIO_GUARD_ENROLL > + > + ============== ======== ============================== > + Function ID: (uint32) 0xC6000003 > + Arguments: none > + Return Values: (int64) NOT_SUPPORTED(-1) on error, or > + RET_SUCCESS(0) (r0) > + ============== ======== ============================== > + > +* ARM_SMCCC_KVM_FUNC_MMIO_GUARD_MAP > + > + ============== ======== ====================================== > + Function ID: (uint32) 0xC6000004 > + Arguments: (uint64) The base of the PG-sized IPA range > + that is allowed to be accessed as > + MMIO. Must aligned to the PG size (r1) align > + (uint64) Index in the MAIR_EL1 register > + providing the memory attribute that > + is used by the guest (r2) > + Return Values: (int64) NOT_SUPPORTED(-1) on error, or > + RET_SUCCESS(0) (r0) > + ============== ======== ====================================== > + > +* ARM_SMCCC_KVM_FUNC_MMIO_GUARD_UNMAP > + > + ============== ======== ====================================== > + Function ID: (uint32) 0xC6000004 copy+paste error, should be 0xC6000005 > + Arguments: (uint64) The base of the PG-sized IPA range > + that is forbidden to be accessed as is now forbidden or was allowed or just drop that part of the sentence because its covered by the "and have been previously mapped" part. Something like PG-sized IPA range aligned to the PG size which has been previously mapped (r1) > + MMIO. Must aligned to the PG size align > + and have been previously mapped (r1) > + Return Values: (int64) NOT_SUPPORTED(-1) on error, or > + RET_SUCCESS(0) (r0) > + ============== ======== ====================================== > -- > 2.30.2 > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm > Thanks, drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel