From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4164C6377D for ; Thu, 22 Jul 2021 08:23:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF4286127C for ; Thu, 22 Jul 2021 08:23:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF4286127C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5HOkCXz4lqjXlzHzsMpYyp6rdcupSAQAMheKmSnTpBc=; b=nM8YSzxrGfKI6y 5Ms4JIZnJGbzDVo4i4tVlWWEv6rPcLKI7hGZyNhSCpU+MsaD9di3nsI1h3IU1mjoNTEhZgx9X576I c+IH4fhajXaXwOJUU+0WL2qlRpjefzpLjjbrOWNfbUD0hYmnQwXJ+1E/v94AMZCdywlz65bz4zkTx imwsmrpp+zZdSTpekbkPsYSd85MDsS8x7JxzC4ioyRToUIGRFBjTZo0bXhiZ/ar1IFf23XYy00ldc mKBPZX5uJ72OHuT0BMzYbLwDkOXi5YLBnHbtDcb5KxmcULnZl3q7pYRUCFn1VZxrZ9EiyOQkJyEMt 9FAFE3a10Mn+nbTo03Tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6Txi-000fnt-8W; Thu, 22 Jul 2021 08:21:46 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6Txd-000fn6-Vp for linux-arm-kernel@lists.infradead.org; Thu, 22 Jul 2021 08:21:44 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1C1A65C009F; Thu, 22 Jul 2021 04:21:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 22 Jul 2021 04:21:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=l wdFUI+YBXEcZ/jDxkta5gm3PsZd7KMxnxVNOAYa4Fw=; b=iiETPZEG7yXJpgJfH 2QFCkMgNAFEwkDJB9NWXGwljheR2Kb5jf6BY4Yqo7nyY0LeHLK7t8Kyhnxjbj6jV f3Eq9/fQP5NlOhwSA5LWqCMkvlgX23eCpMs5xOu0LIMaAxfJ+duH8KkaI3bwSIPG Xdm7jahDoejN2I5wrpBl4ms7ws8tMivTBq7SBAqG7RBNlPTv3NrFI/l2YLk+oPvP X4QQNXeXDSburrpgn2zVOIDGuk6PWaMGWSxxL14GLqJcPL3AUTf30teriG039UzY o7+ocQMGALe+KB4gkhngc8mEJ4w7LzKMkYIfQr9jH6RO1LbxJpmdOqIFkC+djHZv KJsGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=lwdFUI+YBXEcZ/jDxkta5gm3PsZd7KMxnxVNOAYa4 Fw=; b=qPD4KI8gn+Yyr4gcn/D4SMp7b9tFRrTbblJV/Ut7YoV3fIF7zNxMzz1B1 8kiL0aacvZqfyEzkZX189LzIPFeDipOt3M6HcALGjSmPXwjk+/xkp6CYoiTGDfRa Z3JnIJNG/TD92CVGgVzC+FL9p+msf37KYh6QZNJzHDK0/Dl/sNbatYc9ZgG4aVCs y380Om/LjlwFy43Vl0SsiP3CKv5wbqiTZlc2pcJWUpF+4L+f5x3cigNo+eUT/dsJ FQT3ugC7tXZVZXOsDZrf8H9rz21+ac4vFvXM58V/Gv0h5At78Hc/nffmeYfibOEq 2JlOv8TYSodkJHSa4zM2gKa4lD/4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeeigddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepgfejtedtjefggfffvdetuedthedtheegheeuteekfeeghfdtteejkeeludeg vddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jul 2021 04:21:39 -0400 (EDT) Date: Thu, 22 Jul 2021 10:21:37 +0200 From: Maxime Ripard To: Jernej Skrabec Cc: wens@csie.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] arm64: dts: allwinner: h6: tanix-tx6: Add PIO power supplies Message-ID: <20210722082137.2kgbirwtayq4bl7x@gilmour> References: <20210721200832.916644-1-jernej.skrabec@gmail.com> <20210721200832.916644-2-jernej.skrabec@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210721200832.916644-2-jernej.skrabec@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210722_012142_361428_E1FECFF9 X-CRM114-Status: GOOD ( 16.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jul 21, 2021 at 10:08:31PM +0200, Jernej Skrabec wrote: > While there is no publicly available schematic of this board, it's not > hard to determine voltage of GPIO port C, D and G (only ones which can > be set). > > Port C and G are used for MMC/SDIO communication, so they use 1.8 V > power supply. It's not clear if port D is even used, but if it is, it's > pretty safe to assume it uses 3.3 V power supply. Value read from PIO > Group Withstand Voltage Mode Select register from within pre-installed > Android agrees with that assesment. > > Signed-off-by: Jernej Skrabec > --- > .../boot/dts/allwinner/sun50i-h6-tanix-tx6.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts > index be81330db14f..a1dd8f472cc8 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts > @@ -32,6 +32,13 @@ hdmi_con_in: endpoint { > }; > }; > > + reg_vcc1v8: vcc1v8 { > + compatible = "regulator-fixed"; > + regulator-name = "vcc1v8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + I appreciate that the other 3.3V regulator has the same issue, but the node name must reflect the class of the device. Maybe regulator-vcc1v8? Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel