From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B6BFC63793 for ; Thu, 22 Jul 2021 10:43:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41E8B61279 for ; Thu, 22 Jul 2021 10:43:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41E8B61279 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G7+h6W6dUyN/QSle/6zVFvgh0wIC1JKVdbiYg+e6dPE=; b=hIZpMDfXzdI4Nc bNvY/A4ZDl2LhlJXwfIithoQrBjP2kj3K78iSuB39IS0/vQR/VBdlw8Qpzl6wdZNQ1GBKy/BAqWSJ 5JDnrYPHelOc177oB9cNeTkoqJxiyvC0htrGtsl7opLoYu2LYDYpKPLoZvAEYCyey9XXOeb+2q3QS awPUrYmwcr7OdtE6+GOoRVguZKEX9kc767sHIvWwbPJi4ipx5yxn/tV7e98oUbF5ih+Mydo2F5+zn 2+ZMAqpdKPt3LERR3JRHNQ9yif3r+R1CiJauvF7jEtH2ynOxbT1ypyvVgl/Hz/n9NquYs1jkIecEX RE2iWlQ0Gc5BjTsxGi+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6W94-001Fqb-74; Thu, 22 Jul 2021 10:41:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6W90-001Fps-G6 for linux-arm-kernel@lists.infradead.org; Thu, 22 Jul 2021 10:41:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F312431B; Thu, 22 Jul 2021 03:41:30 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.9.64]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B45373F73D; Thu, 22 Jul 2021 03:41:29 -0700 (PDT) Date: Thu, 22 Jul 2021 11:41:24 +0100 From: Mark Rutland To: Jaxson Han Cc: andre.przywara@arm.com, linux-arm-kernel@lists.infradead.org, wei.chen@arm.com Subject: Re: [boot-wrapper PATCH v3 3/8] aarch64: Remove the redundant setup_stack Message-ID: <20210722104106.GA12199@C02TD0UTHF1T.local> References: <20210525062509.201464-1-jaxson.han@arm.com> <20210525062509.201464-4-jaxson.han@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210525062509.201464-4-jaxson.han@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210722_034134_623503_4826AC2E X-CRM114-Status: GOOD ( 16.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 25, 2021 at 02:25:04PM +0800, Jaxson Han wrote: > Since we already have set up a stack above, there is no need to do it > again. > Also, in fact it's a bug: setup_stack expects the logical CPU ID in > w0, and here we always call it with w0 being 1. > > Signed-off-by: Jaxson Han > Reviewed-by: Andre Przywara Since this is a bug-fix, I've cherry-picked this before all the other patches. Thanks, Mark. > --- > arch/aarch64/boot.S | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/aarch64/boot.S b/arch/aarch64/boot.S > index 1a5da35..1cdeb1b 100644 > --- a/arch/aarch64/boot.S > +++ b/arch/aarch64/boot.S > @@ -39,7 +39,6 @@ _start: > ldr x1, =flag_keep_el > str w0, [x1] > > - bl setup_stack > b start_keep_el > > /* > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel