From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D01E3C6377D for ; Thu, 22 Jul 2021 17:28:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BF3E6135A for ; Thu, 22 Jul 2021 17:28:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BF3E6135A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sCIy94hxlXRpF4eYfrgtdohNzh/Awa1jxmu0EcvCPM0=; b=F+0q15EbK8zR35 gHTb7XYi275hlbGaIKAOygH8AHuwGee5J4v+E9sSZc3jVwPYCnJRx1KDFtq5QD6S+hbCtlOPiQA4Z FURU7vaPln3ITypK8WIeFwBlMv2Wwj17F7VtBklBes6uWhMdzVK5MKh3xvikvkBqFrfVVeSjyuDY4 +AX/yTJOhPFXIhI3rzBuq7k404k8g/Qz55jNYn3e6PAMHEIUYQ3TvtGGFhxoKR3dHdaqfBPtk9fa5 oSa5thcgwY7VOkhLV8fhVtzzOHMaR87qJHPtJzx2DYyI/yLsCFpCTs3p/6UFg9FcV5Yzf2nzlyPym l3oUjM9AL48T6yF+rhbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6cSx-002J8A-8X; Thu, 22 Jul 2021 17:26:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6cSt-002J7H-47 for linux-arm-kernel@lists.infradead.org; Thu, 22 Jul 2021 17:26:32 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C645261358; Thu, 22 Jul 2021 17:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626974789; bh=4IqU9Z+o6ET0kK08k5QR9PdfMOnEz4ti7H4G7+Yim0U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U/8MEsGya6dK4aOoSlnwj+dO6eiagMt6rDAgYrQjX8anfzcLCYQIcyZO5VlNH4/yF 1xRzwMm0mu60EM4T7FuTVOl3OvTCTDadkk2u6M1+yaaBerxVpz65IEUBv9SRdeaCBR NhzKPRi8ZzP/BS9veRpCaEvgqxVTs+G0hn8KACF0q6qOjJtKk1I1S3LLLq+qL6ciem i23BGDWvWx4gIK8KhrNp+R4BnysfiyXArasgHC3ciBPPT5cTRb5WCYB5abulGb0f3b xhplA5OyTAXdVUg+Z1FLyjQRUXPWqiRXdpN46Sh1OLMLSUiJJG082b2ecfHlKohkeE O07XBLpyxG+ow== Received: by pali.im (Postfix) id 620D5805; Thu, 22 Jul 2021 19:26:27 +0200 (CEST) Date: Thu, 22 Jul 2021 19:26:27 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Kunihiko Hayashi Cc: Lorenzo Pieralisi , Bjorn Helgaas , Bjorn Helgaas , Rob Herring , Jingoo Han , Gustavo Pimentel , Marc Zyngier , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Jassi Brar , Masami Hiramatsu , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 3/3] PCI: uniphier: Add misc interrupt handler to invoke PME and AER Message-ID: <20210722172627.i4n65lrz3j7pduiz@pali> References: <1603848703-21099-4-git-send-email-hayashi.kunihiko@socionext.com> <20201124232037.GA595463@bjorn-Precision-5520> <20201125102328.GA31700@e121166-lin.cambridge.arm.com> <20210718005109.6xwe3z7gxhuop5xc@pali> <2dfa5ec9-2a33-ae72-3904-999d8b8a2f71@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2dfa5ec9-2a33-ae72-3904-999d8b8a2f71@socionext.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210722_102631_223159_EAA28937 X-CRM114-Status: GOOD ( 19.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Friday 23 July 2021 01:54:10 Kunihiko Hayashi wrote: > On 2021/07/18 9:51, Pali Rohar wrote: > > > > IMO this should be modelled with a separate IRQ domain and chip for > > > > the root port (yes this implies describing the root port in the dts > > > > file with a separate msi-parent). > > > > > > > > This series as it stands is a kludge. > > > > > > I see. However I need some time to consider the way to separate IRQ domain. > > > Is there any idea or example to handle PME/AER with IRQ domain? > > > > Seems that you are dealing with very similar issues as me with aardvark > > driver. > > > > As an inspiration look at my aardvark patch which setup separate IRQ > > domain for PME, AER and HP interrupts: > > https://lore.kernel.org/linux-pci/20210506153153.30454-32-pali@kernel.org/ > > > > Thanks to custom driver map_irq function, it is not needed to describe > > root port with separate msi-parent in DTS. > > I need to understand your solution, though, this might be the same situation as my driver. I think it is very very similar as aardvark also returns zero as hw irq number (and it is not possible to change it). So simple solution for you is also to register separate IRQ domain for Root Port Bridge and then re-trigger interrupt with number 0 (which you wrote that is default) as: virq = irq_find_mapping(priv->irq_domain, 0); generic_handle_irq(virq); in your uniphier_pcie_misc_isr() function. There is no need to modify DTS. And also no need to use complicated logic for finding registered virq number via pcie_port_service_get_irq() and uniphier_pcie_port_get_irq() functions. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel