Re: [PATCH V6 15/15] ARM: dts: imx6qdl-dhcom: Add DHSOM based DRC02 board

Marek Vasut
2021-07-18T16:24:39Z

On 7/18/21 5:33 PM, Fabio Estevam wrote:
> Hi Christoph,
>
> On 14/07/2021 18:07, Christoph Niedermaier wrote:
>
>> +/*
>> + * The kernel only distinguishes between i.MX6 Quad and DualLite,
>> + * but the Solo is actually a DualLite with only one CPU. So use
>> + * DualLite for the Solo and disable one CPU node.
>> + */
>> +
>> +#include "imx6dl.dtsi"
>> +#include "imx6qdl-dhcom-som.dtsi"
>> +#include "imx6qdl-dhcom-drc02.dtsi"
>> +
>> +/ {
>> +    model = "DH electronics i.MX6S DHCOM on DRC02";
>> +    compatible = "dh,imx6s-dhcom-drc02", "dh,imx6s-dhcom-som",
>> +             "fsl,imx6dl";
>> +
>> +    cpus {
>> +        cpu@1 {
>> +            status = "disabled";
>
> There is no need for disabling cpu1 here. The kernel will read the
> number of cores from the fuse and will bring-up the correct
> number of CPU cores.
>
> Other i.MX6Solo boards do not do this either.

I would argue the above is more accurate, since this thing is supposed
to be populated only with MX6 Solo. Even better might be to
/delete-node/ cpu@1 in fact.