From: Shawn Guo <shawnguo@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@denx.de>,
Christoph Niedermaier <cniedermaier@dh-electronics.com>,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>,
kernel@dh-electronics.com
Subject: Re: [PATCH V6 15/15] ARM: dts: imx6qdl-dhcom: Add DHSOM based DRC02 board
Date: Fri, 23 Jul 2021 15:08:03 +0800 [thread overview]
Message-ID: <20210723070802.GB30773@dragon> (raw)
In-Reply-To: <63a38c1a-2e71-9cff-e123-863c10e5c17f@denx.de>
On Sun, Jul 18, 2021 at 06:04:13PM +0200, Marek Vasut wrote:
> On 7/18/21 5:33 PM, Fabio Estevam wrote:
> > Hi Christoph,
> >
> > On 14/07/2021 18:07, Christoph Niedermaier wrote:
> >
> > > +/*
> > > + * The kernel only distinguishes between i.MX6 Quad and DualLite,
> > > + * but the Solo is actually a DualLite with only one CPU. So use
> > > + * DualLite for the Solo and disable one CPU node.
> > > + */
> > > +
> > > +#include "imx6dl.dtsi"
> > > +#include "imx6qdl-dhcom-som.dtsi"
> > > +#include "imx6qdl-dhcom-drc02.dtsi"
> > > +
> > > +/ {
> > > + model = "DH electronics i.MX6S DHCOM on DRC02";
> > > + compatible = "dh,imx6s-dhcom-drc02", "dh,imx6s-dhcom-som",
> > > + "fsl,imx6dl";
> > > +
> > > + cpus {
> > > + cpu@1 {
> > > + status = "disabled";
> >
> > There is no need for disabling cpu1 here. The kernel will read the
> > number of cores from the fuse and will bring-up the correct
> > number of CPU cores.
> >
> > Other i.MX6Solo boards do not do this either.
>
> I would argue the above is more accurate, since this thing is supposed to be
> populated only with MX6 Solo. Even better might be to /delete-node/ cpu@1 in
> fact.
Yes, if you want to get the description accurate, /delete-node/ might be
the right choice.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-23 7:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 21:06 [PATCH V6 01/15] ARM: dts: imx6q-dhcom: Add the parallel system bus Christoph Niedermaier
2021-07-14 21:07 ` [PATCH V6 02/15] ARM: dts: imx6q-dhcom: Add interrupt and compatible to the ethernet PHY Christoph Niedermaier
2021-07-23 3:59 ` Shawn Guo
2021-07-14 21:07 ` [PATCH V6 03/15] ARM: dts: imx6q-dhcom: Fill GPIO line names on DHCOM SoM Christoph Niedermaier
2021-07-23 4:01 ` Shawn Guo
2021-07-14 21:07 ` [PATCH V6 04/15] ARM: dts: imx6q-dhcom: Adding Wake pin to the PCIe pinctrl Christoph Niedermaier
2021-07-23 4:03 ` Shawn Guo
2021-07-14 21:07 ` [PATCH V6 05/15] ARM: dts: imx6q-dhcom: Align stdout-path with other DHCOM SoMs Christoph Niedermaier
2021-07-23 4:06 ` Shawn Guo
2021-07-14 21:07 ` [PATCH V6 06/15] ARM: dts: imx6q-dhcom: Add keys and leds to the PDK2 board Christoph Niedermaier
2021-07-23 4:07 ` Shawn Guo
2021-07-14 21:07 ` [PATCH V6 07/15] ARM: dts: imx6q-dhcom: Use 1G ethernet on " Christoph Niedermaier
2021-07-23 6:30 ` Shawn Guo
2021-07-14 21:07 ` [PATCH V6 08/15] ARM: dts: imx6q-dhcom: Rework of the DHCOM GPIO pinctrls Christoph Niedermaier
2021-07-23 6:40 ` Shawn Guo
2021-07-14 21:07 ` [PATCH V6 09/15] ARM: dts: imx6q-dhcom: Remove ddc-i2c-bus property Christoph Niedermaier
2021-07-23 6:41 ` Shawn Guo
2021-07-14 21:07 ` [PATCH V6 10/15] ARM: dts: imx6q-dhcom: Set minimum memory size of all DHCOM i.MX6 variants Christoph Niedermaier
2021-07-23 6:48 ` Shawn Guo
2021-07-14 21:07 ` [PATCH V6 11/15] ARM: dts: imx6q-dhcom: Rearrange of iomux Christoph Niedermaier
2021-07-14 21:07 ` [PATCH V6 12/15] ARM: dts: imx6q-dhcom: Cleanup of the devicetrees Christoph Niedermaier
2021-07-14 21:07 ` [PATCH V6 13/15] ARM: dts: imx6qdl-dhcom: Split SoC-independent parts of DHCOM SOM and PDK2 Christoph Niedermaier
2021-07-14 21:07 ` [PATCH V6 14/15] ARM: dts: imx6qdl-dhcom: Add DHCOM based PicoITX board Christoph Niedermaier
2021-07-14 21:07 ` [PATCH V6 15/15] ARM: dts: imx6qdl-dhcom: Add DHSOM based DRC02 board Christoph Niedermaier
2021-07-18 15:33 ` Fabio Estevam
2021-07-18 16:04 ` Marek Vasut
2021-07-23 7:08 ` Shawn Guo [this message]
2021-07-18 15:31 ` [PATCH V6 01/15] ARM: dts: imx6q-dhcom: Add the parallel system bus Fabio Estevam
2021-07-18 16:21 ` Marek Vasut
2021-07-23 3:56 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723070802.GB30773@dragon \
--to=shawnguo@kernel.org \
--cc=cniedermaier@dh-electronics.com \
--cc=festevam@denx.de \
--cc=kernel@dh-electronics.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox